From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by mx.groups.io with SMTP id smtpd.web11.435.1676655277942821367 for ; Fri, 17 Feb 2023 09:34:38 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=dYGLkB5j; spf=pass (domain: gmail.com, ip: 209.85.214.180, mailfrom: pedro.falcato@gmail.com) Received: by mail-pl1-f180.google.com with SMTP id f4so2241532plg.12 for ; Fri, 17 Feb 2023 09:34:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ShzFKnEkXwnWIEfzM9HDUhfg1yAfs7zDc5WOIWfn3KI=; b=dYGLkB5jdT26BVtMjaMTkjPpRd5WwnI1II9chUiEC81DvsD0xbSazlLK0KONaBTDq0 Xtf4YtTo9ZX2lx5WRJf29Tbh4XpFK1mjKJI8x7a145Q+HNRIceHjidsaI+ABu2vAgkga 6n+tHxaYBIvLZLr+T/7IQZIEYSIGJl3MgputfpIs2IlpW9+Cp4eHRUkzj7OdnSB4PxXN r2CE1nHQaYHReuaZEX0x8B8qNdAtLvCrTiWEDiTvqjALJ9nNwn0sHKPvZIFyii1rpvxN 44W+Swb39JNycyb6ZGybz1soR8MqZaHnR4EXZsvydN+YvOjD5lDKgh/BpKQmLBpXQz5U wwrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ShzFKnEkXwnWIEfzM9HDUhfg1yAfs7zDc5WOIWfn3KI=; b=Fr9byK1sh521n07y0eRQ8abCX7ypL8W9pWco9Q2NmtYHjwP8P2OL78+SLKKNhedZ39 jUEFXqJuq4kYF1c8CWJD8dssMbaXpRJNb3UhHazOyJHgTptseIHdC/S5S2TOqBoSGE+S KAvnTygD0VELpIqciZdFxzGa3/HcM8IGDm5LTErW9LweAeJ3GjQ9nspCF14h9A19gVOk /mZ1p4zZZERf5UXlbQ5oVqD9vFPRWhxSg+DoSkLG5jUhfH0RpJRiH5N1Ff4cGJro7/Kn wwhH3vm2rWkxEC0nJiElssUmdB86TipuPwcdLwfbfFvut4wCgRbqUH9iN/Y3bcinMHTj gryw== X-Gm-Message-State: AO0yUKVnYiFkAJBb0YXd74BgPLJikKBJiYqFMeK5wIMDX86zHLx59wxV aog2GvDPGuKsC7MFfQBxgr/VptsghPWWEHAq2uk= X-Google-Smtp-Source: AK7set+O8urW+Q3SHm8i1mTrnObx14lHtehhQOBenpe/NMeYkBTY/j7c4D9GHv/Hn9mVsvB7/UaMzoLCJpoK/NUv2Ug= X-Received: by 2002:a17:902:7c81:b0:196:6731:894c with SMTP id y1-20020a1709027c8100b001966731894cmr343683pll.21.1676655277460; Fri, 17 Feb 2023 09:34:37 -0800 (PST) MIME-Version: 1.0 References: <20230217085647.70781-1-savvamtr@gmail.com> In-Reply-To: <20230217085647.70781-1-savvamtr@gmail.com> From: "Pedro Falcato" Date: Fri, 17 Feb 2023 17:34:26 +0000 Message-ID: Subject: Re: [edk2-platforms][PATCH v4 1/1] Ext4Pkg: Fixes double-free in Ext4ReadSymlink To: Savva Mitrofanov Cc: devel@edk2.groups.io, =?UTF-8?Q?Marvin_H=C3=A4user?= , Vitaly Cheptsov Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Feb 17, 2023 at 8:56 AM Savva Mitrofanov wrote= : > > The SymlinkTmp was deallocated unconditionally, so we shouldn't free it > again on EFI_ERROR > > Cc: Marvin H=C3=A4user > Cc: Pedro Falcato > Cc: Vitaly Cheptsov > Fixes: e81432fbacb7 ("Ext4Pkg: Add symbolic links support") > Signed-off-by: Savva Mitrofanov > --- > Features/Ext4Pkg/Ext4Dxe/Symlink.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/Features/Ext4Pkg/Ext4Dxe/Symlink.c b/Features/Ext4Pkg/Ext4Dx= e/Symlink.c > index 1189a99ded2b..d80cb9fff92e 100644 > --- a/Features/Ext4Pkg/Ext4Dxe/Symlink.c > +++ b/Features/Ext4Pkg/Ext4Dxe/Symlink.c > @@ -243,7 +243,6 @@ Ext4ReadSymlink ( > Status > )); > FreePool (Symlink16Tmp); > - FreePool (SymlinkTmp); > return Status; > } > > -- > 2.39.1 > Thank you! Reviewed-by: Pedro Falcato --=20 Pedro