From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by mx.groups.io with SMTP id smtpd.web10.81334.1674756597710819069 for ; Thu, 26 Jan 2023 10:09:57 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=CDqkZjUS; spf=pass (domain: gmail.com, ip: 209.85.214.175, mailfrom: pedro.falcato@gmail.com) Received: by mail-pl1-f175.google.com with SMTP id jl3so2568530plb.8 for ; Thu, 26 Jan 2023 10:09:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=KkSqZqMrz3e9qlAv6tvK8HLnqdgTx1K4nrbobSS15I0=; b=CDqkZjUSp9HX5Fc/FTwBhp8No3BfJfSqr+w8N3JNJXlsvCZYipF3fMI+zC+e+4lMG4 0xcliS04YmfYsXoyUNaAx+IWnO7iDJguJXFhtL3MBNEG33RO5AdXFeh2Pxzc8HuwsDI9 5N4rv/bmpbJx/f7u0QbXA1gV0Ec2OT/03HFil2miNivlFwJyuwhVEZrDKMo89xSnyJOW hBfeJSy5s0sIElv3IK9xuQEE3LaRknDvoPq1NNva8Gn/VyJbhvS5aY8gOkFXgClaw6Zr uKgORKoCAzDGP12acqD5C2LQegWRl5fDBM+0LbMHDwRzkLCaEeEZgeljZCPW0uXEbfEe FR9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KkSqZqMrz3e9qlAv6tvK8HLnqdgTx1K4nrbobSS15I0=; b=F2ejdqbJw8/BZQFFSUHs62MFrnvHmB6+xiVxnuGn9PT8Gfqv3InD5qi3VRz5N+1Owi Uj9bqiY4oGQeDeFd0hglg0sM42DYQChLFcQQEqd4N54vBW9ngS52sasQUZPCj7iTaJMe kdj3BJhiiAKPMb691Yx1Awa9tBEXupqTZpGnXdWMlkQU6HUjvwyG4ESO64qAeHBI++WS aMoAzpcD+UNE/p/J/8v5IKGfs4WflMrUOX/CoN4t8pXsGAFeiFkcdeSCuYlSFXmCAAdS 1a2IxegobiiMXpDcLc5Wr9HR/Oslm08TvGdusssWXIKhY9XIqpl4dypU1qlhc7EUmyXK UsrQ== X-Gm-Message-State: AFqh2krtA1FQAnCJkOKcqJes58PfrEYX5P7bCiBF9JrweiXBGpmOkY3+ +VAoZEueYxHyBCS8ptn9bNisYQifIbjCtXn5YBynRQdVfFJHhQ== X-Google-Smtp-Source: AMrXdXvkvnXf2xTP9cL/wsxhGflijkrt5GAYR7l4JZZyu2i5TNC3vQUqefjsB/aNJVtc38RQnakjalZVmUWhlnCs+5E= X-Received: by 2002:a17:90a:1a03:b0:228:7eed:e756 with SMTP id 3-20020a17090a1a0300b002287eede756mr5846443pjk.166.1674756596924; Thu, 26 Jan 2023 10:09:56 -0800 (PST) MIME-Version: 1.0 References: <20230126180653.90243-1-mhaeuser@posteo.de> In-Reply-To: From: "Pedro Falcato" Date: Thu, 26 Jan 2023 18:09:44 +0000 Message-ID: Subject: Re: [PATCH 1/1] Ext4Pkg: Fix typos discovered by SpellCheck To: =?UTF-8?Q?Marvin_H=C3=A4user?= Cc: devel@edk2.groups.io Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Pushed as 9822126, thank you. On Thu, Jan 26, 2023 at 6:08 PM Pedro Falcato wro= te: > > On Thu, Jan 26, 2023 at 6:07 PM Marvin H=C3=A4user w= rote: > > > > Fix typos discovered by SpellCheck, which were discovered as part of th= e > > initial CI enablement effort. > > > > Cc: Pedro Falcato > > Signed-off-by: Marvin H=C3=A4user > > --- > > Features/Ext4Pkg/Ext4Dxe/BlockMap.c | 6 +++--- > > Features/Ext4Pkg/Ext4Dxe/Directory.c | 2 +- > > Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.h | 16 ++++++++-------- > > Features/Ext4Pkg/Ext4Dxe/Extents.c | 4 ++-- > > Features/Ext4Pkg/Ext4Dxe/File.c | 2 +- > > Features/Ext4Pkg/Ext4Dxe/Inode.c | 2 +- > > Features/Ext4Pkg/Ext4Dxe/Superblock.c | 6 +++--- > > Features/Ext4Pkg/Ext4Dxe/Symlink.c | 2 +- > > 8 files changed, 20 insertions(+), 20 deletions(-) > > > > diff --git a/Features/Ext4Pkg/Ext4Dxe/BlockMap.c b/Features/Ext4Pkg/Ext= 4Dxe/BlockMap.c > > index 2bc629fe9d38..8fee4476a5ac 100644 > > --- a/Features/Ext4Pkg/Ext4Dxe/BlockMap.c > > +++ b/Features/Ext4Pkg/Ext4Dxe/BlockMap.c > > @@ -131,7 +131,7 @@ Ext4GetBlockPath ( > > > > /** > > @brief Get an extent from a block map > > - Note: Also parses file holes and creates uninitialised extents from= them. > > + Note: Also parses file holes and creates uninitialized extents from= them. > > > > @param[in] Buffer Buffer of block pointers > > @param[in] IndEntries Number of entries in this block pointer= table > > @@ -173,7 +173,7 @@ Ext4GetExtentInBlockMap ( > > } > > } > > > > - // We mark the extent as uninitialised, although there's a differe= nce between uninit > > + // We mark the extent as uninitialized, although there's a differe= nce between uninit > > // extents and file holes. > > Extent->ee_len =3D EXT4_EXTENT_MAX_INITIALIZED + Count; > > return; > > @@ -206,7 +206,7 @@ Ext4GetExtentInBlockMap ( > > @param[in] LogicalBlock Block number which the returned exten= t must cover. > > @param[out] Extent Pointer to the output buffer, where t= he extent will be copied to. > > > > - @retval EFI_SUCCESS Retrieval was succesful. > > + @retval EFI_SUCCESS Retrieval was successful. > > @retval EFI_NO_MAPPING Block has no mapping. > > **/ > > EFI_STATUS > > diff --git a/Features/Ext4Pkg/Ext4Dxe/Directory.c b/Features/Ext4Pkg/Ex= t4Dxe/Directory.c > > index ba781bad968c..456916453952 100644 > > --- a/Features/Ext4Pkg/Ext4Dxe/Directory.c > > +++ b/Features/Ext4Pkg/Ext4Dxe/Directory.c > > @@ -16,7 +16,7 @@ > > @param[in] Entry Pointer to a EXT4_DIR_ENTRY. > > @param[out] Ucs2FileName Pointer to an array of CHAR16's, of= size EXT4_NAME_MAX + 1. > > > > - @retval EFI_SUCCESS The filename was succesfully retri= eved and converted to UCS2. > > + @retval EFI_SUCCESS The filename was successfully retr= ieved and converted to UCS2. > > @retval EFI_INVALID_PARAMETER The filename is not valid UTF-8. > > @retval !EFI_SUCCESS Failure. > > **/ > > diff --git a/Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.h b/Features/Ext4Pkg/Ext4= Dxe/Ext4Dxe.h > > index 41779dad855f..f608def7c9eb 100644 > > --- a/Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.h > > +++ b/Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.h > > @@ -155,7 +155,7 @@ Ext4UnrefDentry ( > > > > @param[out] Partition Partition structure to fill with filesyst= em > > details. > > - @retval EFI_SUCCESS Parsing was succesful and the partition i= s a > > + @retval EFI_SUCCESS Parsing was successful and the partition = is a > > valid ext4 partition. > > **/ > > EFI_STATUS > > @@ -322,7 +322,7 @@ Ext4ReadInode ( > > @param[out] Buffer Pointer to the buffer. > > @param[in] Offset Offset of the read. > > @param[in out] Length Pointer to the length of the buffer, = in bytes. > > - After a succesful read, it's updated = to the > > + After a successful read, it's updated= to the > > number of read bytes. > > > > @return Status of the read operation. > > @@ -355,7 +355,7 @@ cover. > > @param[out] Extent Pointer to the output buffer, where t= he extent > > will be copied to. > > > > - @retval EFI_SUCCESS Retrieval was succesful. > > + @retval EFI_SUCCESS Retrieval was successful. > > @retval EFI_NO_MAPPING Block has no mapping. > > **/ > > EFI_STATUS > > @@ -946,7 +946,7 @@ Ext4StrCmpInsensitive ( > > @param[in] Entry Pointer to a EXT4_DIR_ENTRY. > > @param[out] Ucs2FileName Pointer to an array of CHAR16's, of= size EXT4_NAME_MAX + 1. > > > > - @retval EFI_SUCCESS The filename was succesfully retri= eved and converted to UCS2. > > + @retval EFI_SUCCESS The filename was successfully retr= ieved and converted to UCS2. > > @retval EFI_INVALID_PARAMETER The filename is not valid UTF-8. > > @retval !EFI_SUCCESS Failure. > > **/ > > @@ -1106,7 +1106,7 @@ Ext4CalculateBlockGroupDescChecksum ( > > ); > > > > /** > > - Verifies the existance of a particular RO compat feature set. > > + Verifies the existence of a particular RO compat feature set. > > @param[in] Partition Pointer to the opened EXT4 part= ition. > > @param[in] RoCompatFeatureSet Feature set to test. > > > > @@ -1116,7 +1116,7 @@ Ext4CalculateBlockGroupDescChecksum ( > > ((Partition->FeaturesRoCompat & RoCompatFeatureSet) =3D=3D RoCompatF= eatureSet) > > > > /** > > - Verifies the existance of a particular compat feature set. > > + Verifies the existence of a particular compat feature set. > > @param[in] Partition Pointer to the opened EXT4 part= ition. > > @param[in] CompatFeatureSet Feature set to test. > > > > @@ -1126,7 +1126,7 @@ Ext4CalculateBlockGroupDescChecksum ( > > ((Partition->FeaturesCompat & CompatFeatureSet) =3D=3D CompatFeature= Set) > > > > /** > > - Verifies the existance of a particular compat feature set. > > + Verifies the existence of a particular compat feature set. > > @param[in] Partition Pointer to the opened EXT4 part= ition. > > @param[in] IncompatFeatureSet Feature set to test. > > > > @@ -1217,7 +1217,7 @@ Ext4GetExtentLength ( > > @param[in] LogicalBlock Block number which the returned exten= t must cover. > > @param[out] Extent Pointer to the output buffer, where t= he extent will be copied to. > > > > - @retval EFI_SUCCESS Retrieval was succesful. > > + @retval EFI_SUCCESS Retrieval was successful. > > @retval EFI_NO_MAPPING Block has no mapping. > > **/ > > EFI_STATUS > > diff --git a/Features/Ext4Pkg/Ext4Dxe/Extents.c b/Features/Ext4Pkg/Ext4= Dxe/Extents.c > > index f1964426d276..e1001d0a4292 100644 > > --- a/Features/Ext4Pkg/Ext4Dxe/Extents.c > > +++ b/Features/Ext4Pkg/Ext4Dxe/Extents.c > > @@ -219,7 +219,7 @@ Ext4ExtentIdxLeafBlock ( > > @param[in] LogicalBlock Block number which the returned exten= t must cover. > > @param[out] Extent Pointer to the output buffer, where t= he extent will be copied to. > > > > - @retval EFI_SUCCESS Retrieval was succesful. > > + @retval EFI_SUCCESS Retrieval was successful. > > @retval EFI_NO_MAPPING Block has no mapping. > > **/ > > EFI_STATUS > > @@ -615,7 +615,7 @@ Ext4GetExtentLength ( > > IN CONST EXT4_EXTENT *Extent > > ) > > { > > - // If it's an unintialized extent, the true length is ee_len - 2^15 > > + // If it's an uninitialized extent, the true length is ee_len - 2^15 > > if (EXT4_EXTENT_IS_UNINITIALIZED (Extent)) { > > return Extent->ee_len - EXT4_EXTENT_MAX_INITIALIZED; > > } > > diff --git a/Features/Ext4Pkg/Ext4Dxe/File.c b/Features/Ext4Pkg/Ext4Dxe= /File.c > > index 04198a53bfc0..8dfe324255f4 100644 > > --- a/Features/Ext4Pkg/Ext4Dxe/File.c > > +++ b/Features/Ext4Pkg/Ext4Dxe/File.c > > @@ -105,7 +105,7 @@ Ext4IsLastPathSegment ( > > @param[in out] File Pointer to the file we're opening. > > @param[in] OpenMode Mode in which to open the file. > > > > - @return True if the open was succesful, false if we don't= have > > + @return True if the open was successful, false if we don'= t have > > enough permissions. > > **/ > > STATIC > > diff --git a/Features/Ext4Pkg/Ext4Dxe/Inode.c b/Features/Ext4Pkg/Ext4Dx= e/Inode.c > > index 5ccb4d2bfc42..e44b5638599f 100644 > > --- a/Features/Ext4Pkg/Ext4Dxe/Inode.c > > +++ b/Features/Ext4Pkg/Ext4Dxe/Inode.c > > @@ -76,7 +76,7 @@ Ext4CalculateInodeChecksum ( > > @param[out] Buffer Pointer to the buffer. > > @param[in] Offset Offset of the read. > > @param[in out] Length Pointer to the length of the buffer, = in bytes. > > - After a succesful read, it's updated = to the number of read bytes. > > + After a successful read, it's updated= to the number of read bytes. > > > > @return Status of the read operation. > > **/ > > diff --git a/Features/Ext4Pkg/Ext4Dxe/Superblock.c b/Features/Ext4Pkg/E= xt4Dxe/Superblock.c > > index edee051c41e8..5a3c7f478187 100644 > > --- a/Features/Ext4Pkg/Ext4Dxe/Superblock.c > > +++ b/Features/Ext4Pkg/Ext4Dxe/Superblock.c > > @@ -151,7 +151,7 @@ Ext4VerifySuperblockChecksum ( > > Opens and parses the superblock. > > > > @param[out] Partition Partition structure to fill with filesyst= em details. > > - @retval EFI_SUCCESS Parsing was succesful and the partition i= s a > > + @retval EFI_SUCCESS Parsing was successful and the partition = is a > > valid ext4 partition. > > **/ > > EFI_STATUS > > @@ -203,7 +203,7 @@ Ext4OpenSuperblock ( > > > > // Now, check for the feature set of the filesystem > > // It's essential to check for this to avoid filesystem corruption a= nd to avoid > > - // accidentally opening an ext2/3/4 filesystem we don't understand, = which would be disasterous. > > + // accidentally opening an ext2/3/4 filesystem we don't understand, = which would be disastrous. > > > > if (Partition->FeaturesIncompat & ~gSupportedIncompatFeat) { > > DEBUG (( > > @@ -312,7 +312,7 @@ Ext4OpenSuperblock ( > > return EFI_OUT_OF_RESOURCES; > > } > > > > - // Note that the cast below is completely safe, because EXT4_FILE is= a specialisation of EFI_FILE_PROTOCOL > > + // Note that the cast below is completely safe, because EXT4_FILE is= a specialization of EFI_FILE_PROTOCOL > > Status =3D Ext4OpenVolume (&Partition->Interface, (EFI_FILE_PROTOCOL= **)&Partition->Root); > > > > if (EFI_ERROR (Status)) { > > diff --git a/Features/Ext4Pkg/Ext4Dxe/Symlink.c b/Features/Ext4Pkg/Ext4= Dxe/Symlink.c > > index 0905417ffb88..19b357ac6ba0 100644 > > --- a/Features/Ext4Pkg/Ext4Dxe/Symlink.c > > +++ b/Features/Ext4Pkg/Ext4Dxe/Symlink.c > > @@ -201,7 +201,7 @@ Ext4ReadSymlink ( > > CHAR16 *Needle; > > > > // > > - // Assume that we alread read Inode via Ext4ReadInode > > + // Assume that we already read Inode via Ext4ReadInode > > // Skip reading, just check encryption flag > > // > > if ((File->Inode->i_flags & EXT4_ENCRYPT_FL) !=3D 0) { > > -- > > 2.39.1 > > > > Reviewed-by: Pedro Falcato > > -- > Pedro --=20 Pedro