From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vs1-f42.google.com (mail-vs1-f42.google.com [209.85.217.42]) by mx.groups.io with SMTP id smtpd.web09.113.1643385640558125839 for ; Fri, 28 Jan 2022 08:00:40 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=R1DRQUIW; spf=pass (domain: gmail.com, ip: 209.85.217.42, mailfrom: pedro.falcato@gmail.com) Received: by mail-vs1-f42.google.com with SMTP id b2so3546837vso.9 for ; Fri, 28 Jan 2022 08:00:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=wVVVGzGgegps9fUZUTpRn8bOMvnjpyBMS+BdkO4u2Gc=; b=R1DRQUIWut7mPRREr3TiKbEsXvBEMfyN+lO/0RSN/tfjaRx3RKvCgsvyA7rlv5kdBe a2DCQCPuicc9/Unts3VEXofBd5ctFnvsYTMSyM3D9NUb3NvI9fZBemvl/V7cMwpT/5uo xPdjOn/gluSO3sW5iX78A/OcKeGmFzrvvdZgFx5JvuaYrbyDNn6AOdfJoEjztOYmEQC+ B3+e9aBo8WyI3XMyWMdDOzZWoqsemudpzr2q1VyAS2k6lCSXm/EBoVOCj43PsuidkaDC cCBP+blaxI4XicXDOBzNNI98Ai5OnSKwXxS9YOWQhTspdEe5MBXIpC/3kQ/pLoOM+WHt bMuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=wVVVGzGgegps9fUZUTpRn8bOMvnjpyBMS+BdkO4u2Gc=; b=ev2zcik0wYIshyqWEPie/kO75jme1BNEkIW8Z8XFWGFx6cBenGoGUvSErunj7IsHT0 dj2Hbbw3IwczAsVmE+0wZnhINOQC/0lhitfgAfsSvFmI4oTzV/sL6+OH+9a8BQCj6zBJ 92iZQTaQyg8BX1+Tzw2fzqZ+FBjs4IJqgWhh5UaXAuMlkk0fl4be1IDrfBG1BBdIjNLO mi4Na8aK15bEBk1ySqFRE7AXHKJILn2zQZNTDKDPQwv/32yhWWHCGMjeD2HrLJX1fUnf uDOZJkkiCb1N0MZ/zaZ8bJBEJkJ+J9PUUYa0FtkPu+Yfy1Cqhh6qe4Y4nxczR7N7TJvP lFSA== X-Gm-Message-State: AOAM5308QL3qOzmN/iDhcYPjtCRNd5grPSk7HsfdpBdYwd3j1vtYrSp1 Uxh9MNDSMypYQ3nAPmjAMSNsj39nO3f7/LIz7Oy6aOO7pic= X-Google-Smtp-Source: ABdhPJw1EZwK9E+AseiDjo2iMAWX0dUXYzwvkL6ftaI3CNakm3COk11QAvOim7vYEOKSsOCxxEN56UsylZ/mYM1jihs= X-Received: by 2002:a05:6102:153:: with SMTP id a19mr3957870vsr.75.1643385639339; Fri, 28 Jan 2022 08:00:39 -0800 (PST) MIME-Version: 1.0 References: <20220128140723.isljt6lz6the7k5y@sirius.home.kraxel.org> In-Reply-To: <20220128140723.isljt6lz6the7k5y@sirius.home.kraxel.org> From: "Pedro Falcato" Date: Fri, 28 Jan 2022 16:00:26 +0000 Message-ID: Subject: Re: [edk2-devel] [PATCH 00/24] CryptoPkg/openssl: update openssl submodule to v3.0 To: edk2-devel-groups-io , kraxel@redhat.com Content-Type: multipart/alternative; boundary="000000000000430ceb05d6a68923" --000000000000430ceb05d6a68923 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Also, quick note: I've seen linking blowing up because the ABIs being used in the bare metal code and in libgcc were different; this was in riscv64. I know x86 doesn't do such checks but a few others do, including RISCV (they tag object files with the ABI). This makes libgcc unusable in such architectures. If we want to provide intrinsics, then possibly shipping our own compiler-rt would be the only solid option. On Fri, 28 Jan 2022, 14:07 Gerd Hoffmann, wrote: > Hi, > > Oops, dropped the list by mistake, forwarding ... > > ----- Forwarded message from "kraxel@redhat.com" ----= - > > Date: Fri, 28 Jan 2022 10:35:10 +0100 > Subject: Re: [edk2-devel] [PATCH 00/24] CryptoPkg/openssl: update openssl > submodule to v3.0 > From: "kraxel@redhat.com" > To: Kilian Kegel > Message-ID: <20220128093510.atupc4ly6bvwinlk@sirius.home.kraxel.org> > Content-Type: text/plain; charset=3Dutf-8 > > Hi, > > > On my 32Bit Ubuntu standard installation I ran > > > > 1. cc - Xlinker -Map=3Dstatic.map hello.c -static > > 2. cc -Xlinker -Map=3Dshared.map hello.c > > > > The first .OBJ file mentioned in the .MAP file is in both cases: > > /usr/lib/gcc/i686-linux-gnu/6/libgcc.a(_udivdi3.o) > > Yes, you are correct. gcc provides both shared and static intrinsics. > There is a command line switch to pick which one you want > (-static-libgcc, -shared-libgcc). > > > It seems to me that GNU holds the intrinsic functions in a separate > library > > that can be used without any change, and is always correct by definitio= n. > > > 1. add libgcc.a as a search library, adjust the conf\tools_def.txt > like: > > > > DEBUG_GCCxx_IA32_DLINK_FLAGS =3D =E2=80=A6predefined parameter =E2=80= =A6 > /usr/lib/gcc/i686-linux-gnu/6/libgcc.a > > gcc documentation suggests to use just '-lgcc' (should pick the correct > library no matter what the compiler version and architecture is), so I > tried this: > > -DEFINE GCC_DLINK2_FLAGS_COMMON =3D > -Wl,--script=3D$(EDK_TOOLS_PATH)/Scripts/GccBase.lds > +DEFINE GCC_DLINK2_FLAGS_COMMON =3D > -Wl,--script=3D$(EDK_TOOLS_PATH)/Scripts/GccBase.lds -lgcc > > Build doesn't come very far. Looks like the gcc intrinsics are not > free-standing but want call into libc: > > /usr/bin/ld: /usr/lib/gcc/x86_64-redhat-linux/11/libgcc.a(_absvsi2.o): in > function `__absvdi2': > (.text+0x18): undefined reference to `abort' > /usr/bin/ld: /usr/lib/gcc/x86_64-redhat-linux/11/libgcc.a(_absvsi2.o): in > function `__absvsi2': > (.text+0x32): undefined reference to `abort' > /usr/bin/ld: /usr/lib/gcc/x86_64-redhat-linux/11/libgcc.a(_absvdi2.o): in > function `__absvti2.cold': > (.text.unlikely+0x2): undefined reference to `abort' > /usr/bin/ld: /usr/lib/gcc/x86_64-redhat-linux/11/libgcc.a(_addvsi3.o): in > function `__addvdi3': > (.text+0xf): undefined reference to `abort' > /usr/bin/ld: /usr/lib/gcc/x86_64-redhat-linux/11/libgcc.a(_addvsi3.o): in > function `__addvsi3': > (.text+0x2d): undefined reference to `abort' > /usr/bin/ld: > /usr/lib/gcc/x86_64-redhat-linux/11/libgcc.a(_addvdi3.o):(.text.unlikely+= 0x2): > more undefined references to `abort' follow > /usr/bin/ld: /usr/lib/gcc/x86_64-redhat-linux/11/libgcc.a(_eprintf.o): in > function `__eprintf': > (.text+0x8): undefined reference to `stderr' > /usr/bin/ld: (.text+0x1d): undefined reference to `fprintf' > /usr/bin/ld: (.text+0x25): undefined reference to `fflush' > /usr/bin/ld: (.text+0x2a): undefined reference to `abort' > /usr/bin/ld: > /usr/lib/gcc/x86_64-redhat-linux/11/libgcc.a(generic-morestack.o): in > function `__morestack_fail': > (.text+0xbc): undefined reference to `writev' > [ ... more errors snipped ... ] > > The generic-morestack.o issues should be solvable, that shouldn't be > something which tianocore actually needs. Not sure why the linker tries > to resolve symbols for object files which should not be needed in the > first place. Possibly something else is fishy here, any hints are > welcome. Something in the linker script maybe? > > But the math intrinsics apparently having error paths which print a > message and abort doesn't look very promising to me. > > Also: When trying arm cross-builds I run into the ABI problem already > mentioned elsewhere in this thread: > > /usr/bin/arm-linux-gnu-ld: error: > /usr/lib/gcc/arm-linux-gnueabi/11/libgcc.a(_muldi3.o) uses VFP register > arguments, > /home/kraxel/projects/edk2/Build/ArmVirtQemu-ARM/DEBUG_GCC5/ARM/OvmfPkg/V= irtioBlkDxe/VirtioBlk/DEBUG/VirtioBlkDxe.dll > does not > > Patches are here: > https://github.com/kraxel/edk2/commits/intrinsics-playground > > > >* I have my doubts that compiler's builtin libraries are optimized for > > > size, so I'd suspect we would see a noticeable size grow from that. > > Please check the size of __udivdi3() and whether the tianocore > reimplementation is smaller or not > > I'll rather check the size of the final binaries, but I can only do that > once the build works ... > > > The intrinsic library belongs to the compiler not to the build system. > > I'm open to explore that path, but apparently we have a number of road > blocks along the way. Seems neither gcc nor xcode (see other reply) > provide a usable free-standing intrinsic library ... > > take care, > Gerd > > > >=20 > > > --000000000000430ceb05d6a68923 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Also, quick note: I've seen linking blowing up becaus= e the ABIs being used in the bare metal code and in libgcc were different; = this was in riscv64. I know x86 doesn't do such checks but a few others= do, including RISCV (they tag object files with the ABI). This makes libgc= c unusable in such architectures.

If we want to provide intrinsics, then possibly shipping our own compil= er-rt would be the only solid option.

On Fri, 28 Jan 2022, 14:07 Gerd = Hoffmann, <kraxel@redhat.com>= ; wrote:
=C2=A0 Hi,

Oops, dropped the list by mistake, forwarding ...

----- Forwarded message from "kraxel@redhat.com" <kraxel@r= edhat.com> -----

Date: Fri, 28 Jan 2022 10:35:10 +0100
Subject: Re: [edk2-devel] [PATCH 00/24] CryptoPkg/openssl: update openssl =C2=A0submodule to v3.0
From: "kraxel@redhat.com" <kraxel@redhat.com>
To: Kilian Kegel <kilian_kegel@outlook.com>
Message-ID: <20220128093510.atupc4ly= 6bvwinlk@sirius.home.kraxel.org>
Content-Type: text/plain; charset=3Dutf-8

=C2=A0 Hi,

> On my 32Bit Ubuntu standard installation I ran
>
>=C2=A0 =C2=A01.=C2=A0 cc - Xlinker -Map=3Dstatic.map hello.c -static >=C2=A0 =C2=A02.=C2=A0 cc=C2=A0 -Xlinker -Map=3Dshared.map hello.c
>
> The first .OBJ file mentioned in the .MAP file is in both cases:
> /usr/lib/gcc/i686-linux-gnu/6/libgcc.a(_udivdi3.o)

Yes, you are correct.=C2=A0 gcc provides both shared and static intrinsics.=
There is a command line switch to pick which one you want
(-static-libgcc, -shared-libgcc).

> It seems to me that GNU holds the intrinsic functions in a separate li= brary
> that can be used without any change, and is always correct by definiti= on.

>=C2=A0 =C2=A01.=C2=A0 add libgcc.a as a search library, adjust the conf= \tools_def.txt like:
>
> DEBUG_GCCxx_IA32_DLINK_FLAGS=C2=A0 =C2=A0=3D =E2=80=A6predefined param= eter =E2=80=A6 /usr/lib/gcc/i686-linux-gnu/6/libgcc.a

gcc documentation suggests to use just '-lgcc' (should pick the cor= rect
library no matter what the compiler version and architecture is), so I
tried this:

-DEFINE GCC_DLINK2_FLAGS_COMMON=C2=A0 =C2=A0 =C2=A0=3D -Wl,--script=3D$(EDK= _TOOLS_PATH)/Scripts/GccBase.lds
+DEFINE GCC_DLINK2_FLAGS_COMMON=C2=A0 =C2=A0 =C2=A0=3D -Wl,--script=3D$(EDK= _TOOLS_PATH)/Scripts/GccBase.lds -lgcc

Build doesn't come very far.=C2=A0 Looks like the gcc intrinsics are no= t
free-standing but want call into libc:

/usr/bin/ld: /usr/lib/gcc/x86_64-redhat-linux/11/libgcc.a(_absvsi2.o): in f= unction `__absvdi2':
(.text+0x18): undefined reference to `abort'
/usr/bin/ld: /usr/lib/gcc/x86_64-redhat-linux/11/libgcc.a(_absvsi2.o): in f= unction `__absvsi2':
(.text+0x32): undefined reference to `abort'
/usr/bin/ld: /usr/lib/gcc/x86_64-redhat-linux/11/libgcc.a(_absvdi2.o): in f= unction `__absvti2.cold':
(.text.unlikely+0x2): undefined reference to `abort'
/usr/bin/ld: /usr/lib/gcc/x86_64-redhat-linux/11/libgcc.a(_addvsi3.o): in f= unction `__addvdi3':
(.text+0xf): undefined reference to `abort'
/usr/bin/ld: /usr/lib/gcc/x86_64-redhat-linux/11/libgcc.a(_addvsi3.o): in f= unction `__addvsi3':
(.text+0x2d): undefined reference to `abort'
/usr/bin/ld: /usr/lib/gcc/x86_64-redhat-linux/11/libgcc.a(_addvdi3.o):(.tex= t.unlikely+0x2): more undefined references to `abort' follow
/usr/bin/ld: /usr/lib/gcc/x86_64-redhat-linux/11/libgcc.a(_eprintf.o): in f= unction `__eprintf':
(.text+0x8): undefined reference to `stderr'
/usr/bin/ld: (.text+0x1d): undefined reference to `fprintf'
/usr/bin/ld: (.text+0x25): undefined reference to `fflush'
/usr/bin/ld: (.text+0x2a): undefined reference to `abort'
/usr/bin/ld: /usr/lib/gcc/x86_64-redhat-linux/11/libgcc.a(generic-morestack= .o): in function `__morestack_fail':
(.text+0xbc): undefined reference to `writev'
[ ... more errors snipped ... ]

The generic-morestack.o issues should be solvable, that shouldn't be something which tianocore actually needs.=C2=A0 Not sure why the linker tri= es
to resolve symbols for object files which should not be needed in the
first place.=C2=A0 Possibly something else is fishy here, any hints are
welcome.=C2=A0 Something in the linker script maybe?

But the math intrinsics apparently having error paths which print a
message and abort doesn't look very promising to me.

Also: When trying arm cross-builds I run into the ABI problem already
mentioned elsewhere in this thread:

/usr/bin/arm-linux-gnu-ld: error: /usr/lib/gcc/arm-linux-gnueabi/11/libgcc.= a(_muldi3.o) uses VFP register arguments, /home/kraxel/projects/edk2/Build/= ArmVirtQemu-ARM/DEBUG_GCC5/ARM/OvmfPkg/VirtioBlkDxe/VirtioBlk/DEBUG/VirtioB= lkDxe.dll does not

Patches are here:
=C2=A0 https://github.com/kra= xel/edk2/commits/intrinsics-playground

> >* I have my doubts that compiler's builtin libraries are optim= ized for
> >=C2=A0 =C2=A0size, so I'd suspect we would see a noticeable si= ze grow from that.
> Please check the size of __udivdi3() and whether the tianocore reimple= mentation is smaller or not

I'll rather check the size of the final binaries, but I can only do tha= t
once the build works ...

> The intrinsic library belongs to the compiler not to the build system.=

I'm open to explore that path, but apparently we have a number of road<= br> blocks along the way.=C2=A0 Seems neither gcc nor xcode (see other reply) provide a usable free-standing intrinsic library ...

take care,
=C2=A0 Gerd






--000000000000430ceb05d6a68923--