From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) by mx.groups.io with SMTP id smtpd.web08.1180.1663106046488477902 for ; Tue, 13 Sep 2022 14:54:06 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=EJIbO7oM; spf=pass (domain: gmail.com, ip: 209.85.214.176, mailfrom: pedro.falcato@gmail.com) Received: by mail-pl1-f176.google.com with SMTP id p18so13174132plr.8 for ; Tue, 13 Sep 2022 14:54:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=VSbdjzBtGkDHd03pIupcy/4MbjADJniPJhBM081oNho=; b=EJIbO7oMJtqmE8xDQua1r3C9dm7ThsQtveLoH4yteTNymiXauINJ5ny3EZq1S9DpeH LMURX9L+vPF7e3CYens+5b5VpHqvvA4WRSdbSijYn7Y8TouPEmJ6yvdZMYfqwCp2gCtv 2lPEdNn255/bX5Lw9xnr0VONnMR4NabGogytflboLbkhPgDk/2EspSbJQA1o79TOSuI+ WtGyywN2AMKGTa7pxrbhYDgqHqxguniGaMsItFWg43BLogBVJ8f7ONWINFxY+ZQDptDT XolcAzMZ8RNL/m5nr96WHooSEaG4c2qlgxNrBBrmpLWEUZph+fZu2ZaU29wqmufvovKr jq+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=VSbdjzBtGkDHd03pIupcy/4MbjADJniPJhBM081oNho=; b=tPaYZYMeGd/pWmZ8S1L9G95zIfESKLG13FcmBfI6xJPxOhhp+euFOrzKrKGkR9eJYS Sw3ne1UXXx9sVDeanEYp2WnDXXMLO5orAu5d6zA5HtfA7gi8bZbvKGjrwxQHoqVO8XY7 KlFRQh+Jyh9Qr2bNsmgqoGWVxmxMoLRRPzD0LiRp3g6ji31YvxZn1Dpql15QGgLyO8JY BD2HbXx8LaxeSATWpH1cbiFwdLR9+2Bsn+2zl6ZcXD3UIB4GY5+GOhnI++v2uV92MkvK qRt3A2ad9Whl6s6VnF7zoqB0rzf8a7Qg3T7Gm4qz4NnNsv2zFjDmXj3gNhcKAzHneODN 6nWQ== X-Gm-Message-State: ACgBeo11ZsjDH8yCIHfXY9jhgTPbMWKwtNziMPuH4epKzNWnnnaVSrAb oew1XPUfuQhIA+RAxQlKea8Few+yOJ4HVbGh/Xo= X-Google-Smtp-Source: AA6agR6iau9CsIjW+VSuR6dsXq4vauxK0MTEO/ICHU4bQVPXsYq0KoqKSbEyQKe6gzt5ANfPwVVeuWXuzli+2YsF0qk= X-Received: by 2002:a17:902:c950:b0:178:4544:55c1 with SMTP id i16-20020a170902c95000b00178454455c1mr5781202pla.168.1663106045972; Tue, 13 Sep 2022 14:54:05 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: "Pedro Falcato" Date: Tue, 13 Sep 2022 22:53:54 +0100 Message-ID: Subject: Re: [edk2-devel][edk2-platforms][PATCH V3 0/4] QemuOpenBoardPkg: Add QemuOpenBoardPkg To: Theo Jehl Cc: edk2-devel-groups-io , Leif Lindholm , Michael D Kinney , Isaac Oram , Gerd Hoffmann , Stefan Hajnoczi Content-Type: multipart/alternative; boundary="00000000000018168605e8960d64" --00000000000018168605e8960d64 Content-Type: text/plain; charset="UTF-8" Series-Reviewed-by: Pedro Falcato On Tue, Sep 13, 2022 at 10:32 PM Theo Jehl wrote: > QemuOpenBoardPkg adds a MinPlatform port to Qemu x86_64 > It can boots UEFI Linux and Windows, and works on PIIX4 and Q35 > This board port provides a simple starting place for investigating edk2 and > MinPlatform Arch. > Currently we implement up to stage 4 of the MinPlatform spec and can boot > Windows/Linux. > > V2 splits the package into several commits. > Each commit corresponding to a MinPlatform architecture stage. > > The V3 removes specials characters in "Theo" from file headers. > Cleaned up whitespace, punctuation, commenting to better match coding > style and conventions > Fixed Visual Studio build issue converting UINT64 to UINT32. > Fixed build issues related to sync with latest master. > > Cc: Leif Lindholm > Cc: Michael D Kinney > Cc: Isaac Oram > Cc: Pedro Falcato > Cc: Gerd Hoffmann > Cc: Stefan Hajnoczi > > Signed-off-by: Theo Jehl > > Theo Jehl (4): > QemuOpenBoardPkg: Add QemuOpenBoardPkg > QemuOpenBoardPkg: Enable stage 2 > QemuOpenBoardPkg: Enable stage 3 > QemuOpenBoardPkg: Enable stage 4 > > .../QemuOpenBoardPkg/QemuOpenBoardPkg.dec | 33 ++ > .../Include/Dsc/Stage1.dsc.inc | 55 +++ > .../Include/Dsc/Stage2.dsc.inc | 31 ++ > .../Include/Dsc/Stage3.dsc.inc | 101 ++++++ > .../Include/Dsc/Stage4.dsc.inc | 56 +++ > .../QemuOpenBoardPkg/QemuOpenBoardPkg.dsc | 169 +++++++++ > .../QemuOpenBoardPkg/QemuOpenBoardPkg.fdf | 328 ++++++++++++++++++ > .../BoardBootManagerLib.inf | 39 +++ > .../Library/BoardInitLib/BoardInitLib.inf | 29 ++ > .../Library/PeiReportFvLib/PeiReportFvLib.inf | 63 ++++ > .../Library/PlatformSecLib/PlatformSecLib.inf | 49 +++ > .../QemuOpenFwCfgLib/QemuOpenFwCfgLib.inf | 23 ++ > .../PlatformInitPei/PlatformInitPei.inf | 59 ++++ > .../Include/Library/QemuOpenFwCfgLib.h | 105 ++++++ > .../PlatformInitPei/PlatformInit.h | 59 ++++ > .../BoardBootManagerLib/BoardBootManager.c | 105 ++++++ > .../Library/BoardInitLib/BoardInitLib.c | 231 ++++++++++++ > .../Library/PeiReportFvLib/PeiReportFvLib.c | 285 +++++++++++++++ > .../Library/PlatformSecLib/PlatformSecLib.c | 140 ++++++++ > .../QemuOpenFwCfgLib/QemuOpenFwCfgLib.c | 136 ++++++++ > .../QemuOpenBoardPkg/PlatformInitPei/Cpu.c | 64 ++++ > .../QemuOpenBoardPkg/PlatformInitPei/Memory.c | 254 ++++++++++++++ > .../QemuOpenBoardPkg/PlatformInitPei/Pci.c | 70 ++++ > .../QemuOpenBoardPkg/PlatformInitPei/Pcie.c | 106 ++++++ > .../PlatformInitPei/PlatformInit.c | 75 ++++ > .../Include/Fdf/FlashMap.fdf.inc | 94 +++++ > .../Library/PlatformSecLib/Ia32/SecEntry.nasm | 117 +++++++ > Platform/Qemu/QemuOpenBoardPkg/README.md | 53 +++ > 28 files changed, 2929 insertions(+) > create mode 100644 Platform/Qemu/QemuOpenBoardPkg/QemuOpenBoardPkg.dec > create mode 100644 > Platform/Qemu/QemuOpenBoardPkg/Include/Dsc/Stage1.dsc.inc > create mode 100644 > Platform/Qemu/QemuOpenBoardPkg/Include/Dsc/Stage2.dsc.inc > create mode 100644 > Platform/Qemu/QemuOpenBoardPkg/Include/Dsc/Stage3.dsc.inc > create mode 100644 > Platform/Qemu/QemuOpenBoardPkg/Include/Dsc/Stage4.dsc.inc > create mode 100644 Platform/Qemu/QemuOpenBoardPkg/QemuOpenBoardPkg.dsc > create mode 100644 Platform/Qemu/QemuOpenBoardPkg/QemuOpenBoardPkg.fdf > create mode 100644 > Platform/Qemu/QemuOpenBoardPkg/Library/BoardBootManagerLib/BoardBootManagerLib.inf > create mode 100644 > Platform/Qemu/QemuOpenBoardPkg/Library/BoardInitLib/BoardInitLib.inf > create mode 100644 > Platform/Qemu/QemuOpenBoardPkg/Library/PeiReportFvLib/PeiReportFvLib.inf > create mode 100644 > Platform/Qemu/QemuOpenBoardPkg/Library/PlatformSecLib/PlatformSecLib.inf > create mode 100644 > Platform/Qemu/QemuOpenBoardPkg/Library/QemuOpenFwCfgLib/QemuOpenFwCfgLib.inf > create mode 100644 > Platform/Qemu/QemuOpenBoardPkg/PlatformInitPei/PlatformInitPei.inf > create mode 100644 > Platform/Qemu/QemuOpenBoardPkg/Include/Library/QemuOpenFwCfgLib.h > create mode 100644 > Platform/Qemu/QemuOpenBoardPkg/PlatformInitPei/PlatformInit.h > create mode 100644 > Platform/Qemu/QemuOpenBoardPkg/Library/BoardBootManagerLib/BoardBootManager.c > create mode 100644 > Platform/Qemu/QemuOpenBoardPkg/Library/BoardInitLib/BoardInitLib.c > create mode 100644 > Platform/Qemu/QemuOpenBoardPkg/Library/PeiReportFvLib/PeiReportFvLib.c > create mode 100644 > Platform/Qemu/QemuOpenBoardPkg/Library/PlatformSecLib/PlatformSecLib.c > create mode 100644 > Platform/Qemu/QemuOpenBoardPkg/Library/QemuOpenFwCfgLib/QemuOpenFwCfgLib.c > create mode 100644 Platform/Qemu/QemuOpenBoardPkg/PlatformInitPei/Cpu.c > create mode 100644 Platform/Qemu/QemuOpenBoardPkg/PlatformInitPei/Memory.c > create mode 100644 Platform/Qemu/QemuOpenBoardPkg/PlatformInitPei/Pci.c > create mode 100644 Platform/Qemu/QemuOpenBoardPkg/PlatformInitPei/Pcie.c > create mode 100644 > Platform/Qemu/QemuOpenBoardPkg/PlatformInitPei/PlatformInit.c > create mode 100644 > Platform/Qemu/QemuOpenBoardPkg/Include/Fdf/FlashMap.fdf.inc > create mode 100644 > Platform/Qemu/QemuOpenBoardPkg/Library/PlatformSecLib/Ia32/SecEntry.nasm > create mode 100644 Platform/Qemu/QemuOpenBoardPkg/README.md > > -- > 2.37.0 (Apple Git-136) > > -- Pedro Falcato --00000000000018168605e8960d64 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Series-Reviewed-by: Pedro Falcato <pedro.falcato@gmail.com>

On Tue, Sep 13, 2022 at 10:32 PM Theo Jehl <theojehl76@gmail.com> wrote:
QemuOpenBoardPkg adds a = MinPlatform port to Qemu x86_64
It can boots UEFI Linux and Windows, and works on PIIX4 and Q35
This board port provides a simple starting place for investigating edk2 and=
MinPlatform Arch.
Currently we implement up to stage 4 of the MinPlatform spec and can boot Windows/Linux.

V2 splits the package into several commits.
Each commit corresponding to a MinPlatform architecture stage.

The V3 removes specials characters in "Theo" from file headers. Cleaned up whitespace, punctuation, commenting to better match coding style= and conventions
Fixed Visual Studio build issue converting UINT64 to UINT32.
Fixed build issues related to sync with latest master.

Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Isaac Oram <isaac.w.oram@intel.com>
Cc: Pedro Falcato <pedro.falcato@gmail.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Stefan Hajnoczi <stefanha@gmail.com>

Signed-off-by: Theo Jehl <theojehl76@gmail.com>

Theo Jehl (4):
=C2=A0 QemuOpenBoardPkg: Add QemuOpenBoardPkg
=C2=A0 QemuOpenBoardPkg: Enable stage 2
=C2=A0 QemuOpenBoardPkg: Enable stage 3
=C2=A0 QemuOpenBoardPkg: Enable stage 4

=C2=A0.../QemuOpenBoardPkg/QemuOpenBoardPkg.dec=C2=A0 =C2=A0 =C2=A0|=C2=A0 = 33 ++
=C2=A0.../Include/Dsc/Stage1.dsc.inc=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 |=C2=A0 55 +++
=C2=A0.../Include/Dsc/Stage2.dsc.inc=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 |=C2=A0 31 ++
=C2=A0.../Include/Dsc/Stage3.dsc.inc=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 | 101 ++++++
=C2=A0.../Include/Dsc/Stage4.dsc.inc=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 |=C2=A0 56 +++
=C2=A0.../QemuOpenBoardPkg/QemuOpenBoardPkg.dsc=C2=A0 =C2=A0 =C2=A0| 169 ++= +++++++
=C2=A0.../QemuOpenBoardPkg/QemuOpenBoardPkg.fdf=C2=A0 =C2=A0 =C2=A0| 328 ++= ++++++++++++++++
=C2=A0.../BoardBootManagerLib.inf=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 39 +++
=C2=A0.../Library/BoardInitLib/BoardInitLib.inf=C2=A0 =C2=A0 =C2=A0|=C2=A0 = 29 ++
=C2=A0.../Library/PeiReportFvLib/PeiReportFvLib.inf |=C2=A0 63 ++++
=C2=A0.../Library/PlatformSecLib/PlatformSecLib.inf |=C2=A0 49 +++
=C2=A0.../QemuOpenFwCfgLib/QemuOpenFwCfgLib.inf=C2=A0 =C2=A0 =C2=A0|=C2=A0 = 23 ++
=C2=A0.../PlatformInitPei/PlatformInitPei.inf=C2=A0 =C2=A0 =C2=A0 =C2=A0|= =C2=A0 59 ++++
=C2=A0.../Include/Library/QemuOpenFwCfgLib.h=C2=A0 =C2=A0 =C2=A0 =C2=A0 | 1= 05 ++++++
=C2=A0.../PlatformInitPei/PlatformInit.h=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 |=C2=A0 59 ++++
=C2=A0.../BoardBootManagerLib/BoardBootManager.c=C2=A0 =C2=A0 | 105 ++++++<= br> =C2=A0.../Library/BoardInitLib/BoardInitLib.c=C2=A0 =C2=A0 =C2=A0 =C2=A0| 2= 31 ++++++++++++
=C2=A0.../Library/PeiReportFvLib/PeiReportFvLib.c=C2=A0 =C2=A0| 285 +++++++= ++++++++
=C2=A0.../Library/PlatformSecLib/PlatformSecLib.c=C2=A0 =C2=A0| 140 +++++++= +
=C2=A0.../QemuOpenFwCfgLib/QemuOpenFwCfgLib.c=C2=A0 =C2=A0 =C2=A0 =C2=A0| 1= 36 ++++++++
=C2=A0.../QemuOpenBoardPkg/PlatformInitPei/Cpu.c=C2=A0 =C2=A0 |=C2=A0 64 ++= ++
=C2=A0.../QemuOpenBoardPkg/PlatformInitPei/Memory.c | 254 ++++++++++++++ =C2=A0.../QemuOpenBoardPkg/PlatformInitPei/Pci.c=C2=A0 =C2=A0 |=C2=A0 70 ++= ++
=C2=A0.../QemuOpenBoardPkg/PlatformInitPei/Pcie.c=C2=A0 =C2=A0| 106 ++++++<= br> =C2=A0.../PlatformInitPei/PlatformInit.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 |=C2=A0 75 ++++
=C2=A0.../Include/Fdf/FlashMap.fdf.inc=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 |=C2=A0 94 +++++
=C2=A0.../Library/PlatformSecLib/Ia32/SecEntry.nasm | 117 +++++++
=C2=A0Platform/Qemu/QemuOpenBoardPkg/README.md=C2=A0 =C2=A0 =C2=A0 |=C2=A0 = 53 +++
=C2=A028 files changed, 2929 insertions(+)
=C2=A0create mode 100644 Platform/Qemu/QemuOpenBoardPkg/QemuOpenBoardPkg.de= c
=C2=A0create mode 100644 Platform/Qemu/QemuOpenBoardPkg/Include/Dsc/Stage1.= dsc.inc
=C2=A0create mode 100644 Platform/Qemu/QemuOpenBoardPkg/Include/Dsc/Stage2.= dsc.inc
=C2=A0create mode 100644 Platform/Qemu/QemuOpenBoardPkg/Include/Dsc/Stage3.= dsc.inc
=C2=A0create mode 100644 Platform/Qemu/QemuOpenBoardPkg/Include/Dsc/Stage4.= dsc.inc
=C2=A0create mode 100644 Platform/Qemu/QemuOpenBoardPkg/QemuOpenBoardPkg.ds= c
=C2=A0create mode 100644 Platform/Qemu/QemuOpenBoardPkg/QemuOpenBoardPkg.fd= f
=C2=A0create mode 100644 Platform/Qemu/QemuOpenBoardPkg/Library/BoardBootMa= nagerLib/BoardBootManagerLib.inf
=C2=A0create mode 100644 Platform/Qemu/QemuOpenBoardPkg/Library/BoardInitLi= b/BoardInitLib.inf
=C2=A0create mode 100644 Platform/Qemu/QemuOpenBoardPkg/Library/PeiReportFv= Lib/PeiReportFvLib.inf
=C2=A0create mode 100644 Platform/Qemu/QemuOpenBoardPkg/Library/PlatformSec= Lib/PlatformSecLib.inf
=C2=A0create mode 100644 Platform/Qemu/QemuOpenBoardPkg/Library/QemuOpenFwC= fgLib/QemuOpenFwCfgLib.inf
=C2=A0create mode 100644 Platform/Qemu/QemuOpenBoardPkg/PlatformInitPei/Pla= tformInitPei.inf
=C2=A0create mode 100644 Platform/Qemu/QemuOpenBoardPkg/Include/Library/Qem= uOpenFwCfgLib.h
=C2=A0create mode 100644 Platform/Qemu/QemuOpenBoardPkg/PlatformInitPei/Pla= tformInit.h
=C2=A0create mode 100644 Platform/Qemu/QemuOpenBoardPkg/Library/BoardBootMa= nagerLib/BoardBootManager.c
=C2=A0create mode 100644 Platform/Qemu/QemuOpenBoardPkg/Library/BoardInitLi= b/BoardInitLib.c
=C2=A0create mode 100644 Platform/Qemu/QemuOpenBoardPkg/Library/PeiReportFv= Lib/PeiReportFvLib.c
=C2=A0create mode 100644 Platform/Qemu/QemuOpenBoardPkg/Library/PlatformSec= Lib/PlatformSecLib.c
=C2=A0create mode 100644 Platform/Qemu/QemuOpenBoardPkg/Library/QemuOpenFwC= fgLib/QemuOpenFwCfgLib.c
=C2=A0create mode 100644 Platform/Qemu/QemuOpenBoardPkg/PlatformInitPei/Cpu= .c
=C2=A0create mode 100644 Platform/Qemu/QemuOpenBoardPkg/PlatformInitPei/Mem= ory.c
=C2=A0create mode 100644 Platform/Qemu/QemuOpenBoardPkg/PlatformInitPei/Pci= .c
=C2=A0create mode 100644 Platform/Qemu/QemuOpenBoardPkg/PlatformInitPei/Pci= e.c
=C2=A0create mode 100644 Platform/Qemu/QemuOpenBoardPkg/PlatformInitPei/Pla= tformInit.c
=C2=A0create mode 100644 Platform/Qemu/QemuOpenBoardPkg/Include/Fdf/FlashMa= p.fdf.inc
=C2=A0create mode 100644 Platform/Qemu/QemuOpenBoardPkg/Library/PlatformSec= Lib/Ia32/SecEntry.nasm
=C2=A0create mode 100644 Platform/Qemu/QemuOpenBoardPkg/README.md

--
2.37.0 (Apple Git-136)



--
Pedro Falcato
--00000000000018168605e8960d64--