From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by mx.groups.io with SMTP id smtpd.web11.5260.1675109879223816321 for ; Mon, 30 Jan 2023 12:17:59 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=gZ6nU6rD; spf=pass (domain: gmail.com, ip: 209.85.214.171, mailfrom: pedro.falcato@gmail.com) Received: by mail-pl1-f171.google.com with SMTP id b5so5623972plz.5 for ; Mon, 30 Jan 2023 12:17:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=5E8y8jtITfbKF6x9yGuUFIbVTUgKvCmCsqUPuUArrjU=; b=gZ6nU6rDrfSe+uWfKH53m0fxXHhZjPhdGvnJRE4Qy+SzERVBqqokmWLEbI5IUtcslB wn4mrniBKVUPNhg42NVbTsBm9zVDlgftsoY59Evet3ZHqCQiR/1/9Cq4u6nbR22Zhrz0 GFpzQwjUAQOcC/fEmg8m74bRDaj0jqDYreP2kVPT2MUMSQ6C9K4vN611VIJS2ArwIWou S1AQDrAALZOvdQnd1ml8U1PTpehWAmqI8xfQR1weAv5kHwyZTv5jwhis90rqgs5ggsb6 jbDw/e+sIUZv38EJjGxVIfT7yXZJqExUpC4qsDwUEF62nC2wNYbNUHyiex4VhmNjqV9D E5hA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5E8y8jtITfbKF6x9yGuUFIbVTUgKvCmCsqUPuUArrjU=; b=t5QdixYssB2NWg9QvKMTDR8NRi90Aip7alkgFjm05HYlCVzPIuEq+zzejHtWPuFgov ptElbxWxZJXgGhnHn17VB07gdCdGxLAoMdr/Nvba+6X/UR2JDVZ6SRnrU390p3ygclFO LAXQzX81ZTQdM/tcQleyy2p9Vb2HlodftJRADO0o/EFYoJk5IegSRhpjOtFSluwvpQjD IO4Mbc9LIn23k/PvJ/3oWmeqzuIF+VSTWlb4AexWYUVahax0Qr+WrQabDx1UuTV+WnlQ yqYeSO9xwTyF0IXl+QPzFVNaj5/y5VC+go9Lb1WN7qpTMGXFqQ94YjOH2h3Qxgb/dRzL ZXEQ== X-Gm-Message-State: AFqh2krht2JERUPzJeQo9EsOYhmOP1ymIRVNl8WqsiNfkiopaCae7V2k S9WWJ7bpHtmtbiVymT6nopRRxTBqaLtN9T4UI5M= X-Google-Smtp-Source: AMrXdXtNjGcJY2vWS0nCgf7VKngWeUWLqVmtmAZCwxWEqv5T0BcujE4cv07w8oYPf2zdNBKHzoPJWPAg2wveqpLx5NQ= X-Received: by 2002:a17:90a:1a03:b0:228:7eed:e756 with SMTP id 3-20020a17090a1a0300b002287eede756mr8407363pjk.166.1675109878630; Mon, 30 Jan 2023 12:17:58 -0800 (PST) MIME-Version: 1.0 References: <20230130175850.27638-1-pedro.falcato@gmail.com> <1A2D4B07-7AD6-47B9-86FE-6B1C2C6BF4C6@posteo.de> In-Reply-To: <1A2D4B07-7AD6-47B9-86FE-6B1C2C6BF4C6@posteo.de> From: "Pedro Falcato" Date: Mon, 30 Jan 2023 20:17:47 +0000 Message-ID: Subject: Re: [PATCH 1/1] Ext4Pkg: Redirect internal Open("..", /) to the proper "/" To: =?UTF-8?Q?Marvin_H=C3=A4user?= Cc: edk2-devel-groups-io , Savva Mitrofanov Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Jan 30, 2023 at 7:54 PM Marvin H=C3=A4user wro= te: > > Reviewed-by: Marvin H=C3=A4user > > On 30. Jan 2023, at 18:58, Pedro Falcato wrote: > > We have been hitting many issues with ".." ASSERTing on / in internal > code, so make sure that we direct /.. to /. This is safe. > > Signed-off-by: Pedro Falcato > Cc: Marvin H=C3=A4user > Reported-by: Savva Mitrofanov > --- > Features/Ext4Pkg/Ext4Dxe/Directory.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/Features/Ext4Pkg/Ext4Dxe/Directory.c b/Features/Ext4Pkg/Ext4= Dxe/Directory.c > index 456916453952..73d21d9f9542 100644 > --- a/Features/Ext4Pkg/Ext4Dxe/Directory.c > +++ b/Features/Ext4Pkg/Ext4Dxe/Directory.c > @@ -255,7 +255,11 @@ Ext4OpenDirent ( > // Using the parent's parent's dentry > File->Dentry =3D Directory->Dentry->Parent; > > - ASSERT (File->Dentry !=3D NULL); > + if (!File->Dentry) { > + // Someone tried .. on root, so direct them to / > + // This is an illegal EFI Open() but is possible to hit from a var= iety of internal code > + File->Dentry =3D Directory->Dentry; > + } > > Ext4RefDentry (File->Dentry); > } else { > -- > 2.39.0 > > Pushed as 878c4b13f Thank you --=20 Pedro