Re: [edk2-devel] [PATCH v8 14/37] UefiCpuPkg: Add CpuMmuLib to UefiCpuPkg

["Pedro Falcato" <pedro.falcato@gmail.com>]

On Thu, Feb 1, 2024 at 3:05 AM Chao Li <lichao@loongson.cn> wrote:
>
> Hi Pedro and Laszlo,
>
> Part of the code in this patch is indeed quoted from the Linux kernel, and do you think it is inapproparate? If so, we need to refactor this module, what are you suggests with the refactoring? Just remove the unused logic from the Kernel code and keep the logic good or refactor from scratch?

+CC stewards

Disclaimer: I'm not a lawyer

It is wildly inappropriate. All of the code was clearly inspired by
GPL and derives from the Linux GPL code, it's not just unused logic.
You should triple check *every other patch* you've sent out for these
kinds of GPL violations.

There's another way of writing this sort of code (that doesn't involve
all the Linux mm craziness) but I don't know if changing strategies
would be considered getting rid of any shadow of GPL/IP violation.

(As a side note, I don't really understand IP in the software world.
If you work, say, on GPL software for a moment in time, are you always
going to be "GPL-tainted"? Surely not? Most people in the industry
I've talked to about this say that, yeah, no, corps don't expect that.
But no one really seems to have drawn a line between OK and not-OK,
but rather "please please don't sue us". And in this case I don't know
(but I suspect it'd be uncomfortable) for someone to redesign a
solution right away, after being "tainted". Anyway, tough problem, and
IANAL :/)

-- 
Pedro


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#114956): https://edk2.groups.io/g/devel/message/114956
Mute This Topic: https://groups.io/mt/103971653/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-