From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id A547A740032 for ; Thu, 1 Feb 2024 19:36:53 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=8gCB2RDqdFLVXnVXNbhcCfYDNiPR0GYWBJWs2060VnU=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20140610; t=1706816212; v=1; b=mQb/hYtj2SJEtcSSFVFNECIafnBBlJqI72YJlgDhDsKI0Ty8s1RrHy+VWVAyDnT3v4XVqpiI 5Tye/2c9VKhJt9olECIf9//kvMGVQ32ScSQQjxZmm+hHXGS/k53idgXfepxr69qjp3lMTGeHfZX 1/rBljKoQuldKFAV5m3dX5Eo= X-Received: by 127.0.0.2 with SMTP id XXSmYY7687511xAqkZnXund0; Thu, 01 Feb 2024 11:36:52 -0800 X-Received: from mail-ua1-f42.google.com (mail-ua1-f42.google.com [209.85.222.42]) by mx.groups.io with SMTP id smtpd.web10.4970.1706816211667389800 for ; Thu, 01 Feb 2024 11:36:51 -0800 X-Received: by mail-ua1-f42.google.com with SMTP id a1e0cc1a2514c-7d5c40f874aso533106241.1 for ; Thu, 01 Feb 2024 11:36:51 -0800 (PST) X-Gm-Message-State: QRwnUQqYljKQ7r5Ruc4mKTa2x7686176AA= X-Google-Smtp-Source: AGHT+IFnExEtH2RaIVGJnwNDdEXpYggWHp5I/AOGG8pWBw44wnQBeG7WDj8lByUrVdLU+Gpy02jYsXW2cNZhn4qROko= X-Received: by 2002:ac5:c8a2:0:b0:4b7:386:e209 with SMTP id o2-20020ac5c8a2000000b004b70386e209mr5273754vkl.14.1706816210058; Thu, 01 Feb 2024 11:36:50 -0800 (PST) MIME-Version: 1.0 References: <20240126062715.3099433-1-lichao@loongson.cn> <20240126062919.3101691-1-lichao@loongson.cn> <3fe0fda8-d32e-679e-2f71-6cc35e7772b8@redhat.com> In-Reply-To: From: "Pedro Falcato" Date: Thu, 1 Feb 2024 19:36:38 +0000 Message-ID: Subject: Re: [edk2-devel] [PATCH v8 14/37] UefiCpuPkg: Add CpuMmuLib to UefiCpuPkg To: Chao Li Cc: devel@edk2.groups.io, Laszlo Ersek , Eric Dong , Ray Ni , Rahul Kumar , Gerd Hoffmann , Baoqi Zhang , Dongyan Qian , Xianglai Li , Bibo Mao , Andrew Fish , Leif Lindholm , "Kinney, Michael D" Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pedro.falcato@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="mQb/hYtj"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Thu, Feb 1, 2024 at 3:05=E2=80=AFAM Chao Li wrote: > > Hi Pedro and Laszlo, > > Part of the code in this patch is indeed quoted from the Linux kernel, an= d do you think it is inapproparate? If so, we need to refactor this module,= what are you suggests with the refactoring? Just remove the unused logic f= rom the Kernel code and keep the logic good or refactor from scratch? +CC stewards Disclaimer: I'm not a lawyer It is wildly inappropriate. All of the code was clearly inspired by GPL and derives from the Linux GPL code, it's not just unused logic. You should triple check *every other patch* you've sent out for these kinds of GPL violations. There's another way of writing this sort of code (that doesn't involve all the Linux mm craziness) but I don't know if changing strategies would be considered getting rid of any shadow of GPL/IP violation. (As a side note, I don't really understand IP in the software world. If you work, say, on GPL software for a moment in time, are you always going to be "GPL-tainted"? Surely not? Most people in the industry I've talked to about this say that, yeah, no, corps don't expect that. But no one really seems to have drawn a line between OK and not-OK, but rather "please please don't sue us". And in this case I don't know (but I suspect it'd be uncomfortable) for someone to redesign a solution right away, after being "tainted". Anyway, tough problem, and IANAL :/) --=20 Pedro -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114956): https://edk2.groups.io/g/devel/message/114956 Mute This Topic: https://groups.io/mt/103971653/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-