Re: [edk2-devel] [PATCH v1 1/1] ReadMe.rst: Add Apache License 2.0 and update submodule list

["Pedro Falcato" <pedro.falcato@gmail.com>]

On Tue, Oct 31, 2023 at 9:25 PM <mikuback@linux.microsoft.com> wrote:
>
> From: Michael Kubacki <michael.kubacki@microsoft.com>
>
> - Adds Apache License 2.0 as an acceptable source license per
>   discussion in https://edk2.groups.io/g/devel/message/110226
> - Updates the URL for existing licenses to match the current path
>   used by opensource.org.
> - The submodule list in this file is stale and is very prone to
>   being forgotten. The list of submodules in the submodules setion
>   is replaced with a link to .gitmodules which has an active list
>   of submodules at any given time.
>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Pedro Falcato <pedro.falcato@gmail.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> ---
>  ReadMe.rst | 18 +++++++-----------
>  1 file changed, 7 insertions(+), 11 deletions(-)
>
> diff --git a/ReadMe.rst b/ReadMe.rst
> index ed1d4822459b..6b3eddc33af5 100644
> --- a/ReadMe.rst
> +++ b/ReadMe.rst
> @@ -134,11 +134,12 @@ To make a contribution to a TianoCore project, follow these steps.
>      copyright license as the base project. When that is not possible,
>      then contributions using the following licenses can be accepted:
>
> --  BSD (2-clause): http://opensource.org/licenses/BSD-2-Clause
> --  BSD (3-clause): http://opensource.org/licenses/BSD-3-Clause
> --  MIT: http://opensource.org/licenses/MIT
> --  Python-2.0: http://opensource.org/licenses/Python-2.0
> --  Zlib: http://opensource.org/licenses/Zlib
> +-  Apache License, Version 2.0: https://opensource.org/license/apache-2-0/
> +-  BSD (2-clause): http://opensource.org/license/BSD-2-Clause
> +-  BSD (3-clause): http://opensource.org/license/BSD-3-Clause
> +-  MIT: http://opensource.org/license/MIT
> +-  Python-2.0: http://opensource.org/license/Python-2.0
> +-  Zlib: http://opensource.org/license/Zlib

nit: https for all licenses

>
>  For documentation:
>
> @@ -245,12 +246,7 @@ Submodules
>
>  Submodule in EDK II is allowed but submodule chain should be avoided
>  as possible as we can. Currently EDK II contains the following submodules

Not really a part of the patch, but the above sentence is grammatically borked

> -
> --  CryptoPkg/Library/OpensslLib/openssl
> --  ArmPkg/Library/ArmSoftFloatLib/berkeley-softfloat-3
> --  MdeModulePkg/Universal/RegularExpressionDxe/oniguruma
> --  MdeModulePkg/Library/BrotliCustomDecompressLib/brotli
> --  BaseTools/Source/C/BrotliCompress/brotli
> +`.gitmodules <.gitmodules>`__.

I think it makes sense to nuke this entire subsection? and just keep
the submodule update instructions...

in any case
Acked-by: Pedro Falcato <pedro.falcato@gmail.com>

-- 
Pedro


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#110558): https://edk2.groups.io/g/devel/message/110558
Mute This Topic: https://groups.io/mt/102307253/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-