From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id BC8A294195D for ; Mon, 25 Sep 2023 18:03:41 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=N0HW+UxJEYtKZO675XxOKqn8zyXGa/xEurua+VS6W5s=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20140610; t=1695665020; v=1; b=RTkxYZ8D6U6NjT6s0IRrcvwd5RV1yyOFrD89NYdEYzwUx9qQEysrY+DhgN5wTjk2mzTzdG+4 J+BcEbB9gQsMmK/ibzEhamqgGdRVNM/fFOxVj4APhl0a+JGqDMj1YmMjqbv34jdfbrFoGtiHY39 WHlD1IeS9P4FDmE0lhWtGYW4= X-Received: by 127.0.0.2 with SMTP id o3tWYY7687511xuX4dupd49f; Mon, 25 Sep 2023 11:03:40 -0700 X-Received: from mail-vs1-f42.google.com (mail-vs1-f42.google.com [209.85.217.42]) by mx.groups.io with SMTP id smtpd.web11.68340.1695665019725161892 for ; Mon, 25 Sep 2023 11:03:39 -0700 X-Received: by mail-vs1-f42.google.com with SMTP id ada2fe7eead31-45271a44cc4so2655322137.2 for ; Mon, 25 Sep 2023 11:03:39 -0700 (PDT) X-Gm-Message-State: LOWvOH37mUotOLVHVJ2RNZhex7686176AA= X-Google-Smtp-Source: AGHT+IEIFaJ0SOQ9E4yncoaRqAbkBhnDi2lkNR7xYrorOhfNlfwxv0qbSkvEjOE4MUtguc2aCx0R3ZcT6zUkMiD1e2M= X-Received: by 2002:a05:6102:51b:b0:452:70f7:ca4a with SMTP id l27-20020a056102051b00b0045270f7ca4amr3549952vsa.34.1695665018500; Mon, 25 Sep 2023 11:03:38 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: "Pedro Falcato" Date: Mon, 25 Sep 2023 19:03:27 +0100 Message-ID: Subject: Re: [edk2-devel] Maybe it is time to update code style? To: devel@edk2.groups.io, marcin.juszkiewicz@linaro.org Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pedro.falcato@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=RTkxYZ8D; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Mon, Sep 25, 2023 at 10:03=E2=80=AFAM Marcin Juszkiewicz wrote: > > I feel sick each time I have to edit EDK2 code. > > All those INF, DEC, DSC, FDF, XYZ files are something I do not even try > to understand, just got minimal knowledge what goes where by asking Leif > (thanks a lot!) and observing build error messages. I feel you. We've discussed this before (in the ML and on the UEFI talkbox discord) and there's a large unwillingness to change the build system, because it's "super extensible" and all that. I don't like it, but it is what it is. > > I got used to UINTN and other weird variable types. No idea where from > they came from (MS Windows?) Yes. > > But what sucks more is those 2 spaces used for indenting code. Took me > a while to reming myself when I used such. It was in 90s, when I was > Amiga programmer and all I had was 720x480px screen. > > Last time I looked at calendar it was 2023 year. Maybe it is time to move > to 4 spaces? > > And can someone take a look at config of code obfuscator used for linting= ? > It spits out amount of information showing that noone looked at updating = it > to current version: You're supposed to use the edk2 uncrustify fork that you get *somehow* (no, I don't remember how, I do remember it was a pain though). But seriously, speaking as someone with a completely different personal coding style, the coding style really isn't all that bad (at the very least, it's tolerable), it's just a bastardized NT-kernel style, and with uncrustify you can auto-format all your code. What really pains me is CRLF vs LF, which breaks *every git tool*. Seriously, applying patches tends to be a pain, at least on Linux. --=20 Pedro -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109048): https://edk2.groups.io/g/devel/message/109048 Mute This Topic: https://groups.io/mt/101570674/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-