From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f175.google.com (mail-pg1-f175.google.com [209.85.215.175]) by mx.groups.io with SMTP id smtpd.web10.43356.1683409717801937920 for ; Sat, 06 May 2023 14:48:37 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20221208 header.b=aWSsszUx; spf=pass (domain: gmail.com, ip: 209.85.215.175, mailfrom: pedro.falcato@gmail.com) Received: by mail-pg1-f175.google.com with SMTP id 41be03b00d2f7-52c6f8ba7e3so2908604a12.3 for ; Sat, 06 May 2023 14:48:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683409717; x=1686001717; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=MCflTWmrI85fcAHzhceboqsE0KzIwrjhRHF4h7BQg5M=; b=aWSsszUxfNzp91KvKAqoIr7uzrdS3Sa1i3467nVX2/d/HJ/UXgArm/BTGfdesY6OI1 4NBI6td5H8+G4lbuA1IbjZIAA8ACnRa/MqOY3qDDbbmJrxE4fGefiRSN/8oUiB/weD5R PMz5eOizFmnZ9/PJLdNAbGgxEP7fhNMi4CbUIAptVmgYDpgGVU8wYG7NAY/6PZKY/ian mwmk//pko4tZVaVRK5qf6P1YHTFqkyfuvTwdqT9M7DbC+E6y4IuHo1zD4xta99tBPC2i HsAUFiS1H60f+IPUD9yPEosc2NKLqOo8Z1d/rP1s2xJVGkJaOmJn2s72rU4lfm40tL+u EDbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683409717; x=1686001717; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MCflTWmrI85fcAHzhceboqsE0KzIwrjhRHF4h7BQg5M=; b=kgbSowMoQiJgv+Eqk2aSdKiy8pbuQZ4DahAq07/pMr1zfxZm1GXsYkRJ9vR+PSh+ZQ YYwHEJiZ01zmkYhUqf7tUjCy3NJolia3izdy8CvBOrOeGcihBPPiwng5RDBiybNRu4cm WyQgXF6x7ILh10GkMtgSVLueHlzjeIGmuusPFi06gq6USjzNMNe+1TkJEK51TroNc09/ 3BkJn4yaWhiluCyR8VXJkbGCyGPP6cC2eIBv4V//3xav6vF6EPsrGPx2GosV4RZLPJF9 zgGEzKG6eVEocb3bwOJqKXJc996rCMhsgTIR+IgduRX2hmeaI4A9n6RjhDGWPxO2tGQl 3hZg== X-Gm-Message-State: AC+VfDztNOsnAJtaPJuuTl21rmY7CZhauyiSC2FgyhQYEvKpY98o+yFI It5kfrCsTqbc30bHrVtIMfomx5NeWRoKrcMVFUu76zAGX0EGog== X-Google-Smtp-Source: ACHHUZ6jS9doyU9iMXsqW/P1THYuYZJ9JmE5RXC/H5Hzd5MIc6n+lW7IKY3F2WVTy9WFuHwf6UPcIXzMnEpH9PK0AQ4= X-Received: by 2002:a17:903:245:b0:1aa:fbaa:ee10 with SMTP id j5-20020a170903024500b001aafbaaee10mr7988084plh.37.1683409716944; Sat, 06 May 2023 14:48:36 -0700 (PDT) MIME-Version: 1.0 References: <20230506182311.14023-1-rebecca@bsdio.com> <175CA4E73380D66F.2502@groups.io> <3e01cc9e-ac5f-bf4d-0359-adfc1aa21c4b@bsdio.com> In-Reply-To: <3e01cc9e-ac5f-bf4d-0359-adfc1aa21c4b@bsdio.com> From: "Pedro Falcato" Date: Sat, 6 May 2023 22:48:25 +0100 Message-ID: Subject: Re: [edk2-devel] [PATCH 1/1] Remove bashisms from edksetup.sh and BaseTools/BuildEnv To: devel@edk2.groups.io, rebecca@bsdio.com Cc: Liming Gao , Bob Feng , Yuwei Chen , Andrew Fish , Leif Lindholm , Michael D Kinney Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, May 6, 2023 at 8:45=E2=80=AFPM Rebecca Cran wro= te: > > Actually, the python package provides a python command, and python3 > provides a python3 command, both of which are Python 3.9.16. > > So I no longer need to specify PYTHON_COMMAND. > > > bcran@maxamd:~/src/uefi/edk2 % /bin/sh > > $ . edksetup.sh > > Loading previous configuration from > /home/bcran/src/uefi/edk2/Conf/BuildEnv.sh > Using EDK2 in-source Basetools > WORKSPACE: /home/bcran/src/uefi/edk2 > EDK_TOOLS_PATH: /home/bcran/src/uefi/edk2/BaseTools > CONF_PATH: /home/bcran/src/uefi/edk2/Conf > $ echo $PYTHON_COMMAND > python3 > $ python3 --version > Python 3.9.16 My local installations of Net (latest stable) and FreeBSD (13.1 with a hacked-up kernel) do not have a python3 symlink. I'm slightly worried that this breaks something. I know requiring whereis isn't ideal, but I'm fairly sure it did handle this situation? --=20 Pedro