From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 96E66AC1A55 for ; Fri, 16 Feb 2024 20:06:38 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=D6SWh7rpxavk1CyV5ETXvIcCfFBQBj7uRqhHMTZ2t8E=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20140610; t=1708113997; v=1; b=Pdt8E163et3qqyK5ZdsXDOrj+3VtQhrvIFQvI4NSsqfiEhNFyboxgCFWd6VsgVJGK1XY4XWM xTg1JwaC/IKIeEsP5Vhle10aEK54P09wnr47mPLh4tWHwWiPteVegbeZc1Nrg16kDi6E5zmV7Q1 tTfxI6npJArqq8Zb2w1lQpo0= X-Received: by 127.0.0.2 with SMTP id bdbwYY7687511xMbN6SnTlWj; Fri, 16 Feb 2024 12:06:37 -0800 X-Received: from mail-ot1-f41.google.com (mail-ot1-f41.google.com [209.85.210.41]) by mx.groups.io with SMTP id smtpd.web10.8054.1708113996592469912 for ; Fri, 16 Feb 2024 12:06:36 -0800 X-Received: by mail-ot1-f41.google.com with SMTP id 46e09a7af769-6e2d83d2568so1574394a34.3 for ; Fri, 16 Feb 2024 12:06:36 -0800 (PST) X-Gm-Message-State: IVZamJRuQeXT6D4kExus46ttx7686176AA= X-Google-Smtp-Source: AGHT+IGc95ikUxltxjziNl21yq8zaKSpjRg8YtuXNqGKIfK4YZ7Q5htnkeP3AW+toAVl7u596KB+3FvQjOnU56e66m8= X-Received: by 2002:a05:6808:2915:b0:3c1:364d:2812 with SMTP id ev21-20020a056808291500b003c1364d2812mr6143160oib.21.1708113995633; Fri, 16 Feb 2024 12:06:35 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: "Pedro Falcato" Date: Fri, 16 Feb 2024 20:06:24 +0000 Message-ID: Subject: Re: [edk2-devel] Using ekd2-libc with C++20 To: devel@edk2.groups.io, pawel.karczewski@solidigm.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pedro.falcato@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=Pdt8E163; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Fri, Feb 16, 2024 at 2:46=E2=80=AFPM pawel.karczewski via groups.io wrote: > > Hi, > > I'm successfully building C++20 project with edk2 under the GCC compiler. > Currently I'm trying to add edk2-libc to this project, but encountered is= sue with header. > > ``` > edk2/StdLib/Include/string.h:487:19: error: ISO C++17 does not allow =E2= =80=98register=E2=80=99 storage class specifier [-Werror=3Dregister] regist= er char **stringp > ``` > > Why `strsep(register char **stringp, register const char *delim)` paramet= ers has register storage class-class specifier? > C standard states the `register` keyword is only hint for the compiler an= d the extent to which such > suggestions are effective is implementation-defined. Do you see any real = performance improvements thanks to this? Considering the file is Copyright(C) University of California (and the SCCS tags suggest 1993, which places it around 4.4BSD), this very much looks like a historical artifact (of old UNIX and bad compilers). I certainly doubt any compiler capable of building EDK2 changes its codegen because of it (and certainly not the calling convention, at least in all ABIs I know of). --=20 Pedro -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115553): https://edk2.groups.io/g/devel/message/115553 Mute This Topic: https://groups.io/mt/104393456/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-