public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Pedro Falcato" <pedro.falcato@gmail.com>
To: devel@edk2.groups.io, jbrasen@nvidia.com
Subject: Re: [edk2-devel] [PATCH] MdePkg/BaseFdtLib: Rename standard functions
Date: Mon, 11 Dec 2023 15:59:49 +0000	[thread overview]
Message-ID: <CAKbZUD2qmOhxC4w66_Yw1Y4=V6DaQg+s9om=jkZbvZAAL0ioDw@mail.gmail.com> (raw)
In-Reply-To: <2c864678a4ae43a9cec9825b7f408c140ba1f18e.1702309158.git.jbrasen@nvidia.com>

On Mon, Dec 11, 2023 at 3:40 PM Jeff Brasen via groups.io
<jbrasen=nvidia.com@groups.io> wrote:
>

Jeff,

You're missing CC's on this patch. Also, you should probably send the
3 patches in a single series, since they're all related.

> Rename the standard functions in the LibFdtSupport to remove conflicts
> with other libraries that define them.

This is a funny problem. What error were you seeing? As far as I can
tell, you can totally define your local C library functions, it
shouldn't result in any linker errors (even if, IIRC, deemed UB by the
C spec).

--
Pedro


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112314): https://edk2.groups.io/g/devel/message/112314
Mute This Topic: https://groups.io/mt/103110792/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



  reply	other threads:[~2023-12-11 16:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-11 15:39 [edk2-devel] [PATCH] MdePkg/BaseFdtLib: Rename standard functions Jeff Brasen via groups.io
2023-12-11 15:59 ` Pedro Falcato [this message]
2023-12-11 16:52   ` Jeff Brasen via groups.io
2024-01-23 17:20     ` Jeff Brasen via groups.io
2024-01-23 21:55 ` Michael D Kinney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKbZUD2qmOhxC4w66_Yw1Y4=V6DaQg+s9om=jkZbvZAAL0ioDw@mail.gmail.com' \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox