For the record, I suggested to Savva (off-list) to squash the patch set into one, for v2. On Tue, Jul 19, 2022 at 1:10 PM Savva Mitrofanov wrote: > Hi all, > > This patchset attempts to improve security of code sections by fixing > integer overflows, > missing aligment checks, unsafe casts. Also I simplified some routines, > fixed compiler warnings and > corrected some code mistakes. > > REF: > https://github.com/savvamitrofanov/edk2-platforms/commits/ext4pkg_security_improvements > > Cc: Marvin Häuser > Cc: Pedro Falcato > Cc: Vitaly Cheptsov > > Savva Mitrofanov (10): > Ext4Pkg: Replace SetMem(,,0) with ZeroMem > Ext4Pkg: Change HoleLen type to UINT64 > Ext4Pkg: Use 32-bit block number in BlockMap > Ext4Pkg: Use assertion in Ext4CalculateChecksum > Ext4Pkg: Fix compiler warnings > Ext4Pkg: Drop dir entry name_len limit extra check > Ext4Pkg: Simplify Ext4RemoveDentry logic > Ext4Pkg: Fix possible int overflow in Ext4ExtentsMapKeyCompare > Ext4Pkg: Return bad block type in Ext4GetBlockpath > Ext4Pkg: Group descriptor size must be 4-byte aligned > > Features/Ext4Pkg/Ext4Dxe/Ext4Disk.h | 3 +- > Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.h | 2 +- > Features/Ext4Pkg/Ext4Dxe/BlockMap.c | 18 ++++++++---- > Features/Ext4Pkg/Ext4Dxe/Directory.c | 29 ++------------------ > Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.c | 10 ++++--- > Features/Ext4Pkg/Ext4Dxe/Extents.c | 5 ++-- > Features/Ext4Pkg/Ext4Dxe/Inode.c | 8 +++--- > Features/Ext4Pkg/Ext4Dxe/Superblock.c | 12 ++++---- > 8 files changed, 37 insertions(+), 50 deletions(-) > > -- > 2.37.0 > > -- Pedro Falcato