From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vk1-f178.google.com (mail-vk1-f178.google.com [209.85.221.178]) by mx.groups.io with SMTP id smtpd.web11.42748.1658247575207454662 for ; Tue, 19 Jul 2022 09:19:35 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=Gut0ZEeU; spf=pass (domain: gmail.com, ip: 209.85.221.178, mailfrom: pedro.falcato@gmail.com) Received: by mail-vk1-f178.google.com with SMTP id m30so5746545vkl.4 for ; Tue, 19 Jul 2022 09:19:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=C4JkuLsXekeCWakgiruu61rwobEDzwP7oxIgnjpsKJo=; b=Gut0ZEeUaGwI+v+8sjo5JEwJuMGKaMbdWCcYmVvne0Tg/vVHODie6pDYz3z/AzMqGI BF+2UyDLWQWksNyYYGJo4QjoZGsPjP7Vut7st6zF9b6ka7XywaeFx90yE3Es9+h2QmOz N9/77YcnkZGWxTjaEYpXYJAi6av0QAL0p6dVDXseTXeSW3JJzlr2CzuEEai9aPPBju1Q NFszTgJQg1lABSx6TpvwVQ+M9u/Sr4PTB+ftuE/w4HWGBmJ5gqy1z4bcb5esRE011HvW ovI+PJQR8n1JeSf7Xe3bBDPXrSPfTBNY+HRrA2qddfmFP6rMACMDLyBShL7TQV7+Rw33 TOrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=C4JkuLsXekeCWakgiruu61rwobEDzwP7oxIgnjpsKJo=; b=a0e6Tx8zTHF7g7s03t0HuKx43nzvr1+l30TBuoSY5GJTO257kCaajSobvAUb6dtPj9 CIZC6f2O9VV61BEc42E90N2bkLPCniJyWCCifku95oumLeC1Tum2itRy1yY7sT3ahKeV xYuW4aqBGFlxrcAEmt3Ov79iUNV3AB3OxfBiCFWtXeSLRKklxBbkuB2DGcWQYFNeArQK UQWpsn6Kee8QCfylpepdRC2WP5BwG0X0bZ4KdcjVArsiojPShONuXieF6XFAqG8nbzhC Rq5fQUZWgMzSF6Kb2IlaUfIU+6aalYZkx1Gd04llWC+1GUYcVlcsPCgK4zSCEJkmdpyh lKYg== X-Gm-Message-State: AJIora86UqWp9a9RQ2JK7begTn1CNV2vZPsUMCeP/d9Hy0w6rVpnbrWK IxWW2KAr4usCbXGubsSZWzDJSpZTIGlRA/Jsqec= X-Google-Smtp-Source: AGRyM1sWuQgwJqgZ+IATBYpGLjAY2tcrnYKlwRUzHKoGlIlpwv3rAX/Fr5v7LgtlkD2RLgpPDQBRnXKOPqUqcFicWw8= X-Received: by 2002:a1f:2144:0:b0:374:a271:6313 with SMTP id h65-20020a1f2144000000b00374a2716313mr11869211vkh.23.1658247574195; Tue, 19 Jul 2022 09:19:34 -0700 (PDT) MIME-Version: 1.0 References: <20220719121016.29380-1-savvamtr@gmail.com> In-Reply-To: <20220719121016.29380-1-savvamtr@gmail.com> From: "Pedro Falcato" Date: Tue, 19 Jul 2022 17:19:22 +0100 Message-ID: Subject: Re: [edk2-platforms][PATCH 00/10] Ext4Pkg: Code security and correctness improvements To: Savva Mitrofanov Cc: edk2-devel-groups-io , =?UTF-8?Q?Marvin_H=C3=A4user?= , Vitaly Cheptsov Content-Type: multipart/alternative; boundary="0000000000009c13ba05e42ad93a" --0000000000009c13ba05e42ad93a Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable For the record, I suggested to Savva (off-list) to squash the patch set into one, for v2. On Tue, Jul 19, 2022 at 1:10 PM Savva Mitrofanov wrote= : > Hi all, > > This patchset attempts to improve security of code sections by fixing > integer overflows, > missing aligment checks, unsafe casts. Also I simplified some routines, > fixed compiler warnings and > corrected some code mistakes. > > REF: > https://github.com/savvamitrofanov/edk2-platforms/commits/ext4pkg_securit= y_improvements > > Cc: Marvin H=C3=A4user > Cc: Pedro Falcato > Cc: Vitaly Cheptsov > > Savva Mitrofanov (10): > Ext4Pkg: Replace SetMem(,,0) with ZeroMem > Ext4Pkg: Change HoleLen type to UINT64 > Ext4Pkg: Use 32-bit block number in BlockMap > Ext4Pkg: Use assertion in Ext4CalculateChecksum > Ext4Pkg: Fix compiler warnings > Ext4Pkg: Drop dir entry name_len limit extra check > Ext4Pkg: Simplify Ext4RemoveDentry logic > Ext4Pkg: Fix possible int overflow in Ext4ExtentsMapKeyCompare > Ext4Pkg: Return bad block type in Ext4GetBlockpath > Ext4Pkg: Group descriptor size must be 4-byte aligned > > Features/Ext4Pkg/Ext4Dxe/Ext4Disk.h | 3 +- > Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.h | 2 +- > Features/Ext4Pkg/Ext4Dxe/BlockMap.c | 18 ++++++++---- > Features/Ext4Pkg/Ext4Dxe/Directory.c | 29 ++------------------ > Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.c | 10 ++++--- > Features/Ext4Pkg/Ext4Dxe/Extents.c | 5 ++-- > Features/Ext4Pkg/Ext4Dxe/Inode.c | 8 +++--- > Features/Ext4Pkg/Ext4Dxe/Superblock.c | 12 ++++---- > 8 files changed, 37 insertions(+), 50 deletions(-) > > -- > 2.37.0 > > --=20 Pedro Falcato --0000000000009c13ba05e42ad93a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
For the record, I suggested to Savva (off-list) to squash = the patch set into one, for v2.

On Tue, Jul 19, 2022 at 1:10 PM Savva Mi= trofanov <savvamtr@gmail.com&g= t; wrote:
Hi all= ,

This patchset attempts to improve security of code sections by fixing integ= er overflows,
missing aligment checks, unsafe casts. Also I simplified some routines, fix= ed compiler warnings and
corrected some code mistakes.

REF: https://= github.com/savvamitrofanov/edk2-platforms/commits/ext4pkg_security_improvem= ents

Cc: Marvin H=C3=A4user <mhaeuser@posteo.de>
Cc: Pedro Falcato <pedro.falcato@gmail.com>
Cc: Vitaly Cheptsov <vit9696@protonmail.com>

Savva Mitrofanov (10):
=C2=A0 Ext4Pkg: Replace SetMem(,,0) with ZeroMem
=C2=A0 Ext4Pkg: Change HoleLen type to UINT64
=C2=A0 Ext4Pkg: Use 32-bit block number in BlockMap
=C2=A0 Ext4Pkg: Use assertion in Ext4CalculateChecksum
=C2=A0 Ext4Pkg: Fix compiler warnings
=C2=A0 Ext4Pkg: Drop dir entry name_len limit extra check
=C2=A0 Ext4Pkg: Simplify Ext4RemoveDentry logic
=C2=A0 Ext4Pkg: Fix possible int overflow in Ext4ExtentsMapKeyCompare
=C2=A0 Ext4Pkg: Return bad block type in Ext4GetBlockpath
=C2=A0 Ext4Pkg: Group descriptor size must be 4-byte aligned

=C2=A0Features/Ext4Pkg/Ext4Dxe/Ext4Disk.h=C2=A0 =C2=A0|=C2=A0 3 +-
=C2=A0Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.h=C2=A0 =C2=A0 |=C2=A0 2 +-
=C2=A0Features/Ext4Pkg/Ext4Dxe/BlockMap.c=C2=A0 =C2=A0| 18 ++++++++----
=C2=A0Features/Ext4Pkg/Ext4Dxe/Directory.c=C2=A0 | 29 ++------------------<= br> =C2=A0Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.c=C2=A0 =C2=A0 | 10 ++++---
=C2=A0Features/Ext4Pkg/Ext4Dxe/Extents.c=C2=A0 =C2=A0 |=C2=A0 5 ++--
=C2=A0Features/Ext4Pkg/Ext4Dxe/Inode.c=C2=A0 =C2=A0 =C2=A0 |=C2=A0 8 +++---=
=C2=A0Features/Ext4Pkg/Ext4Dxe/Superblock.c | 12 ++++----
=C2=A08 files changed, 37 insertions(+), 50 deletions(-)

--
2.37.0



--
Pedro Falcato
--0000000000009c13ba05e42ad93a--