Re: [edk2-devel] Commits Spanning Packages

["Pedro Falcato" <pedro.falcato@gmail.com>]

On Wed, Jan 31, 2024 at 6:58 PM Michael Kubacki
<mikuback@linux.microsoft.com> wrote:
>
> Some commits have been spanning packages. For a monolithic upstream repo
> like edk2, this makes ingesting commits downstream more tedious if
> project requirements do not necessitate all packages to be maintained.
>
> Below are examples of commits spanning packages. Many of these are more
> problematic because "core" packages like MdePkg, MdeModule, SecurityPkg,
> UefiCpuPkg, etc. are involved. OvmfPkg and ArmVirtPkg seem to be a
> common pairing. To focus the examples below, I excluded commits with
> that pair.
>
> The request is to limit crossing package boundaries as much as possible
> and for maintainers to assess package impact when merging changes.

Personally I'm all for making downstreams' lives easier, but I don't
see how one could pull off many of the changes you linked, in 2+
commits, without breaking bisection.

Pulling off 103fa647d159e3d76be2634d2653c2d215dd0d46 would require you
to duplicate the struct, change a bunch of usages of the old struct to
the new struct, then change the old one back. This is hugely annoying
and complicated, and we should avoid this kind of rigamarole if
possible.

-- 
Pedro


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#114920): https://edk2.groups.io/g/devel/message/114920
Mute This Topic: https://groups.io/mt/104081468/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-