From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 9B3B6D80DF6 for ; Wed, 31 Jan 2024 20:41:26 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=5V7q2dtF6AJ016+aQSKqcZWh5zGdpFeofL2asxQhs3A=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20140610; t=1706733685; v=1; b=I2P8UndAduEfW9h8SLd3tHzxgNN+iMhTLqx5vVfcIGAG99JOeCwpc5W2eC+npbdiYNkp+sYj uaW/I3e2visIOcbphXQh8TID5nykZwvW7WFjDIq2KsjwkaEPOzmSLi7bdvzbhh9AsT6w1+HlQ4r 9/NTXTDHEZGtz08LUaPb7uqw= X-Received: by 127.0.0.2 with SMTP id NoPaYY7687511x8WdcPrFoSy; Wed, 31 Jan 2024 12:41:25 -0800 X-Received: from mail-vs1-f51.google.com (mail-vs1-f51.google.com [209.85.217.51]) by mx.groups.io with SMTP id smtpd.web11.6165.1706733684627673088 for ; Wed, 31 Jan 2024 12:41:24 -0800 X-Received: by mail-vs1-f51.google.com with SMTP id ada2fe7eead31-46b20d7eebcso90816137.1 for ; Wed, 31 Jan 2024 12:41:24 -0800 (PST) X-Gm-Message-State: AQPj4VeKNrupFwPGvLnolzMXx7686176AA= X-Google-Smtp-Source: AGHT+IFgnq1vEJ8GsQKRa0vMv7XvHE5HG3DEiHfuzwPJJmsfwQrXJpSJJHkvAVWZiiYQ1wNqFbF/eaVKZ6PtgYCrBkY= X-Received: by 2002:a05:6102:5f46:b0:46b:d11:cab6 with SMTP id il6-20020a0561025f4600b0046b0d11cab6mr2080425vsb.10.1706733683496; Wed, 31 Jan 2024 12:41:23 -0800 (PST) MIME-Version: 1.0 References: <67b9f5d7-c338-473c-9322-d26022ef8f32@linux.microsoft.com> In-Reply-To: <67b9f5d7-c338-473c-9322-d26022ef8f32@linux.microsoft.com> From: "Pedro Falcato" Date: Wed, 31 Jan 2024 20:41:12 +0000 Message-ID: Subject: Re: [edk2-devel] Commits Spanning Packages To: devel@edk2.groups.io, mikuback@linux.microsoft.com Cc: Andrew Fish , Leif Lindholm , Michael D Kinney , Pierre Gondois , Ard Biesheuvel , Abner Chang , Min Xu , Zhiguang Liu , Tuan Phan , Yu Pu , Ray Ni Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pedro.falcato@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=I2P8UndA; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none) On Wed, Jan 31, 2024 at 6:58=E2=80=AFPM Michael Kubacki wrote: > > Some commits have been spanning packages. For a monolithic upstream repo > like edk2, this makes ingesting commits downstream more tedious if > project requirements do not necessitate all packages to be maintained. > > Below are examples of commits spanning packages. Many of these are more > problematic because "core" packages like MdePkg, MdeModule, SecurityPkg, > UefiCpuPkg, etc. are involved. OvmfPkg and ArmVirtPkg seem to be a > common pairing. To focus the examples below, I excluded commits with > that pair. > > The request is to limit crossing package boundaries as much as possible > and for maintainers to assess package impact when merging changes. Personally I'm all for making downstreams' lives easier, but I don't see how one could pull off many of the changes you linked, in 2+ commits, without breaking bisection. Pulling off 103fa647d159e3d76be2634d2653c2d215dd0d46 would require you to duplicate the struct, change a bunch of usages of the old struct to the new struct, then change the old one back. This is hugely annoying and complicated, and we should avoid this kind of rigamarole if possible. --=20 Pedro -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114920): https://edk2.groups.io/g/devel/message/114920 Mute This Topic: https://groups.io/mt/104081468/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-