From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by mx.groups.io with SMTP id smtpd.web10.31199.1675275002307920419 for ; Wed, 01 Feb 2023 10:10:02 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=d6mqvYcm; spf=pass (domain: gmail.com, ip: 209.85.214.170, mailfrom: pedro.falcato@gmail.com) Received: by mail-pl1-f170.google.com with SMTP id r8so12422708pls.2 for ; Wed, 01 Feb 2023 10:10:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=h/bGhYwTruGpe5/9A541vjKN5AtoaA9DYenqW9ShMIs=; b=d6mqvYcmjTyyIy2JpGoy6X11qASU3i/7xPkSllOAVWCNLiWAN5JB7ZaquvBFxUGUA+ nrlcaKW9smJhqv2OsWDbKuBooUam1pbSaEJ04EBMMBKeXhdyS3eft8a/s4OHSl6rVwh4 yXyePurp9zj3/82DB9LfF/xLHhD+IXnOqSP2uzEP/sxODeYhBZfKrkP2TlCsieT2yyjF LZGhHRebN5d9HkBI+1z9d4AsxMUkQsQXJw4ksr5brgmC1VxAg7d7iFDmoENX8nYMlOT/ 2x56g1NpIzYd6Czt5R2UvK4Ko2YIgKTW32QvzQ4e778coo43P47/hJlQPogvnvrxR0f7 ovNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=h/bGhYwTruGpe5/9A541vjKN5AtoaA9DYenqW9ShMIs=; b=T4AUcBCbuaFws+QLgr/ZrXOTGcov9/gGHbIbkSBRz0lTy9FDtbP0wGSt4TFH72AI/e l+cdoc8gNHOZC4z7vPlF4Sf9Aira+6P9MTLfCW/P66nH5unzTSi0KjhbYAU1MpBV4WON qqrN5ICL38Q1WRTmboEaJw+Tyfsbe8Vzc38Pw1x4gXgLSEZe5ISJ+WoRpOrArxzUDQ2N jCK2fhkKmLPjv2yjD4c1BQibDgtM84UERHPc6S+S1itRTxc773+p5n0MriO/f9ZAfqT9 4Mma2XaStCQFd5pvUwIksh2yqp/nw3zR8Z41k9fKy/ZAREKGxEETBCnFnVjGw2hgGhnx MOdQ== X-Gm-Message-State: AO0yUKWacPZOvG/Zcb7ifk0XRN8mn4k+7+Po4zCxH1Sd1e5JRPLWJjyM Puhfltok26BpEYr/Jz2qHvb3nCjbYT9zY9R3irQ= X-Google-Smtp-Source: AK7set/CfIoVDWbnMndr9zFHCVU9ZrHXXxB5FuXxflknowCLW5QSwrZsFlsCGpikqnTJtiMLd1zIqhJocj4SC4z4zdw= X-Received: by 2002:a17:90a:102:b0:22c:afd9:40fe with SMTP id b2-20020a17090a010200b0022cafd940femr645028pjb.134.1675275001688; Wed, 01 Feb 2023 10:10:01 -0800 (PST) MIME-Version: 1.0 References: <20230201144750.71495-1-mhaeuser@posteo.de> In-Reply-To: <20230201144750.71495-1-mhaeuser@posteo.de> From: "Pedro Falcato" Date: Wed, 1 Feb 2023 18:09:50 +0000 Message-ID: Subject: Re: [PATCH 1/1] .pytool/Plugin/EccCheck: Add PACKAGES_PATH support To: =?UTF-8?Q?Marvin_Ha=CC=88user?= Cc: devel@edk2.groups.io, Sean Brogan , Michael Kubacki , Michael D Kinney , Liming Gao Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Feb 1, 2023 at 2:48 PM Marvin Ha=CC=88user wro= te: > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4326 > > EccBuild currently assumes all packages reside in WORKSPACE. However, > this is obviously not the case for many setups. Most notably, Ext4Pkg > is located in edk2-platforms/Features and thus cannot be in WORKSPACE > in any reasonable setup. > > Use Edk2Path to locate the package in WORKSPACE and PACKAGES_PATH. > > Cc: Sean Brogan > Cc: Michael Kubacki > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Pedro Falcato > Signed-off-by: Marvin H=C3=A4user > --- > .pytool/Plugin/EccCheck/EccCheck.py | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/.pytool/Plugin/EccCheck/EccCheck.py b/.pytool/Plugin/EccChec= k/EccCheck.py > index 4fbc67765fdf..7235fcb55cea 100644 > --- a/.pytool/Plugin/EccCheck/EccCheck.py > +++ b/.pytool/Plugin/EccCheck/EccCheck.py > @@ -69,6 +69,13 @@ class EccCheck(ICiBuildPlugin): > env.set_shell_var('PACKAGES_PATH', os.pathsep.join(Edk2pathObj.P= ackagePathList)) > self.ECC_PASS =3D True > > + abs_pkg_path =3D Edk2pathObj.GetAbsolutePathOnThisSystemFromEdk2= RelativePath(packagename) > + > + if abs_pkg_path is None: > + tc.SetSkipped() > + tc.LogStdError("No Package folder {0}".format(abs_pkg_path)) > + return 0 > + > # Create temp directory > temp_path =3D os.path.join(workspace_path, 'Build', '.pytool', '= Plugin', 'EccCheck') > try: > @@ -77,7 +84,7 @@ class EccCheck(ICiBuildPlugin): > shutil.rmtree(temp_path) > # Copy package being scanned to temp_path > shutil.copytree ( > - os.path.join(workspace_path, packagename), > + abs_pkg_path, > os.path.join(temp_path, packagename), > symlinks=3DTrue > ) > -- > 2.39.1 > FWIW, Acked-by: Pedro Falcato Please merge this so we can get edk2-platforms CI on Ext4Pkg. --=20 Pedro