From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 5DA02AC1750 for ; Mon, 13 Nov 2023 19:07:50 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=uEACu1vLKlX2/oufhN8OK3xLJP/Ld7RmNhe2MCufNy0=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20140610; t=1699902469; v=1; b=r3bcdyMqxZe5PKioYX9/GF+PhTl54kSS+7C9FbzR1qArgSeWg7BWX9r6dG1naENqr+StQlho wnX01GFWir4sTWT5KmUXr9DUDaxVqHILEPv6Uk2pdh+8/S4tFABNasX0af++tgTunoWWRELuGVb uNK4SsPAMbM0bw1GHkPGNS9A= X-Received: by 127.0.0.2 with SMTP id faAMYY7687511xWNC46jJzNU; Mon, 13 Nov 2023 11:07:49 -0800 X-Received: from mail-ot1-f43.google.com (mail-ot1-f43.google.com [209.85.210.43]) by mx.groups.io with SMTP id smtpd.web11.4170.1699902468307996013 for ; Mon, 13 Nov 2023 11:07:48 -0800 X-Received: by mail-ot1-f43.google.com with SMTP id 46e09a7af769-6d2fedd836fso2946806a34.1 for ; Mon, 13 Nov 2023 11:07:48 -0800 (PST) X-Gm-Message-State: Fm82HSOgwzTep1RjMIw9HEN3x7686176AA= X-Google-Smtp-Source: AGHT+IH5oWZkyxCh7yCoX0uNHjRWkU6v3XQyTEQzNdnuI5y2fMJOaFdUxlbmgeXz7xTdFrsrNmFVIs/57vRDreMoOrw= X-Received: by 2002:a05:6358:7e55:b0:16b:a8a7:4b2a with SMTP id p21-20020a0563587e5500b0016ba8a74b2amr229712rwm.5.1699902467257; Mon, 13 Nov 2023 11:07:47 -0800 (PST) MIME-Version: 1.0 References: <0107c96b-849a-db48-194b-1a4c1f3b0c78@redhat.com> In-Reply-To: <0107c96b-849a-db48-194b-1a4c1f3b0c78@redhat.com> From: "Pedro Falcato" Date: Mon, 13 Nov 2023 19:07:36 +0000 Message-ID: Subject: Re: [edk2-devel] edk2 uncrustify update (73.0.8)? To: devel@edk2.groups.io, lersek@redhat.com Cc: Michael Kubacki , Michael Kinney , Andrew Fish , Marcin Juszkiewicz , "Leif Lindholm (Quic)" Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pedro.falcato@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=r3bcdyMq; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Mon, Nov 13, 2023 at 11:58=E2=80=AFAM Laszlo Ersek w= rote: > > Hi Michael, > > recently I encountered an uncrustify failure on github. > > The reason was that my local uncrustify was *more recent* (73.0.8) than > the one we use in edk2 CI (which is 73.0.3, per the edk2 file > ".pytool/Plugin/UncrustifyCheck/uncrustify_ext_dep.yaml"). Wait, you can use upstream uncrustify? I'm just using whatever uncrustify version I took from the project-mu fork... > > Updating the version number in the YAML file (i.e., advancing edk2 to > version 73.0.8) seems easy enough, but: > > - Do you think 73.0.8 is mature enough for adoption in edk2? > > This upstream uncrustify release was tagged in April (and I can't see > any more recent commits), so I assume it should be stable. > > - Would the version update require a whole-tree re-uncrustification? Please, no. I didn't mind doing an initial reformatting at first, but doing this continuously is both 1) problem-prone 2) just amazing amounts of churn. Let's say I have version N, you have version N+1 - we may never get any final, formatted output as your version formats it differently from mine. I don't know how the CI is doing its thing atm (I haven't merged anything myself to edk2), but the uncrustify check should be relaxed to just a warning. There's nothing wrong with what my uncrustify version is formatting to, there's nothing wrong with yours either, and CI isn't necessarily wrong either. And, to be fair, I already find uncrustify a large pain in the butt to use (requiring a custom fork really does not help), but I find the benefits worth it *locally*, as my coding style is also quite different from the NT-esque style. --=20 Pedro -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111174): https://edk2.groups.io/g/devel/message/111174 Mute This Topic: https://groups.io/mt/102559740/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-