From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vs1-f50.google.com (mail-vs1-f50.google.com [209.85.217.50]) by mx.groups.io with SMTP id smtpd.web11.38602.1688403702832836304 for ; Mon, 03 Jul 2023 10:01:43 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@gmail.com header.s=20221208 header.b=bZKNZ6FI; spf=pass (domain: gmail.com, ip: 209.85.217.50, mailfrom: pedro.falcato@gmail.com) Received: by mail-vs1-f50.google.com with SMTP id ada2fe7eead31-443571eda4dso1495592137.2 for ; Mon, 03 Jul 2023 10:01:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688403701; x=1690995701; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=hDsUSYH8RTdPsrcxSddN9TEzJpzjjJ6TMViWkcNrCNY=; b=bZKNZ6FIZahjuX91yh+bLUEWwWblGtDiS6dR5hFh3QUrG0qzne4DhLK3jWIaFL0jfi SmSbeJHETfCj+GsPm6jPyW7a1RJE+pcx2C9sPn4A31cVPjcOLl8ZYMe2dkZx6XXA7MlP wYfTo9zTMEdkhEZINkeeg7VuqlVMyDaJmPFVz4oFPV/1uWhqzxtoNXwLOagxEbKL69EM 57jG8Qhg8f6XyHHluoxESQ9j8MXLVSGRlQA1FSiPLVvM0USEaZvUkta9DlkMVTC+ij1T /Se6dihBYjJdfv391F4l5BYUJxtKQMlOUfG7BFKwuDpB1VY9zhUv1J3ZwyfGx4t9eLlu 4+/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688403701; x=1690995701; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hDsUSYH8RTdPsrcxSddN9TEzJpzjjJ6TMViWkcNrCNY=; b=aA/ni3AIC1vBJyFuvXT4OfpFkOcjooJOdCeIpBrCbqvaexkgBdVR2m3ZWOoxok82j5 2CP0Pjoi9R8Cpdz2vfIFu1PznHdyuP/E7I0ZqyC/IiM4ITfLQV6lPX2nRmlMsXIqPKo+ 1yRX7lFYkjY8pae8gOsr4kEXBnFCMCto1l3OegzlrPs8WHpD55dbrW/fIQTW5wIs1bs9 oz0beHw8Uoq/15afkmKQFXfeA1eqFdQ/C3T9N3ppA//iGIArHK6ciq02j1JjTSgQ87Rp Fwm9Q1M82ZUXgwbf/eU0Mo/Zcw/yoORoC9XsTyStKh/IcWq+5ajbZHyyyed+wUU4wKdo dT3w== X-Gm-Message-State: ABy/qLZMKK8OFIafdnStn57LUCndyRdcUxYgWjufTBG4rC9uhTDhDjx0 6GHSG1/sekFDFpLzK7dQ2RhHtTnA22eWpcku5ub0qyFA X-Google-Smtp-Source: APBJJlHjAE6Xeg355fpSbKZWj3sKD5bNgndkVjRg9BWbtpR3PaUJYOkMzigMlbP4IbSWu15tHQN7OWHq7i6ujyGTpv4= X-Received: by 2002:a67:fc86:0:b0:443:6052:43ae with SMTP id x6-20020a67fc86000000b00443605243aemr5152061vsp.24.1688403701677; Mon, 03 Jul 2023 10:01:41 -0700 (PDT) MIME-Version: 1.0 References: <20230616072257.1989-1-gavin.xue@intel.com> In-Reply-To: From: "Pedro Falcato" Date: Mon, 3 Jul 2023 18:01:31 +0100 Message-ID: Subject: Re: [edk2-devel] [edk2 PATCH] MdePkg: Use same ProcessorBind symbol define for RISCV64 To: devel@edk2.groups.io, michael.d.kinney@intel.com Cc: "Xue, Gavin" , "sunilvl@ventanamicro.com" , "Warkentin, Andrei" , "Wang, Yimin" , "Sheng, Alan" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Jun 30, 2023 at 5:59=E2=80=AFPM Michael D Kinney wrote: > > Using the same include guard define name is preferred. > > Why was anything other than that considered? I don't see the point of making the include guard an actual part of the "API". Consumers should not depend on it being named $WHATEVER. That is a hack. Include guards are an implementation detail and making that stable actively stops you from doing things like using #pragma once or fixing the __DOUBLE_UNDERSCORE_H__ stuff. So I would vote for not changing this, downstream consumers that rely on __PROCESSOR_BIND_H__ should be fixed, downstream. --=20 Pedro