From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by mx.groups.io with SMTP id smtpd.web10.51301.1680460711062562117 for ; Sun, 02 Apr 2023 11:38:31 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=oteKRAFQ; spf=pass (domain: gmail.com, ip: 209.85.214.180, mailfrom: pedro.falcato@gmail.com) Received: by mail-pl1-f180.google.com with SMTP id kq3so25970677plb.13 for ; Sun, 02 Apr 2023 11:38:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680460710; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=RpcooXc/axDuHSyD2Xd3a2CbJQ4V01XgJfuOfB0bNpY=; b=oteKRAFQpWhVDE8I/lBzIY+cjGussK5mvb2IaTwNT4yE8FEYMOFhkBxY26kAmAGsBQ NEpVDI+rVkaT75ue0fs44wmaF7dPxvRuf8FZT9buWr2xgJfAt6cAYYwkFppp0hmdHcje mJw4G6H4M/z7DEY+cdb5UWA1m5rZziGmDeNzbb3Bn7C6GvtRJIbivCYSqSfAmRM7kDeB 1Bnz7jEJ7t/PGHKlqZKVoUMxxFiwA5UZzXChH1u41cLJdNe6odTQY7jaLG1a+mthfAMh BsLP3pNF6lsT2vAaayDUj/O4lrOCDbtM0SK8T0Dd/N6/zGX6C43ltos+CxfX+whJmJcs 5MRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680460710; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RpcooXc/axDuHSyD2Xd3a2CbJQ4V01XgJfuOfB0bNpY=; b=rdQ3bxkHEA7zcp1TRclbgObDOK+15nxmGXIFZb1aSCXz9KAFUqGiYSLNSNsmgxSjf2 jcU4z0pRoyxARsNXI/dHDb9cc2n6cFlayMlkOcMIPaFj/d9Q8CiA/pRysv/P+ILEmeVH 93Huhqn2Y/JuHtEnuB8DU9i6ltM8fQ/I6nPH4Iq/EsXQ6wiXyP4BqLpqryB+p3Eo2HLe wOIhQniZony+6OXVKnTJVH6zVe4+cdo3KfQCklgbQXRLiLwt+1nrSEOs7kel0MhXUP77 kX4zYVeNCzFHWg0s/WhHuNuBPJWZxfy0oTUyUi2Fw0xr9uzQXmWdhSIlUe7rEHsc4lwX 1AsQ== X-Gm-Message-State: AAQBX9cQpAHxtsiaRbNYLhWgRWPbpLkTkzr+HQ2jIkBuauiUFPYM2WpZ Vl4JO+DMcaGQ3AAYhnIJ40r0SnWCrRQwo8tKA9HHEbvp X-Google-Smtp-Source: AKy350YC/sHx20DISSdEGb3IyyeQxYWg0CSqC81uJ7eRRcP9B/9z93NvlC3Vp7tyX850+py/8QVt5LvC2clXU9PI1YM= X-Received: by 2002:a17:90a:68cb:b0:23f:d120:4413 with SMTP id q11-20020a17090a68cb00b0023fd1204413mr10003841pjj.1.1680460710195; Sun, 02 Apr 2023 11:38:30 -0700 (PDT) MIME-Version: 1.0 References: <20230328173111.759017-1-rebecca@bsdio.com> <02fb01d961dc$88d6acd0$9a840670$@byosoft.com.cn> In-Reply-To: From: "Pedro Falcato" Date: Sun, 2 Apr 2023 19:38:19 +0100 Message-ID: Subject: =?UTF-8?B?UmU6IOWbnuWkjTogW2VkazItZGV2ZWxdIFtQQVRDSCB2MiAwMC8xM10gQmFzZVRvb2xzLENyeXB0b1BrZyxNZGVQa2csT3ZtZlBrZzogRGVsZXRlIENMQU5HMzUsQ0xBTkczOCxHQ0M0OCxHQ0M0OSwgcmVuYW1lIEdDQzUgdG8gR0NDLCB1cGRhdGUgQ0xBTkdEV0FSRiwgZGVsZXRlIFZTIDIwMDgtMjAxMywgRUJD?= To: devel@edk2.groups.io, rebecca@bsdio.com Cc: gaoliming , Oliver Smith-Denny , Guomin Jiang , Xiaoyu Lu , Jian J Wang , Jiewen Yao , Ard Biesheuvel , Jordan Justen , Gerd Hoffmann , Bob Feng , Andrew Fish , Leif Lindholm , Michael D Kinney Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, Apr 2, 2023 at 4:41=E2=80=AFPM Rebecca Cran wro= te: > > On 3/28/23 7:19 PM, gaoliming wrote: > > > GCC49 is one GCC tool chain without LTO enable option. GCC5 is another = GCC tool chain with LTO enable option. > > > > They have the different usage. I suggest to keep GCC49 and GCC5 both, a= nd also keep their name as is. > > Is anything still _using_ GCC49 though? Since I strongly suspect nobody > is using gcc 4.9, I'll rename it to GCCNOLTO. As expressed off-list on UEFI talkbox, I like GCCNOLTO, but I would rather keep GCC5 as GCC5, for the next future iteration of "lets bump a new toolchain because we need feature X". > > When I try and build OVMF with it, I get the following error: > > > /UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c > /home/bcran/src/uefi/edk2/OvmfPkg/Library/BaseMemEncryptSevLib/X64/SnpPag= eStateChangeInternal.c: > In function =E2=80=98InternalSetPageState=E2=80=99: > /home/bcran/src/uefi/edk2/OvmfPkg/Library/BaseMemEncryptSevLib/X64/SnpPag= eStateChangeInternal.c:166:37: > error: =E2=80=98Cmd=E2=80=99 may be used uninitialized in this function > [-Werror=3Dmaybe-uninitialized] > 166 | Info->Entry[i].CurrentPage =3D 0; > | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~ > /home/bcran/src/uefi/edk2/OvmfPkg/Library/BaseMemEncryptSevLib/X64/SnpPag= eStateChangeInternal.c:32:10: > note: =E2=80=98Cmd=E2=80=99 was declared here > 32 | UINTN Cmd; > | ^~~ > rm -f > /home/bcran/src/uefi/edk2/Build/OvmfX64/RELEASE_GCC49/X64/NetworkPkg/Libr= ary/DxeIpIoLib/DxeIpIoLib/OUTPUT/DxeIpIoLib.lib > "ar" cr > /home/bcran/src/uefi/edk2/Build/OvmfX64/RELEASE_GCC49/X64/NetworkPkg/Libr= ary/DxeIpIoLib/DxeIpIoLib/OUTPUT/DxeIpIoLib.lib > @/home/bcran/src/uefi/edk2/Build/OvmfX64/RELEASE_GCC49/X64/NetworkPkg/Lib= rary/DxeIpIoLib/DxeIpIoLib/OUTPUT/object_files.lst > cc1: all warnings being treated as errors > make: *** [GNUmakefile:304: > /home/bcran/src/uefi/edk2/Build/OvmfX64/RELEASE_GCC49/X64/OvmfPkg/Library= /BaseMemEncryptSevLib/PeiMemEncryptSevLib/OUTPUT/X64/SnpPageStateChangeInte= rnal.obj] > Error 1 This is unsurprising, plenty of NOLTO build breakage. Since no one seems to use this, could we think about axing this or? Just seems silly to have an extra toolchain (with extra cognitive overhead for anyone looking at tools_def) for s/-flto//g --=20 Pedro