Re: [edk2-devel] PATCH [1/1] ArmPkg: Fix GicV2 BaseAddress types

["Pedro Falcato" <pedro.falcato@gmail.com>]

(+CC maintainers)

On Thu, May 11, 2023 at 5:47 PM <neiljay@gmail.com> wrote:
>
> The GIC v2 base addresses can be 64bit, don't limit to 32 on 64bit
> machines.
>
> Signed-off-by: Neil Jones <neil.jones@blaize.com>
> ---
>  ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2Dxe.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2Dxe.c b/ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2Dxe.c
> index 25290342bd..b990bf3a8a 100644
> --- a/ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2Dxe.c
> +++ b/ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2Dxe.c
> @@ -25,8 +25,8 @@ Abstract:
>  extern EFI_HARDWARE_INTERRUPT_PROTOCOL   gHardwareInterruptV2Protocol;
>  extern EFI_HARDWARE_INTERRUPT2_PROTOCOL  gHardwareInterrupt2V2Protocol;
>
> -STATIC UINT32  mGicInterruptInterfaceBase;
> -STATIC UINT32  mGicDistributorBase;
> +STATIC UINTN mGicInterruptInterfaceBase;
> +STATIC UINTN mGicDistributorBase;
>
>  /**
>    Enable interrupt source Source.
> --
> 2.39.2

LGTM, particularly as the PCDs are 64-bit already.
Reviewed-by: Pedro Falcato <pedro.falcato@gmail.com>

but CC'ing the proper maintainers (please do so in the future!)

-- 
Pedro