From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) by mx.groups.io with SMTP id smtpd.web11.32274.1683916147466687484 for ; Fri, 12 May 2023 11:29:07 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20221208 header.b=nYi5OAv2; spf=pass (domain: gmail.com, ip: 209.85.210.175, mailfrom: pedro.falcato@gmail.com) Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-64a9335a8e7so7618878b3a.0 for ; Fri, 12 May 2023 11:29:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683916147; x=1686508147; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Y20eyDdw86E+ICdrSM1ksHioVYJmnSISDVoVRBXzkK4=; b=nYi5OAv2Xn2M+zP6hWtJm4XsBsXmLjPx3lruAWeJJYGmFnmCc5U4LrXvL2hLqKzh09 Cpwi6hvmTur1Kt43UH2u9WaeFQzu1h9H4OMCdNHI5wMtf7vLoeZ8VYkB35p6MEnktRF6 DQ4C0FZywMiP0C0duUhNHQkZ9AwMePutPM+IWnMfqsADylLQYEUa7SGSLWO4G22KlmP0 zBezhjCYvaxHPSJR/HF1XXfwBYr3UR5Tr25LdzAcsh/klxuLEdXWMc4CzVA5mTlDRvOq igJfA5iQo2Y2MS9zVEgw1pZIXkli4ZoUXTNTHSHwb0+Eh3w+1zuMiMUiMGm+H/yJj0GF X2Iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683916147; x=1686508147; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Y20eyDdw86E+ICdrSM1ksHioVYJmnSISDVoVRBXzkK4=; b=Fy+DZ2oq6yXOZDoRwtyx5ZlPoMALsYFjuR6/MaLETwWLCMaTKIjMiS7Gh4YY10pZN1 wmNFskktlP0Y1I2BkJzIQn7wctaKTQpYpGKJjTDsMXZAM92Nghrq0PiDEFlfDQ3RddM0 BO1wYOy2slYfcx/7YGr0rGzN/1H1TbGAXTUDfi8Yj9Z5NTl5B2DLNLvdIy+27gIc31+1 cM/S2LyEcQ7XgMON6im4fFi6DgVwLLlKOvdKoIyaLPreITQfScKgGouOLciBmj2nTMWC ZSmWPcR5GwmON4/R+jqFlcFTq8ZBeBAt7uYUvZOzMJsy6DFLxIBRxN6CPNoYH6BOL3hc eKQQ== X-Gm-Message-State: AC+VfDwFE4ooePkf2TWH42oDtsymMkHhMVVP52zSSPV2U/zQQbU8y9hf RBpQQWbxJD0y8qNJmPqk/6tUvfqA0OPFYaWreGPD90piX+4= X-Google-Smtp-Source: ACHHUZ6IBIV6hPtUEVoahox9w4crWcMsIY5hK6HQgdbhdiwkLalbng6JP0XDF2YJIugwlrv+wehUtcUluhk0vexTxWY= X-Received: by 2002:a17:90a:ec01:b0:24e:1ca6:2206 with SMTP id l1-20020a17090aec0100b0024e1ca62206mr35758001pjy.8.1683916146652; Fri, 12 May 2023 11:29:06 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: "Pedro Falcato" Date: Fri, 12 May 2023 19:28:55 +0100 Message-ID: Subject: Re: [edk2-devel] PATCH [1/1] ArmPkg: Fix GicV2 BaseAddress types To: devel@edk2.groups.io, neiljay@gmail.com Cc: Leif Lindholm , Ard Biesheuvel , Sami Mujawar Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable (+CC maintainers) On Thu, May 11, 2023 at 5:47=E2=80=AFPM wrote: > > The GIC v2 base addresses can be 64bit, don't limit to 32 on 64bit > machines. > > Signed-off-by: Neil Jones > --- > ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2Dxe.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2Dxe.c b/ArmPkg/Drivers/A= rmGic/GicV2/ArmGicV2Dxe.c > index 25290342bd..b990bf3a8a 100644 > --- a/ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2Dxe.c > +++ b/ArmPkg/Drivers/ArmGic/GicV2/ArmGicV2Dxe.c > @@ -25,8 +25,8 @@ Abstract: > extern EFI_HARDWARE_INTERRUPT_PROTOCOL gHardwareInterruptV2Protocol; > extern EFI_HARDWARE_INTERRUPT2_PROTOCOL gHardwareInterrupt2V2Protocol; > > -STATIC UINT32 mGicInterruptInterfaceBase; > -STATIC UINT32 mGicDistributorBase; > +STATIC UINTN mGicInterruptInterfaceBase; > +STATIC UINTN mGicDistributorBase; > > /** > Enable interrupt source Source. > -- > 2.39.2 LGTM, particularly as the PCDs are 64-bit already. Reviewed-by: Pedro Falcato but CC'ing the proper maintainers (please do so in the future!) --=20 Pedro