From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 903EF941D7A for ; Mon, 21 Oct 2024 19:42:32 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=GyDFfth+B5roNKL0cIanR7dNnYmeCWOePDEfSYDIJ00=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20240830; t=1729539752; v=1; x=1729798951; b=EEywmUurhc4fVD840cwFPM1Qn3NwTnMRTzgOG5cFad7gvQ90GDlipmpIie9WtAMjiGjIrNPv uLnDT7SmauE6yGwHmjU3Ua0tn1ESWH0PcexbpbVfv2/6UuB6kgWIZodjiySSQtytR0iTf2VCXul zO/M+GSPI6nuloYABJx8UxaUZ+2u5yskoYO3MbmhbQV3gZraxR863sBb65lOJITDvuQPwi8NisJ OEgEWSo2kmYwSjfuM2x1/vqPaG/0thWYg3cJWu2kveQGgyR4R0vDgCAsAEClekpnYY0GHAtB9UF RvhoAJL3Ivnkbib57EPChrLz4/7VA0Db4VzSirlHZFqQQ== X-Received: by 127.0.0.2 with SMTP id 9WQ0YY7687511xEKxH8z47gE; Mon, 21 Oct 2024 12:42:31 -0700 X-Received: from mail-vs1-f41.google.com (mail-vs1-f41.google.com [209.85.217.41]) by mx.groups.io with SMTP id smtpd.web11.1454.1729539750511288370 for ; Mon, 21 Oct 2024 12:42:30 -0700 X-Received: by mail-vs1-f41.google.com with SMTP id ada2fe7eead31-4a47fff85d2so1467430137.0 for ; Mon, 21 Oct 2024 12:42:30 -0700 (PDT) X-Gm-Message-State: xNisNX1CreSGm0AjakTks3HAx7686176AA= X-Google-Smtp-Source: AGHT+IGhOaDcLOMVZAvD0B9ZQWB8OJJZwGLoo6+wP89CmHy68omFOK+CdEEr7ndtvVOyYLVD7ALrHlZ0mAdff2NebSA= X-Received: by 2002:a05:6102:3f0d:b0:4a5:b159:8557 with SMTP id ada2fe7eead31-4a73fa4bd69mr1360386137.4.1729539749349; Mon, 21 Oct 2024 12:42:29 -0700 (PDT) MIME-Version: 1.0 References: <20241011012040.274642-1-rebecca@bsdio.com> In-Reply-To: From: "Pedro Falcato" Date: Mon, 21 Oct 2024 20:42:17 +0100 Message-ID: Subject: Re: [edk2-devel] [edk2-CCodingStandardsSpecification PATCH 1/1] Prefer use of `static` C keyword over EDK2 type `STATIC` To: devel@edk2.groups.io, rebecca@bsdio.com Cc: "Kinney, Michael D" Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Mon, 21 Oct 2024 12:42:30 -0700 Resent-From: pedro.falcato@gmail.com Reply-To: devel@edk2.groups.io,pedro.falcato@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240830 header.b=EEywmUur; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io On Mon, Oct 21, 2024 at 3:49=E2=80=AFPM Rebecca Cran via groups.io wrote: > > Thanks, I'll fix it. > > Could you confirm whether the change from STATIC to static is something > we want to go ahead with, or do we want to keep STATIC to allow > GoogleTest to work? You don't need STATIC, doing stuff like -Dstatic=3D (or just #define static in C code) Just Works. For GCC at least. proof of horribleness: https://godbolt.org/z/EvMd6hev8 --=20 Pedro -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120637): https://edk2.groups.io/g/devel/message/120637 Mute This Topic: https://groups.io/mt/108941574/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-