From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vs1-f54.google.com (mail-vs1-f54.google.com [209.85.217.54]) by mx.groups.io with SMTP id smtpd.web10.28173.1629137311216361642 for ; Mon, 16 Aug 2021 11:08:31 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20161025 header.b=jDAMgXNu; spf=pass (domain: gmail.com, ip: 209.85.217.54, mailfrom: pedro.falcato@gmail.com) Received: by mail-vs1-f54.google.com with SMTP id j186so8873851vsc.10 for ; Mon, 16 Aug 2021 11:08:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=E8J5zsi75FmN5hiVA8Czd8dMQHy4utXvrNE1go7jpcY=; b=jDAMgXNuNVSvPshoZ/hfoL8A6iSKFpSvYVTWpcFauoDe18ofvPC/qgCXH2QK4KnXQg 4K92bIeUFf9Vdbo8LNGGuzkPjj4EPzmTbG4WZH8uFuZQCWdl31F21tBPWwWhdj0GDPq/ dIL7oZnBRKetblTXCZ4utUh1vU4gtYtlkOmp6Nv/qc1ptN4FEecd1/VoiafKkeMdtgmS uUHtYF20b54O7gn2GN8t5ycINmRdrNsVoRs30j9nrxf7GF9YGu3Zkc+0tjkLq6yN0bGI 5BAYMHVW29dbRrzm15UqqYF+SC3RmFR14sfyATePDG/yCsx0+7uM/P3XHqEqTAXri5Js gPeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=E8J5zsi75FmN5hiVA8Czd8dMQHy4utXvrNE1go7jpcY=; b=tz5wiISEORFqjNRJX02hyRs+IXIKaoENYJ93HtbPlOqxMQh2FjiBlH8dQyizBhKA/c +xx58XgT4+MOYxS0xHCU98Ux9Qc+8GyP2PXT+cDfMebFtXSiHBmTIBCI4YKYiPReiARc ZPCKyOYtslGS2RaF8WL2R2iATGkv7ngjtr1s3SPtnWFYIlblp9X9PY311MXhhNy+xVNy Y+V69U1UC0sbDkvOki12Q2rEZkHJPyIH1AtGB8pKxYFh1mnEbv3Pn+LQRRXh+IejmasC ETB961AcjuF2Nby5ICIfox7TPUv5fW1nfN9vznyni6YiYvze31qsOuijrQcfPVRo41tJ a2DQ== X-Gm-Message-State: AOAM530dBWPAhAT9vWmUiUiziVBHamKUXhcQVT3whCam/QrwWzWT2Jxb 4pNf4i3LrzUzXS6dHTo4hxiC46Zgy+bKmCqQJMY= X-Google-Smtp-Source: ABdhPJydXCYa9RjcrYXfYeE/bfl/QLKBQjfaJWWpcrrhO2gJQ/srNPohAnf3VYhrpiCapPGyYcOrdLh2wpc343YGzKA= X-Received: by 2002:a67:7fc4:: with SMTP id a187mr146020vsd.59.1629137310342; Mon, 16 Aug 2021 11:08:30 -0700 (PDT) MIME-Version: 1.0 References: <20210815205138.99215-1-pedro.falcato@gmail.com> In-Reply-To: From: "Pedro Falcato" Date: Mon, 16 Aug 2021 19:08:17 +0100 Message-ID: Subject: Re: [edk2-devel] [Patch v3 0/3] Ext4Pkg: Add Ext4Pkg To: "Kinney, Michael D" Cc: "devel@edk2.groups.io" , Leif Lindholm , Bret Barkelew Content-Type: text/plain; charset="UTF-8" Hi Mike, I've sent out v4, which should address those two small issues. Best regards, Pedro On Mon, 16 Aug 2021 at 17:11, Kinney, Michael D wrote: > > Hi Pedro, > > Thank you for addressing all the feedback. > > 1) The Ext4Dxe.dsc does not build due to a missing RegisterFilterLib. > mapping. Looks like the update to add the following line to > Ext4Dxe.dsc after the [Defines] section is missing in this latest > patch series: > > !include MdePkg/MdeLibs.dsc.inc > > When I make this update locally, I can build the following: > * IA32 VS2019 DEBUG > * IA32 VS2019 RELEASE > * IA32 VS2019 NOOPT > * X64 VS2019 DEBUG > * X64 VS2019 RELEASE > * X64 VS2019 NOOPT > * IA32 VS2017 DEBUG > * IA32 VS2017 RELEASE > * IA32 VS2017 NOOPT > * X64 VS2017 DEBUG > * X64 VS2017 RELEASE > * X64 VS2017 NOOPT > * IA32 VS2015x86 DEBUG > * IA32 VS2015x86 RELEASE > * IA32 VS2015x86 NOOPT > * X64 VS2015x86 DEBUG > * X64 VS2015x86 RELEASE > * X64 VS2015x86 NOOPT > * IA32 GCC5 DEBUG > * IA32 GCC5 RELEASE > * IA32 GCC5 NOOPT > * X64 GCC5 DEBUG > * X64 GCC5 RELEASE > * X64 GCC5 NOOPT > > 2) Ext4Disk.h - Brief description needs to be on its own line: > > /** @file Raw filesystem data structures > > Thanks, > > Mike > > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of Pedro Falcato > > Sent: Sunday, August 15, 2021 1:52 PM > > To: devel@edk2.groups.io > > Cc: Pedro Falcato ; Leif Lindholm ; Kinney, Michael D > > ; Bret Barkelew > > Subject: [edk2-devel] [Patch v3 0/3] Ext4Pkg: Add Ext4Pkg > > > > This patch-set adds Ext4Pkg, a package designed to hold various drivers and > > utilities related to the EXT4 filesystem. > > > > Right now, it holds a single read-only UEFI EXT4 driver (Ext4Dxe), which consumes the > > DISK_IO, BLOCK_IO and DISK_IO2 protocols and produce EFI_FILE_PROTOCOL and > > EFI_SIMPLE_FILE_SYSTEM_PROTOCOL; this driver allows the mounting of EXT4 partitions and > > the reading of their contents. > > > > A relevant RFC discussion, which includes a more in-depth walkthrough of EXT4 internals and > > driver limitations is available at https://edk2.groups.io/g/devel/topic/84368561. > > > > This patch set is version 3 and attempts to address issues raised by the > > community in v2's code review. > > > > Cc: Leif Lindholm > > Cc: Michael D Kinney > > Cc: Bret Barkelew > > > > Pedro Falcato (3): > > Ext4Pkg: Add Ext4Pkg.dec and Ext4Pkg.uni. > > Ext4Pkg: Add Ext4Dxe driver. > > Ext4Pkg: Add .DSC file. > > > > Features/Ext4Pkg/Ext4Dxe/BlockGroup.c | 228 ++++++ > > Features/Ext4Pkg/Ext4Dxe/Collation.c | 173 +++++ > > Features/Ext4Pkg/Ext4Dxe/Crc16.c | 75 ++ > > Features/Ext4Pkg/Ext4Dxe/Crc32c.c | 84 ++ > > Features/Ext4Pkg/Ext4Dxe/Directory.c | 498 ++++++++++++ > > Features/Ext4Pkg/Ext4Dxe/DiskUtil.c | 113 +++ > > Features/Ext4Pkg/Ext4Dxe/Ext4Disk.h | 453 +++++++++++ > > Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.c | 808 +++++++++++++++++++ > > Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.h | 1038 +++++++++++++++++++++++++ > > Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.inf | 149 ++++ > > Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.uni | 15 + > > Features/Ext4Pkg/Ext4Dxe/Extents.c | 595 ++++++++++++++ > > Features/Ext4Pkg/Ext4Dxe/File.c | 787 +++++++++++++++++++ > > Features/Ext4Pkg/Ext4Dxe/Inode.c | 465 +++++++++++ > > Features/Ext4Pkg/Ext4Dxe/Partition.c | 125 +++ > > Features/Ext4Pkg/Ext4Dxe/Superblock.c | 297 +++++++ > > Features/Ext4Pkg/Ext4Pkg.dec | 17 + > > Features/Ext4Pkg/Ext4Pkg.dsc | 68 ++ > > Features/Ext4Pkg/Ext4Pkg.uni | 14 + > > 19 files changed, 6002 insertions(+) > > create mode 100644 Features/Ext4Pkg/Ext4Dxe/BlockGroup.c > > create mode 100644 Features/Ext4Pkg/Ext4Dxe/Collation.c > > create mode 100644 Features/Ext4Pkg/Ext4Dxe/Crc16.c > > create mode 100644 Features/Ext4Pkg/Ext4Dxe/Crc32c.c > > create mode 100644 Features/Ext4Pkg/Ext4Dxe/Directory.c > > create mode 100644 Features/Ext4Pkg/Ext4Dxe/DiskUtil.c > > create mode 100644 Features/Ext4Pkg/Ext4Dxe/Ext4Disk.h > > create mode 100644 Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.c > > create mode 100644 Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.h > > create mode 100644 Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.inf > > create mode 100644 Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.uni > > create mode 100644 Features/Ext4Pkg/Ext4Dxe/Extents.c > > create mode 100644 Features/Ext4Pkg/Ext4Dxe/File.c > > create mode 100644 Features/Ext4Pkg/Ext4Dxe/Inode.c > > create mode 100644 Features/Ext4Pkg/Ext4Dxe/Partition.c > > create mode 100644 Features/Ext4Pkg/Ext4Dxe/Superblock.c > > create mode 100644 Features/Ext4Pkg/Ext4Pkg.dec > > create mode 100644 Features/Ext4Pkg/Ext4Pkg.dsc > > create mode 100644 Features/Ext4Pkg/Ext4Pkg.uni > > > > -- > > 2.32.0 > > > > > > > > > > > -- Pedro Falcato