From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 39CA0AC1050 for ; Fri, 1 Dec 2023 20:52:59 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=oZFksFYpK90s4tBNrpCdmzDjFUitWTn9ImbkOUiyuhU=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20140610; t=1701463977; v=1; b=sB21C1iX6z6+os9Qah5E9LBDzYkzZktlg9Apb5/6RdOiJfHL0DjCuGRkXg4rCJXCi8ok5yit wbSNSoJRNsjvrspdXSPVR7Vlqp/9Vwnoz0D4ycg3syuR1PLFWJEu0IFE1Ad7QiE9erVf/+AjpHS reAL2w11OgdBtZ2jTdmsW+vk= X-Received: by 127.0.0.2 with SMTP id ud9dYY7687511xKBJsttqdr5; Fri, 01 Dec 2023 12:52:57 -0800 X-Received: from mail-vs1-f41.google.com (mail-vs1-f41.google.com [209.85.217.41]) by mx.groups.io with SMTP id smtpd.web10.3922.1701463977178980784 for ; Fri, 01 Dec 2023 12:52:57 -0800 X-Received: by mail-vs1-f41.google.com with SMTP id ada2fe7eead31-46450be6c13so953057137.3 for ; Fri, 01 Dec 2023 12:52:57 -0800 (PST) X-Gm-Message-State: nwGXUQM3AudVqJqrf6EXjrWdx7686176AA= X-Google-Smtp-Source: AGHT+IEnpQxIoBYqeLJw2k8EY9pJ3nEydvy7/BvrSi55eYiqr2VF4bGDd5KWK3erCN9WkWt1BBVX6WgJ8fzsDDepURU= X-Received: by 2002:a67:f9c3:0:b0:464:4ceb:aa29 with SMTP id c3-20020a67f9c3000000b004644cebaa29mr323649vsq.11.1701463975935; Fri, 01 Dec 2023 12:52:55 -0800 (PST) MIME-Version: 1.0 References: <20231130224214.86027-1-pedro.falcato@gmail.com> <20231130224214.86027-2-pedro.falcato@gmail.com> <3a8ceb26-6fe9-4a1a-96d2-e74f7b3e7baf@linux.microsoft.com> <179CD05BE5E43398.18076@groups.io> In-Reply-To: <179CD05BE5E43398.18076@groups.io> From: "Pedro Falcato" Date: Fri, 1 Dec 2023 20:52:43 +0000 Message-ID: Subject: Re: [edk2-devel] [PATCH 1/2] UnitTestFrameworkPkg: Fix Google Test components with multiple files To: devel@edk2.groups.io, pedro.falcato@gmail.com Cc: mikuback@linux.microsoft.com, Michael D Kinney , Sean Brogan Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pedro.falcato@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=sB21C1iX; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Fri, Dec 1, 2023 at 8:50=E2=80=AFPM Pedro Falcato via groups.io wrote: > > On Fri, Dec 1, 2023 at 5:07=E2=80=AFPM Michael Kubacki > wrote: > > > > Hi Pedro, > > > > Visual Studio NOOPT builds result in linker errors. I combined your > > patch series with the test instruction change in this PR - > > https://github.com/tianocore/edk2/pull/5096. > > > > You can use a PR to test the VS build. > > Thanks for the heads up, but I ended up booting Windows to expedite the p= rocess. > > So, I noticed from the build logs that libcmtd.lib was having issues > doing a /WHOLEARCHIVE link (not unheard of, had the same problems with > Linux system libraries). Then I noticed in MSDN: > "The /WHOLEARCHIVE option forces the linker to include every object > file from either a specified static library, or if no library is > specified, from all static libraries specified to the LINK command" > Note the "from all static libraries specified to the LINK command". So > I noticed libcmtd.lib was being specified manually, and I simply > deleted > > /NODEFAULTLIB:libcmt.lib libcmtd.lib ... Forgot to mention that deleting this line allows the link to complete and /WHOLEARCHIVE has the intended effect. --=20 Pedro -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111986): https://edk2.groups.io/g/devel/message/111986 Mute This Topic: https://groups.io/mt/102904623/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-