From: "Pedro Falcato" <pedro.falcato@gmail.com>
To: devel@edk2.groups.io, ardb@kernel.org
Cc: "Michael Kinney" <michael.d.kinney@intel.com>,
"Liming Gao" <gaoliming@byosoft.com.cn>,
"Jiewen Yao" <jiewen.yao@intel.com>,
"Michael Kubacki" <michael.kubacki@microsoft.com>,
"Sean Brogan" <sean.brogan@microsoft.com>,
"Rebecca Cran" <quic_rcran@quicinc.com>,
"Leif Lindholm" <quic_llindhol@quicinc.com>,
"Sami Mujawar" <sami.mujawar@arm.com>,
"Taylor Beebe" <t@taylorbeebe.com>,
"Marvin Häuser" <mhaeuser@posteo.de>,
"Bob Feng" <bob.c.feng@intel.com>
Subject: Re: [edk2-devel] [PATCH v2 01/17] MdePkg/ProcessorBind AARCH64: Add asm macro to emit GNU BTI note
Date: Mon, 27 Mar 2023 15:12:29 +0100 [thread overview]
Message-ID: <CAKbZUD3TcthJbBZyTeoKHrmJE=Xduqj0vFwC=UU9m-+zs_LQng@mail.gmail.com> (raw)
In-Reply-To: <20230327110112.262503-2-ardb@kernel.org>
On Mon, Mar 27, 2023 at 12:01 PM Ard Biesheuvel <ardb@kernel.org> wrote:
>
> Implement a CPP macro that can be called from .S files to emit the .note
> section carrying the annotation that informs the linker that the object
> file is compatible with BTI control flow integrity checks.
>
> Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
> ---
> MdePkg/Include/AArch64/ProcessorBind.h | 31 ++++++++++++++++++++
> 1 file changed, 31 insertions(+)
>
> diff --git a/MdePkg/Include/AArch64/ProcessorBind.h b/MdePkg/Include/AArch64/ProcessorBind.h
> index abe2571245c665f3..11814f1ffaef698a 100644
> --- a/MdePkg/Include/AArch64/ProcessorBind.h
> +++ b/MdePkg/Include/AArch64/ProcessorBind.h
> @@ -186,6 +186,37 @@ typedef INT64 INTN;
> #define GCC_ASM_IMPORT(func__) \
> .extern _CONCATENATE (__USER_LABEL_PREFIX__, func__)
>
> +#if defined(__ARM_FEATURE_BTI_DEFAULT) && __ARM_FEATURE_BTI_DEFAULT == 1
> +#define AARCH64_BTI(__type) \
> + .ifnc __type, ;\
> + bti __type ;\
> + .endif ;\
> + .ifndef .Lgnu_bti_notesize ;\
> + .pushsection .note.gnu.property, "a" ;\
> + .set NT_GNU_PROPERTY_TYPE_0, 0x5 ;\
> + .set GNU_PROPERTY_AARCH64_FEATURE_1_AND, 0xc0000000 ;\
> + .set GNU_PROPERTY_AARCH64_FEATURE_1_BTI, 0x1 ;\
> + .align 3 ;\
> + .long .Lnamesize ;\
> + .long .Lgnu_bti_notesize ;\
> + .long NT_GNU_PROPERTY_TYPE_0 ;\
> +0: .asciz "GNU" ;\
> + .set .Lnamesize, . - 0b ;\
> + .align 3 ;\
> +1: .long GNU_PROPERTY_AARCH64_FEATURE_1_AND ;\
> + .long .Lvalsize ;\
> +2: .long GNU_PROPERTY_AARCH64_FEATURE_1_BTI ;\
> + .set .Lvalsize, . - 2b ;\
> + .align 3 ;\
> + .set .Lgnu_bti_notesize, . - 1b ;\
> + .popsection ;\
> + .endif
> +#endif
> +
> +#endif
> +
> +#ifndef AARCH64_BTI
> +#define AARCH64_BTI(__type)
> #endif
>
> /**
> --
> 2.39.2
Patch-set wide comment: is there any chance we could take this
opportunity to introduce a global ASM_FUNC (or a more Linux-named
ENTRY(FuncName))?
It seems to be that the current way is a bit error prone and you end
up repeating yourself quite a bit with:
ASM_PFX(Foo):
AARCH64_BTI(c)
<code>
having a:
ASM_FUNC(Foo)
<code>
that does proper PFX and BTI expansion internally seems better to me.
--
Pedro
next prev parent reply other threads:[~2023-03-27 14:12 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-27 11:00 [PATCH v2 00/17] Enable BTI support in memory attributes table Ard Biesheuvel
2023-03-27 11:00 ` [PATCH v2 01/17] MdePkg/ProcessorBind AARCH64: Add asm macro to emit GNU BTI note Ard Biesheuvel
2023-03-27 11:52 ` Leif Lindholm
2023-03-27 12:15 ` Ard Biesheuvel
2023-03-27 12:56 ` Leif Lindholm
2023-03-27 12:45 ` Leif Lindholm
2023-03-27 12:46 ` [edk2-devel] " Ard Biesheuvel
2023-03-27 12:49 ` Leif Lindholm
2023-03-27 14:12 ` Pedro Falcato [this message]
2023-03-27 14:24 ` Leif Lindholm
2023-03-30 7:28 ` Ard Biesheuvel
2023-03-30 10:47 ` Leif Lindholm
2023-03-27 11:00 ` [PATCH v2 02/17] MdePkg/BaseCpuLib AARCH64: Make asm files BTI compatible Ard Biesheuvel
2023-03-27 11:00 ` [PATCH v2 03/17] MdePkg/BaseIoLibIntrinsic " Ard Biesheuvel
2023-03-27 11:00 ` [PATCH v2 04/17] MdePkg/BaseLib AARCH64: Make LongJump() " Ard Biesheuvel
2023-03-27 11:01 ` [PATCH v2 05/17] MdePkg/BaseLib AARCH64: Make asm files " Ard Biesheuvel
2023-03-27 11:01 ` [PATCH v2 06/17] MdePkg/BaseMemoryLibOptDxe " Ard Biesheuvel
2023-03-27 11:01 ` [PATCH v2 07/17] MdePkg/BaseSynchronizationLib " Ard Biesheuvel
2023-03-27 11:01 ` [PATCH v2 08/17] MdePkg/BaseRngLib " Ard Biesheuvel
2023-03-27 11:01 ` [PATCH v2 09/17] ArmPkg: Emit BTI opcodes when BTI codegen is enabled Ard Biesheuvel
2023-03-27 11:01 ` [PATCH v2 10/17] ArmPkg/GccLto AARCH64: Add BTI note to LTO helper library Ard Biesheuvel
2023-03-27 11:01 ` [PATCH v2 11/17] ArmPkg, BaseTools AARCH64: Add BTI ELF note to .hii objects Ard Biesheuvel
2023-03-27 13:09 ` Leif Lindholm
2023-03-27 13:16 ` [edk2-devel] " Ard Biesheuvel
2023-03-27 11:01 ` [PATCH v2 12/17] ArmPlatformPkg/PrePeiCore: Make vector table object BTI compatible Ard Biesheuvel
2023-03-27 11:01 ` [PATCH v2 13/17] BaseTools/GenFw: Parse IBT/BTI support status from ELF note Ard Biesheuvel
2023-03-27 11:01 ` [PATCH v2 14/17] BaseTools/GenFw: Add DllCharacteristicsEx field to debug data Ard Biesheuvel
2023-03-27 15:46 ` Marvin Häuser
2023-03-27 16:41 ` Ard Biesheuvel
2023-03-27 11:01 ` [PATCH v2 15/17] MdePkg: Update MemoryAttributesTable to v2.10 Ard Biesheuvel
2023-03-27 13:29 ` Leif Lindholm
2023-03-29 16:47 ` [edk2-devel] " Ard Biesheuvel
2023-03-29 18:07 ` Leif Lindholm
2023-03-27 11:01 ` [PATCH v2 16/17] MdePkg/PeCoffLib: Capture DLL characteristics fieldis in image context Ard Biesheuvel
2023-03-30 14:44 ` [edk2-devel] " Michael Kubacki
2023-03-30 14:53 ` Ard Biesheuvel
2023-03-27 11:01 ` [PATCH v2 17/17] MdeModulePkg: Enable forward edge CFI in mem attributes table Ard Biesheuvel
2023-03-28 22:59 ` [edk2-devel] " Oliver Smith-Denny
2023-04-03 15:48 ` osde
2023-04-04 10:41 ` Ard Biesheuvel
2023-04-04 15:00 ` Oliver Smith-Denny
2023-04-04 15:30 ` Ard Biesheuvel
2023-03-27 11:43 ` [PATCH v2 00/17] Enable BTI support in memory " Leif Lindholm
2023-03-27 12:54 ` [edk2-devel] " Ard Biesheuvel
2023-03-27 13:37 ` Gerd Hoffmann
2023-03-28 23:00 ` Oliver Smith-Denny
2023-03-29 16:31 ` Leif Lindholm
2023-03-30 7:41 ` [edk2-devel] " Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKbZUD3TcthJbBZyTeoKHrmJE=Xduqj0vFwC=UU9m-+zs_LQng@mail.gmail.com' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox