From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 77A1DD808CC for ; Fri, 3 May 2024 17:38:47 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=q7YbyVjMU8V3b47Ma7NVJ1gtMXLVZ/BomSSPzA/xi20=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20240206; t=1714757926; v=1; b=4UQEDHrsUjXdkKwhretxz+FdtJij99SbmJ8xk7t3Fnkg1mTsAnKh4TI9Y2uXyGL7kV3/vU9b dSg20CVqn5nx02jv0vZ9QmewLg17FqY1gSKr0SzuS6ib/EagtHS9Mxx6wPlIMDrAuP4FY7hpzOA S3ZsqGVfy4oGxoxMIK+G277xD/SaB6AIkAdpCtHNq+ixA+Wq3qyNSa5fulOmWs1+KOufwuJ6hfR RM10NG5u1E/mdxXJiT11Qo5VZfgjnp6RDi71xvO8HUkcTFVxvDxeIQfXg4hoklMVEff+/laf+st PNMr9FKajR/TFoDU//yifyLFrYW3RjnwdchlEQeTnqADA== X-Received: by 127.0.0.2 with SMTP id PdCnYY7687511xcoqBfIUO6X; Fri, 03 May 2024 10:38:46 -0700 X-Received: from mail-vs1-f50.google.com (mail-vs1-f50.google.com [209.85.217.50]) by mx.groups.io with SMTP id smtpd.web11.606.1714757925061665166 for ; Fri, 03 May 2024 10:38:45 -0700 X-Received: by mail-vs1-f50.google.com with SMTP id ada2fe7eead31-47eefa04398so619931137.3; Fri, 03 May 2024 10:38:44 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCVqGNWurPybl0E1mrYqOpJsn1rVGEDiwKcF2Eg1z9smrWKZD/47xOmNa9eyXx1qdgqd1zs02B2hlC2o8Ti6LHliUtjAfA== X-Gm-Message-State: aNuk2k3OUAFyy75f2oPkeuzVx7686176AA= X-Google-Smtp-Source: AGHT+IGatdX5BthcXKfNio2oL8LQ2RBgITL6740Gf2OwVQEXJz7giwDDllBCtf3TqmxlfPmFK26Y97RvC/L2ma7G4aQ= X-Received: by 2002:a05:6122:4710:b0:4d3:39c3:717c with SMTP id ed16-20020a056122471000b004d339c3717cmr3644914vkb.1.1714757924039; Fri, 03 May 2024 10:38:44 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: "Pedro Falcato" Date: Fri, 3 May 2024 18:38:32 +0100 Message-ID: Subject: Re: [edk2-rfc] [edk2-devel] Proposal to switch TianoCore Code Review from email to GitHub Pull Requests on 5-24-2024 To: "Kinney, Michael D" Cc: "rfc@edk2.groups.io" , "devel@edk2.groups.io" , Leif Lindholm , "Andrew Fish (afish@apple.com)" Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Fri, 03 May 2024 10:38:45 -0700 Resent-From: pedro.falcato@gmail.com Reply-To: devel@edk2.groups.io,pedro.falcato@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=4UQEDHrs; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none) On Thu, May 2, 2024 at 7:17=E2=80=AFPM Kinney, Michael D wrote: > > > > > -----Original Message----- > > From: rfc@edk2.groups.io On Behalf Of Pedro Falcat= o > > Sent: Thursday, May 2, 2024 10:51 AM > > To: devel@edk2.groups.io; Kinney, Michael D > > Cc: rfc@edk2.groups.io; Leif Lindholm ; Andrew Fish > > (afish@apple.com) > > Subject: Re: [edk2-rfc] [edk2-devel] Proposal to switch TianoCore Code > > Review from email to GitHub Pull Requests on 5-24-2024 > > > > On Wed, May 1, 2024 at 6:44=E2=80=AFPM Michael D Kinney via groups.io > > wrote: > > > * All contributors, maintainers, and reviewers must have GitHub IDs. > > > * The commit message would no longer require Cc:, Reviewed-by:, Acked= - > > by: > > > or Tested-by: tags. The only required tag would be Signed-off-by. > > > > I'd just like to note that losing the CC:, Reviewed-by:, etc is a big > > loss. Gerrit auto-adds Rb's, github PR's do not (I'd guess there's a > > way to pull that off with github actions, but I haven't looked). It'll > > be a mess if I have to go through online GH PR backlogs just to find > > who to CC/add-to-review. It kills the decentralized bit off of git too > > :) > > > > Can you provide more details on the impact of the loss? In my view, commits should be fairly self-describing. What changes, why, are obvious, but who looked at it, who reviewed it, who was cc'd but didn't respond, who tested are also pretty important. Git is supposed to be decentralized, let's not forget. If we ever migrate from GH, if GH ever goes down, if the links ever go down, you'll never be able to know who looked at it. If you're looking at an EDK2 commit deep into an Intel-internal fork, you won't know what "PR #478" is (heck, rebase-and-merge doesn't reference PRs either). Side-note: How are we supposed to find the PR for a given commit? Searching doesn't seem to work well. For instance, I picked a random non-trivial commit out of the current open PRs: MdeModulePkg/Bus/Spi/SpiBus: Adding SpiBus Drivers. https://github.com/tianocore/edk2/pulls?q=3Dis%3Apr+is%3Aopen+MdeModulePkg%= 2FBus%2FSpi%2FSpiBus%3A+Adding+SpiBus+Drivers has no matches? > > I am curious how other GitHub projects handle this topic. I see it I don't think they do, sadly. But I also don't know many people with a positive opinion on GH PRs :) > > It is sad that we're moving to PRs after I finally got a nice and > > sane(ish!) email workflow (openfw.io + b4). Otherwise, no objections, > > it's better than edk2.git's half-email half-PR frankenprocess. > > I'd guess this change only encompasses edk2.git? How about the other > > repos? Any timeline for those? > > The plan is to apply this to all repos, one at a time. Need to get the > revised process documented and working in one repo before applying to all= . Gotcha, thanks! --=20 Pedro -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118560): https://edk2.groups.io/g/devel/message/118560 Mute This Topic: https://groups.io/mt/105873467/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-