From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id BF4A474004A for ; Tue, 9 Apr 2024 15:51:34 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=Ogmy3eM8dKRlHKF9ruCoLqetBMAesx13C2dmbP2UNWc=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20240206; t=1712677893; v=1; b=5KGwz8LIr3yLgU98d6nuLn0Yd2UBlD7MILu8cNtwuV9vVZUJ5Skhm6rLlqEoCTMJ+TRbASVL DBgKL+hGmcV8wi05zlkGp2mbzODmJ93YVrfeR3XWrYjw3B+OCk9B/ispdGjF3gjXqwpIT3OBeHG EkcjOPt5FbloPanZuibKV/lJidKCLmfDuy2Z7rlYoVZ9yD9T4HVeU/xzb+lXJpJzt4hnoejlsr+ A/lssa0vYxrORlqemHBKMs14fnou+pH4ndna3pF5NWhsiSBuOuYYj/CDy8Acq9kWi20E+GupwLv irjbdNqxM+WSOGmO8CBZ0Zf82+DttRNJwFKMYng0vDP/w== X-Received: by 127.0.0.2 with SMTP id f07qYY7687511x4kHfzb7Eur; Tue, 09 Apr 2024 08:51:33 -0700 X-Received: from mail-vs1-f51.google.com (mail-vs1-f51.google.com [209.85.217.51]) by mx.groups.io with SMTP id smtpd.web10.140184.1712677892431856915 for ; Tue, 09 Apr 2024 08:51:32 -0700 X-Received: by mail-vs1-f51.google.com with SMTP id ada2fe7eead31-479d6a85be8so1269658137.3 for ; Tue, 09 Apr 2024 08:51:32 -0700 (PDT) X-Gm-Message-State: wj3j9JxQ1sAWwNwbSQufCEkxx7686176AA= X-Google-Smtp-Source: AGHT+IFw9+DO/bYPLPB15V9QpbVOm5vhxwPTfB/K7k+hN0NPZCG0bqiOgVwFJ920IXw4qW4qNbtjZVICyAdVL2qPmUg= X-Received: by 2002:a05:6102:e09:b0:47a:1c37:76f2 with SMTP id o9-20020a0561020e0900b0047a1c3776f2mr1609135vst.29.1712677891266; Tue, 09 Apr 2024 08:51:31 -0700 (PDT) MIME-Version: 1.0 References: <20240406124154.17978-1-heinrich.schuchardt@canonical.com> <6do7bvuicrgx5w3tti6gaoevmswvndr6u27rihmu2c2fwtx7kj@osdsv4vkb2no> In-Reply-To: <6do7bvuicrgx5w3tti6gaoevmswvndr6u27rihmu2c2fwtx7kj@osdsv4vkb2no> From: "Pedro Falcato" Date: Tue, 9 Apr 2024 16:51:20 +0100 Message-ID: Subject: Re: [edk2-devel] [PATCH v2 1/1] OvmfPkg: OVMF supports USB mouses To: devel@edk2.groups.io, kraxel@redhat.com Cc: Phillip Tennen , Heinrich Schuchardt , Ard Biesheuvel , Jiewen Yao Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Tue, 09 Apr 2024 08:51:32 -0700 Resent-From: pedro.falcato@gmail.com Reply-To: devel@edk2.groups.io,pedro.falcato@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=5KGwz8LI; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Tue, Apr 9, 2024 at 12:56=E2=80=AFPM Gerd Hoffmann w= rote: > > On Mon, Apr 08, 2024 at 08:53:10AM +0100, Phillip Tennen wrote: > > Hi, thank you for taking a look at the patch! > > > > This patch can be verified to be working with this app (which was the > > motivation for submitting this): > > https://github.com/codyd51/uefirc/releases/tag/1.0.1. > > Quoting https://github.com/codyd51/uefirc: > > Q: Should I use this? > A: This should not exist. > > Well. This certainly one of the more interesting ways to have some fun > and improve your rust coding skills. But a justification to include a > mouse driver by default which is not used by anything else? IMHO it > isn't. Maybe some better reasons: 1) It has been conspicuously missing from OVMF. I've heard N questions over the years (on the #osdev IRC, etc) regarding their mouse code not working on OVMF, whereas you'd see that protocol in other normal platforms 2) UsbMouseDxe is part of upstream MdeModulePkg and has no testable upstream consumers. One needs to patch their OVMF to test this easily (or flash it onto some other hardware, which is hard to get for most people, except for maybe the rpi platforms). 3) I don't believe (or would hope) OVMF maintainers will have maintenance overhead from the inclusion. One would hope UsbMouseDxe as-is is correct, and that the QEMU USB mouse is correct (or you'd see the problem from the guest OS's side as well). 4) Mouse support is part of the spec (if you want to argue it shouldn't be in the spec in the first place, I'd agree) For sure, UsbMouseDxe isn't #1 on my most desired EFI modules list (e.g I'd love to eventually be able to consume Ext4Dxe from OVMF, where it'd actually be useful, if I can ever ditch edk2-platforms), but I don't really see the harm in doing it. There's an argument in giving people a full-fledged UEFI implementation of most protocols. OVMF is *the* platform in mainline edk2 after all :) --=20 Pedro -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117549): https://edk2.groups.io/g/devel/message/117549 Mute This Topic: https://groups.io/mt/105365480/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-