From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 40D5BD80696 for ; Tue, 31 Oct 2023 19:19:42 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=JxwPJRfvj32lyKVEpqKg0jzntoRhL+/kO6e6lGlrbdQ=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20140610; t=1698779980; v=1; b=R5dbjnBfiRwjaCzXAnMiYYbCndk/S79cF/F0cHkDF01Ok9dHL4dBc/Qsh+nJAbKXtBa1yu6g PZymYKe1mt2QIhV+E6BEHv5mrebTCfJDks6cliI9eqZk4BcvSH5MRaNX8Qw5t4eOB1SVe/b//C+ DKnXBtqZv1+omY4iP4QEVAcA= X-Received: by 127.0.0.2 with SMTP id csZ9YY7687511xwiiAYUwJYk; Tue, 31 Oct 2023 12:19:40 -0700 X-Received: from mail-vs1-f52.google.com (mail-vs1-f52.google.com [209.85.217.52]) by mx.groups.io with SMTP id smtpd.web11.4746.1698779980258882042 for ; Tue, 31 Oct 2023 12:19:40 -0700 X-Received: by mail-vs1-f52.google.com with SMTP id ada2fe7eead31-457cc01b805so2421764137.0 for ; Tue, 31 Oct 2023 12:19:40 -0700 (PDT) X-Gm-Message-State: J615jUMIjEN0v9ZSbdPGJyTox7686176AA= X-Google-Smtp-Source: AGHT+IHLYT0MsiG17Z3UGoc8Rr6WIZwnDWgJbd7yJ7KUUyhuWJ09yGACtsdUw1N81nvU3CcGyP4MBZ6JjSTGNwT7wO4= X-Received: by 2002:a05:6102:2090:b0:45a:b9d3:ef73 with SMTP id h16-20020a056102209000b0045ab9d3ef73mr13420305vsr.29.1698779979151; Tue, 31 Oct 2023 12:19:39 -0700 (PDT) MIME-Version: 1.0 References: <20231029144613.150580-1-dhaval@rivosinc.com> <20231029144613.150580-4-dhaval@rivosinc.com> <2db1b89a-6c7f-ea3f-becb-1e942b41a3e8@redhat.com> In-Reply-To: From: "Pedro Falcato" Date: Tue, 31 Oct 2023 19:19:15 +0000 Message-ID: Subject: Re: [edk2-devel] [PATCH v7 3/5] MdePkg: Implement RISC-V Cache Management Operations To: Dhaval Sharma Cc: Laszlo Ersek , devel@edk2.groups.io, Michael D Kinney , Liming Gao , Zhiguang Liu , Sunil V L , Daniel Schaefer , Jingyu Li Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pedro.falcato@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=R5dbjnBf; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none) On Tue, Oct 31, 2023 at 9:55=E2=80=AFAM Dhaval Sharma = wrote: > > I am posting an update on behalf of Jingyu as he had trouble with posting= . CC'ing him here: > In summary what we have verified so far: > > I have verified that instructions/op codes are okay. I have also verified= on Qemu that functionally it seems to be calling correct instructions. Ens= ured with negative test cases that any other op codes do cause exceptions a= s expected. > Jingyu was able to verify the CpuFlushCpuDataCache function with this fra= mework (he had to use custom op code based on his soc implementation) on SG= 2042. There is one issue that he is debugging now which is related to other= cache instructions and he will get back with more data. P.S. SG2042 does n= ot implement the exact same CMO opcodes but equivalent ones. So this experi= ment is just an additional data point that helps verify the framework and n= ot CMO itself. > In general it sounds like framework flows are alright and as long as inst= ructions do their job as claimed in the spec, it is lower risk. > > Guess this is what we have so far. If it makes sense to everyone, we coul= d go ahead with merging with this *feature disabled by default* after Jingy= u provides clarity reg failures on SG2042 platform. Otherwise we can wait u= ntil newer Si is available where these exact instructions can be tested and= then upstreamed. Thanks! To be clear, I wasn't NAKing it, I even gave you my Rb. I just think we should be extra careful sending arch-related changes that haven't been tested on real HW, because hardware tends to be tricky :) --=20 Pedro -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110442): https://edk2.groups.io/g/devel/message/110442 Mute This Topic: https://groups.io/mt/102256466/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-