edk2-platforms, continuous integration, testing, and you

edk2-platforms, continuous integration, testing, and you

[Sean]

[-- Attachment #1: Type: text/plain, Size: 1233 bytes --]

There has been a long standing ask to/from the Edk2/UEFI community to 
improve the code contribution process, quality, and consistency of the 
edk2-platforms repository.

In the weekly Tianocore Tools & CI meeting this topic has come up and 
was discussed at the last meeting (12/12) Tools & CI Meeting - 
2022-12-12 - YouTube 
<https://www.youtube.com/watch?v=RlHv5v6YvCM&list=PLzduEkFEN7nXFjWyGOldPBO-aX02zwZc3&index=1>


There are two asks.

1. If you own any feature package or platform in edk2-platforms please 
get involved in the discussion.  The CI system should reflect the tests 
and features that are important to the contributors of the repository.

A CI system for Edk2-Platforms · Discussion #3721 · tianocore/edk2 
(github.com) <https://github.com/tianocore/edk2/discussions/3721>


2.  If you own a feature package help get your package passing "Core CI" 
and look at enabling more testing (host based unit tests and/or on 
device functional tests).

There is a branch here: spbrogan/edk2-platforms at enable_ci_v1 
(github.com) 
<https://github.com/spbrogan/edk2-platforms/tree/enable_ci_v1> where I 
have started to enable Core CI (started with Ext4Pkg and 
Usb3DebugFeaturePkg as examples).



Thanks

Sean




[-- Attachment #2: Type: text/html, Size: 1797 bytes --]

Re: [edk2-devel] edk2-platforms, continuous integration, testing, and you

[Pedro Falcato]

[-- Attachment #1: Type: text/plain, Size: 601 bytes --]

Sean,

Thank you for making edk2 better :)

I have replied to your github discussion with a bunch of my ideas, as both
a feature package maintainer and platform maintainer.
(
https://github.com/tianocore/edk2/discussions/3721#discussioncomment-4596465
)

I'm willing to discuss these things further as long as it's not at *checks
edk2 tools & CI meeting time* 1am (email, chat, 1-on-1, you name it).
I am also interested in getting QemuOpenBoardPkg into your platform CI
initiative as it's a simple platform that only requires QEMU to boot (plus
a copy of edk2-platforms and edk2 to build).

--
Pedro

[-- Attachment #2: Type: text/html, Size: 938 bytes --]

Re: [edk2-devel] edk2-platforms, continuous integration, testing, and you

[Sean]

[-- Attachment #1: Type: text/plain, Size: 1506 bytes --]

Pedro,

Thanks.  Happy to get some feedback.  I hope others also provide 
feedback.  :)


Regarding the Edk2 tools & CI meeting:  If we scheduled the Jan 16th 
meeting for Jan 17th at 8am Pacific (should be 5 pm your time) would 
that work?  In the meeting we have discussed that we need to rotate the 
time of the meetings to accommodate more world wide attendance and given 
the standard time would fall on a US holiday it seems like a good week 
to do it.  Could you make it that day?

At a minimum we could talk about your packages:

Like should ext4 really depend on redfishpkg?  More likely the library 
should be promoted to a more "core" package.

Could your qemu open board pkg be built using stuart and setup to run 
tests?  More details about the goals and plans for the qemu open board pkg.


Thanks

Sean




On 1/4/2023 3:57 PM, Pedro Falcato wrote:
> Sean,
>
> Thank you for making edk2 better :)
>
> I have replied to your github discussion with a bunch of my ideas, as 
> both a feature package maintainer and platform maintainer.
> (https://github.com/tianocore/edk2/discussions/3721#discussioncomment-4596465)
>
> I'm willing to discuss these things further as long as it's not at 
> *checks edk2 tools & CI meeting time* 1am (email, chat, 1-on-1, you 
> name it).
> I am also interested in getting QemuOpenBoardPkg into your platform CI 
> initiative as it's a simple platform that only requires QEMU to boot 
> (plus a copy of edk2-platforms and edk2 to build).
>
> --
> Pedro

[-- Attachment #2: Type: text/html, Size: 2809 bytes --]

Re: [edk2-devel] edk2-platforms, continuous integration, testing, and you

[Pedro Falcato]

[-- Attachment #1: Type: text/plain, Size: 1471 bytes --]

On Thu, Jan 5, 2023 at 1:52 AM Sean Brogan <spbrogan@outlook.com> wrote:

> Pedro,
>
> Thanks.  Happy to get some feedback.  I hope others also provide
> feedback.  :)
>
>
> Regarding the Edk2 tools & CI meeting:  If we scheduled the Jan 16th
> meeting for Jan 17th at 8am Pacific (should be 5 pm your time) would that
> work?  In the meeting we have discussed that we need to rotate the time of
> the meetings to accommodate more world wide attendance and given the
> standard time would fall on a US holiday it seems like a good week to do
> it.  Could you make it that day?
>
I could make it work that day I believe, but only 2-3 hours later. Does
that work for you folks?

> At a minimum we could talk about your packages:
>
> Like should ext4 really depend on redfishpkg?  More likely the library
> should be promoted to a more "core" package.
>
Should? No. I just haven't had the patience to send a patch moving the
BaseUcs2Utf8Lib to somewhere more central like MdeModulePkg.

> Could your qemu open board pkg be built using stuart and setup to run
> tests?  More details about the goals and plans for the qemu open board
> pkg.
>
Great questions. Probably? It should just work and actually be able to run
tests.
Re: goals and plans, I do have a few ideas but they're all very unclear. We
haven't had much community engagement wrt QemuOBP, it's definitely
something that could be explored (CC Isaac and Theo, who might want to show
up or chime in).

Thanks,
Pedro

[-- Attachment #2: Type: text/html, Size: 2345 bytes --]

Re: [edk2-devel] edk2-platforms, continuous integration, testing, and you

[Théo Jehl]

[-- Attachment #1: Type: text/plain, Size: 2024 bytes --]

Hello,

Could your qemu open board pkg be built using stuart and setup to run
> tests?  More details about the goals and plans for the qemu open board pkg.
>

I like the test idea, however I do not know what Stuart is.
If the goal is getting QOBP to build and pass tests using github CI on
edk2-platforms , it can be an interesting project.

Regards,
Théo


Le ven. 6 janv. 2023 à 00:32, Pedro Falcato <pedro.falcato@gmail.com> a
écrit :

> On Thu, Jan 5, 2023 at 1:52 AM Sean Brogan <spbrogan@outlook.com> wrote:
>
>> Pedro,
>>
>> Thanks.  Happy to get some feedback.  I hope others also provide
>> feedback.  :)
>>
>>
>> Regarding the Edk2 tools & CI meeting:  If we scheduled the Jan 16th
>> meeting for Jan 17th at 8am Pacific (should be 5 pm your time) would that
>> work?  In the meeting we have discussed that we need to rotate the time of
>> the meetings to accommodate more world wide attendance and given the
>> standard time would fall on a US holiday it seems like a good week to do
>> it.  Could you make it that day?
>>
> I could make it work that day I believe, but only 2-3 hours later. Does
> that work for you folks?
>
>> At a minimum we could talk about your packages:
>>
>> Like should ext4 really depend on redfishpkg?  More likely the library
>> should be promoted to a more "core" package.
>>
> Should? No. I just haven't had the patience to send a patch moving the
> BaseUcs2Utf8Lib to somewhere more central like MdeModulePkg.
>
>> Could your qemu open board pkg be built using stuart and setup to run
>> tests?  More details about the goals and plans for the qemu open board
>> pkg.
>>
> Great questions. Probably? It should just work and actually be able to run
> tests.
> Re: goals and plans, I do have a few ideas but they're all very unclear.
> We haven't had much community engagement wrt QemuOBP, it's definitely
> something that could be explored (CC Isaac and Theo, who might want to show
> up or chime in).
>
> Thanks,
> Pedro
>

[-- Attachment #2: Type: text/html, Size: 3335 bytes --]

Re: [edk2-devel] edk2-platforms, continuous integration, testing, and you

[Isaac Oram]

[-- Attachment #1: Type: text/plain, Size: 4495 bytes --]

I think that there shouldn’t be any difficulty to build QemuOpenBoardPkg and most of the Platforms/Intel packages (Simics and Purley are “special” and should be considered a waste of time at this time).  I know how stuart works but I assume at some point it is capable of running normal edk2 build commands.

https://github.com/tianocore/edk2-platforms/tree/master/Platform/Qemu/QemuOpenBoardPkg has some discussion of the build and execution.
Almost everything is typical except our use of command line to configure PEI and DXE, “-D PEI_ARCH=IA32 -D DXE_ARCH=X64”
build -a IA32 -a X64 -D PEI_ARCH=IA32 -D DXE_ARCH=X64 -p QemuOpenBoardPkg\QemuOpenBoardPkg.dsc
I sent a commit to get all Intel advanced feature packages building with VS2019, CLANGPDB, and GCC5, NOOPT.
build -a IA32 -a X64 -b NOOPT -p Debugging\AcpiDebugFeaturePkg\AcpiDebugFeaturePkg.dsc
build -a IA32 -a X64 -b NOOPT -p Debugging\BeepDebugFeaturePkg\BeepDebugFeaturePkg.dsc
build -a IA32 -a X64 -b NOOPT -p Debugging\PostCodeDebugFeaturePkg\PostCodeDebugFeaturePkg.dsc
build -a IA32 -a X64 -b NOOPT -p Debugging\Usb3DebugFeaturePkg\Usb3DebugFeaturePkg.dsc
build -a IA32 -a X64 -b NOOPT -p Network\NetworkFeaturePkg\NetworkFeaturePkg.dsc
build -a IA32 -a X64 -b NOOPT -p OutOfBandManagement\IpmiFeaturePkg\IpmiFeaturePkg.dsc
build -a IA32 -a X64 -b NOOPT -p OutOfBandManagement\SpcrFeaturePkg\SpcrFeaturePkg.dsc
build -a IA32 -a X64 -b NOOPT -p PowerManagement\S3FeaturePkg\S3FeaturePkg.dsc
build -a IA32 -a X64 -b NOOPT -p SystemInformation\SmbiosFeaturePkg\SmbiosFeaturePkg.dsc
build -a IA32 -a X64 -b NOOPT -p TemplateFeaturePkg\TemplateFeaturePkg.dsc
build -a IA32 -a X64 -b NOOPT -p UserInterface\LogoFeaturePkg\LogoFeaturePkg.dsc
build -a IA32 -a X64 -b NOOPT -p UserInterface\UserAuthFeaturePkg\UserAuthFeaturePkg.dsc
build -a IA32 -a X64 -b NOOPT -p UserInterface\VirtualKeyboardFeaturePkg\VirtualKeyboardFeaturePkg.dsc
build -a X64 -b NOOPT -p edk2-platforms\Features\Intel\PlatformPayloadFeaturePkg\PlatformPayloadFeaturePkg.dsc
build -a IA32 -a X64 -b NOOPT -p AdvancedFeaturePkg\AdvancedFeaturePkg.dsc
https://edk2.groups.io/g/devel/message/98210

Regards,
Isaac

From: Théo Jehl <theojehl76@gmail.com>
Sent: Thursday, January 5, 2023 3:49 PM
To: Pedro Falcato <pedro.falcato@gmail.com>
Cc: Sean Brogan <spbrogan@outlook.com>; devel@edk2.groups.io; Marvin Häuser <mhaeuser@posteo.de>; Oram, Isaac W <isaac.w.oram@intel.com>
Subject: Re: [edk2-devel] edk2-platforms, continuous integration, testing, and you

Hello,

Could your qemu open board pkg be built using stuart and setup to run tests?  More details about the goals and plans for the qemu open board pkg.

I like the test idea, however I do not know what Stuart is.
If the goal is getting QOBP to build and pass tests using github CI on edk2-platforms , it can be an interesting project.

Regards,
Théo


Le ven. 6 janv. 2023 à 00:32, Pedro Falcato <pedro.falcato@gmail.com<mailto:pedro.falcato@gmail.com>> a écrit :
On Thu, Jan 5, 2023 at 1:52 AM Sean Brogan <spbrogan@outlook.com<mailto:spbrogan@outlook.com>> wrote:

Pedro,

Thanks.  Happy to get some feedback.  I hope others also provide feedback.  :)



Regarding the Edk2 tools & CI meeting:  If we scheduled the Jan 16th meeting for Jan 17th at 8am Pacific (should be 5 pm your time) would that work?  In the meeting we have discussed that we need to rotate the time of the meetings to accommodate more world wide attendance and given the standard time would fall on a US holiday it seems like a good week to do it.  Could you make it that day?
I could make it work that day I believe, but only 2-3 hours later. Does that work for you folks?

At a minimum we could talk about your packages:

Like should ext4 really depend on redfishpkg?  More likely the library should be promoted to a more "core" package.
Should? No. I just haven't had the patience to send a patch moving the BaseUcs2Utf8Lib to somewhere more central like MdeModulePkg.

Could your qemu open board pkg be built using stuart and setup to run tests?  More details about the goals and plans for the qemu open board pkg.
Great questions. Probably? It should just work and actually be able to run tests.
Re: goals and plans, I do have a few ideas but they're all very unclear. We haven't had much community engagement wrt QemuOBP, it's definitely something that could be explored (CC Isaac and Theo, who might want to show up or chime in).

Thanks,
Pedro

[-- Attachment #2: Type: text/html, Size: 10181 bytes --]

Re: [edk2-devel] edk2-platforms, continuous integration, testing, and you

[Sean]

how about 10am pacific Jan 17th.  should be 7pm your time?

Thanks

Sean


On 1/5/2023 3:48 PM, Théo Jehl wrote:
> it work that day I believe, but only 2-3 hours later. Does that work 
> for you folks? 

Re: [edk2-devel] edk2-platforms, continuous integration, testing, and you

[Pedro Falcato]

On Fri, Jan 13, 2023 at 10:32 PM Sean Brogan <spbrogan@outlook.com> wrote:
>
> how about 10am pacific Jan 17th.  should be 7pm your time?
>
> Thanks
>
> Sean
>
Hi Sean,

Should work for me (6pm btw, GMT here).

Thanks,
Pedro

Re: [edk2-devel] edk2-platforms, continuous integration, testing, and you

[Michael D Kinney]

Hi Sean,

I moved this week's meeting to 10am pacific on Tuesday Jan 17th.

Mike


> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Pedro Falcato
> Sent: Friday, January 13, 2023 6:54 PM
> To: Sean Brogan <spbrogan@outlook.com>
> Cc: Théo Jehl <theojehl76@gmail.com>; devel@edk2.groups.io; Marvin Häuser <mhaeuser@posteo.de>; Oram, Isaac W
> <isaac.w.oram@intel.com>
> Subject: Re: [edk2-devel] edk2-platforms, continuous integration, testing, and you
> 
> On Fri, Jan 13, 2023 at 10:32 PM Sean Brogan <spbrogan@outlook.com> wrote:
> >
> > how about 10am pacific Jan 17th.  should be 7pm your time?
> >
> > Thanks
> >
> > Sean
> >
> Hi Sean,
> 
> Should work for me (6pm btw, GMT here).
> 
> Thanks,
> Pedro
> 
> 
> 
>