From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vk1-f173.google.com (mail-vk1-f173.google.com [209.85.221.173]) by mx.groups.io with SMTP id smtpd.web11.15036.1687448713908888646 for ; Thu, 22 Jun 2023 08:45:14 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@gmail.com header.s=20221208 header.b=CGGHw5dx; spf=pass (domain: gmail.com, ip: 209.85.221.173, mailfrom: pedro.falcato@gmail.com) Received: by mail-vk1-f173.google.com with SMTP id 71dfb90a1353d-4715758343aso2482947e0c.1 for ; Thu, 22 Jun 2023 08:45:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687448713; x=1690040713; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=qqcZWaS8AOqZgnmzYI8H+T29yz1JKvNCal4n33V9XSw=; b=CGGHw5dx0WdRdYoMcTmY+x1dHdxaoZ5l20BhlB/8tIdHoLcKmvYW2kX3sU2d+Jvb0u pBUy3U8BeiQJz93LZqhYQJotkqtvGgmt8xh7KB2Pu3xDEeaujrrITIVcx9G41wcTa0lY SdfvVUOhvcfYtC6qMLSii38MAyh6mRMQKN+9iMaxVRtx5VsRTKMLYShfNZIhn1DWnKNO WQ0eopKzS9hBAdsbrAHnbMGjDOAm/V5W5rnkIw7fWvmfE2nfJ6DCVhmo8E4ODw000BM3 boY/FQh63sdmhFNhloRCvfUmi8+mf8cz9S4DHKhXQncXI4ajF3AQf2q+DOwLKo3nywL6 2rFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687448713; x=1690040713; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qqcZWaS8AOqZgnmzYI8H+T29yz1JKvNCal4n33V9XSw=; b=BHhElerzbdHpKazl9lU53H6gEvZx5up01C4b2W9Yxm8xhwxeEWbvlIWF/ax0mPvkdK t4YKonQfXNi53IecF0cPVDqNqUE04b7bRE0zWiDioYmNQWGZAZEAE8GxSIWgM/HLtEj/ F+VsVI0KtNdluL0jgpdy7x66ZyOklm6klteGKkgiMLzXPakEMhtb/Z7mXaeisNX+Hj92 KgxdzVKithm9ackWUz4dw1kUfA4GjQ5mVx9LCmEfzaEhqljd7MkYgqkUwwRbUmcTXcyn gRj2lMz1KDwRdhvl6jdZpI31o+nT2Isw1Yg4Z9HMEqtjLhhvxkl7mye/buOZI1KgvrAr ZiIQ== X-Gm-Message-State: AC+VfDzNe2AB8W+uFIB0u+w9pzezFvkNTHOmbC46WALudsNF5UdIS+Dk tZ0TssdtObF8vWW0wWNNQGAJV0rOrv0q5zdmr5M= X-Google-Smtp-Source: ACHHUZ5D5hIfyID4fUVlTTBe/FWp0gKRJQoHveixvCDskyrYRRDZqT5Rq5wQAKl+2FDvwBKl/r45kD6FODzoyXPD8qY= X-Received: by 2002:a1f:5c93:0:b0:464:7682:3506 with SMTP id q141-20020a1f5c93000000b0046476823506mr8911755vkb.12.1687448712880; Thu, 22 Jun 2023 08:45:12 -0700 (PDT) MIME-Version: 1.0 References: <20230616072257.1989-1-gavin.xue@intel.com> In-Reply-To: From: "Pedro Falcato" Date: Thu, 22 Jun 2023 16:45:01 +0100 Message-ID: Subject: Re: [edk2-devel] [edk2 PATCH] MdePkg: Use same ProcessorBind symbol define for RISCV64 To: "Xue, Gavin" Cc: "devel@edk2.groups.io" , "sunilvl@ventanamicro.com" , "Warkentin, Andrei" , "Wang, Yimin" , "Sheng, Alan" , "Kinney, Michael D" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Jun 22, 2023 at 10:59=E2=80=AFAM Xue, Gavin w= rote: > > Hi Pedro, > > Thanks for your feedback. > > The sample code what I listed in last mail is from/owned by another team,= and I didn't find other special #ifndef case for RSIC-V building so far. > RISC-V is an new processor architecture in edk2 implementation, in our in= ternal BIOS code, there are many similar common code for edk2 and Windows a= pp (for simulation). > It's better if we can reuse existing code (mostly are from x86) and minim= ize modifications as much as possible. So I think use same guard name is ma= ke sense. > How about your comments? Thanks. +CC Mike K I (personally) would oppose this change. The specific include guard's name is an implementation detail that should not be relied upon by the header's consumers. In my view, your code should just get fixed. The ideas I put out should still work for any CPU arch (even if hacky; ideally, you would just set some sort of IS_EFI macro when building). Mike, any opinion on this matter? --=20 Pedro