From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) by mx.groups.io with SMTP id smtpd.web10.81286.1674756498700718316 for ; Thu, 26 Jan 2023 10:08:18 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=PbIIP4JJ; spf=pass (domain: gmail.com, ip: 209.85.215.178, mailfrom: pedro.falcato@gmail.com) Received: by mail-pg1-f178.google.com with SMTP id d10so1584079pgm.13 for ; Thu, 26 Jan 2023 10:08:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Fqh58snULkNP9HAoFGBFlkFQH3jJIXA0aqh43DTkaXo=; b=PbIIP4JJl2ustSVhfK9VBachfFado+oybfNPlJqIxuB8rAlZLwNJTPWuxXrwWGAtmQ +NpaVMbcCLQLIjAHoE6n0J8q89Hs7/yb4D8Cx2A+JLqajyBq6Eo92do18rEQaZeMaQcZ 3zivCiO26McpMFhVwJTUmB1p+j9RKiqgViPK9SOgTPyvHGyYM352lca7srw/rgJl72vB c2FNXglGnsGEd972AKvajkG035SARw3Ytam7WZ3sq8jrjwyotu5EZV5EtLXMENIyZOUi 6RtplekOVyn34xav2TRPuINlcjvP6XBjBhlswv24I7L3z4Z2JIFEyrFfnUsdpnaTH2nT bRfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Fqh58snULkNP9HAoFGBFlkFQH3jJIXA0aqh43DTkaXo=; b=QwI5boAL/x8pgCMgi3PdnuMZcyTN2g9/SuRSk5uOe53tng0aP0NAVT7KFsgLvZOQ4A 8Vi5SA0sH3oMkRshvaww3mj2NeKYj3iNDEjyJvVGIUpDMyyU0wTkNgmFf1ul3PeUxBV2 4Enmyrt/DW6ooUkvMUTLuGXWT/X1ZqHSPXylhZsQJ6oLg3al52YWkjn/pfQjqEpo4Sho d8P5gzwAWPsFanmK+OUn+a1ZEYQr2etr773XRChCQyri2ta7FKS7zc0pRXu3gL5WS1mR Fke5TyD0E0ncLU8ycdf534HUGv3t3af8JhB5oqBARfez8bdDGTKkEzMAN1rk8G95FHh+ mHyw== X-Gm-Message-State: AFqh2kpx1oBUI4ND83Q21S1ecPBMNKQwsrJ7VrEKPJiY0a1V4tOKnGk8 GPWCHS5XE4sflCujlxc2IPQt0u9ipcpa8sVkNAE= X-Google-Smtp-Source: AMrXdXtRnNivs1vFVdRlYmPoHw8kdCxfVr/M3SEC/kgwjwV244jWTnQDLsTs2uhVqRedvKCtpO20vjxcEMuGPId3z/w= X-Received: by 2002:aa7:8016:0:b0:583:63ea:f5e8 with SMTP id j22-20020aa78016000000b0058363eaf5e8mr4610962pfi.60.1674756497914; Thu, 26 Jan 2023 10:08:17 -0800 (PST) MIME-Version: 1.0 References: <20230126180653.90243-1-mhaeuser@posteo.de> In-Reply-To: <20230126180653.90243-1-mhaeuser@posteo.de> From: "Pedro Falcato" Date: Thu, 26 Jan 2023 18:08:05 +0000 Message-ID: Subject: Re: [PATCH 1/1] Ext4Pkg: Fix typos discovered by SpellCheck To: =?UTF-8?Q?Marvin_H=C3=A4user?= Cc: devel@edk2.groups.io Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Jan 26, 2023 at 6:07 PM Marvin H=C3=A4user wro= te: > > Fix typos discovered by SpellCheck, which were discovered as part of the > initial CI enablement effort. > > Cc: Pedro Falcato > Signed-off-by: Marvin H=C3=A4user > --- > Features/Ext4Pkg/Ext4Dxe/BlockMap.c | 6 +++--- > Features/Ext4Pkg/Ext4Dxe/Directory.c | 2 +- > Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.h | 16 ++++++++-------- > Features/Ext4Pkg/Ext4Dxe/Extents.c | 4 ++-- > Features/Ext4Pkg/Ext4Dxe/File.c | 2 +- > Features/Ext4Pkg/Ext4Dxe/Inode.c | 2 +- > Features/Ext4Pkg/Ext4Dxe/Superblock.c | 6 +++--- > Features/Ext4Pkg/Ext4Dxe/Symlink.c | 2 +- > 8 files changed, 20 insertions(+), 20 deletions(-) > > diff --git a/Features/Ext4Pkg/Ext4Dxe/BlockMap.c b/Features/Ext4Pkg/Ext4D= xe/BlockMap.c > index 2bc629fe9d38..8fee4476a5ac 100644 > --- a/Features/Ext4Pkg/Ext4Dxe/BlockMap.c > +++ b/Features/Ext4Pkg/Ext4Dxe/BlockMap.c > @@ -131,7 +131,7 @@ Ext4GetBlockPath ( > > /** > @brief Get an extent from a block map > - Note: Also parses file holes and creates uninitialised extents from t= hem. > + Note: Also parses file holes and creates uninitialized extents from t= hem. > > @param[in] Buffer Buffer of block pointers > @param[in] IndEntries Number of entries in this block pointer t= able > @@ -173,7 +173,7 @@ Ext4GetExtentInBlockMap ( > } > } > > - // We mark the extent as uninitialised, although there's a differenc= e between uninit > + // We mark the extent as uninitialized, although there's a differenc= e between uninit > // extents and file holes. > Extent->ee_len =3D EXT4_EXTENT_MAX_INITIALIZED + Count; > return; > @@ -206,7 +206,7 @@ Ext4GetExtentInBlockMap ( > @param[in] LogicalBlock Block number which the returned extent = must cover. > @param[out] Extent Pointer to the output buffer, where the= extent will be copied to. > > - @retval EFI_SUCCESS Retrieval was succesful. > + @retval EFI_SUCCESS Retrieval was successful. > @retval EFI_NO_MAPPING Block has no mapping. > **/ > EFI_STATUS > diff --git a/Features/Ext4Pkg/Ext4Dxe/Directory.c b/Features/Ext4Pkg/Ext4= Dxe/Directory.c > index ba781bad968c..456916453952 100644 > --- a/Features/Ext4Pkg/Ext4Dxe/Directory.c > +++ b/Features/Ext4Pkg/Ext4Dxe/Directory.c > @@ -16,7 +16,7 @@ > @param[in] Entry Pointer to a EXT4_DIR_ENTRY. > @param[out] Ucs2FileName Pointer to an array of CHAR16's, of s= ize EXT4_NAME_MAX + 1. > > - @retval EFI_SUCCESS The filename was succesfully retriev= ed and converted to UCS2. > + @retval EFI_SUCCESS The filename was successfully retrie= ved and converted to UCS2. > @retval EFI_INVALID_PARAMETER The filename is not valid UTF-8. > @retval !EFI_SUCCESS Failure. > **/ > diff --git a/Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.h b/Features/Ext4Pkg/Ext4Dx= e/Ext4Dxe.h > index 41779dad855f..f608def7c9eb 100644 > --- a/Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.h > +++ b/Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.h > @@ -155,7 +155,7 @@ Ext4UnrefDentry ( > > @param[out] Partition Partition structure to fill with filesystem > details. > - @retval EFI_SUCCESS Parsing was succesful and the partition is = a > + @retval EFI_SUCCESS Parsing was successful and the partition is= a > valid ext4 partition. > **/ > EFI_STATUS > @@ -322,7 +322,7 @@ Ext4ReadInode ( > @param[out] Buffer Pointer to the buffer. > @param[in] Offset Offset of the read. > @param[in out] Length Pointer to the length of the buffer, in= bytes. > - After a succesful read, it's updated to= the > + After a successful read, it's updated t= o the > number of read bytes. > > @return Status of the read operation. > @@ -355,7 +355,7 @@ cover. > @param[out] Extent Pointer to the output buffer, where the= extent > will be copied to. > > - @retval EFI_SUCCESS Retrieval was succesful. > + @retval EFI_SUCCESS Retrieval was successful. > @retval EFI_NO_MAPPING Block has no mapping. > **/ > EFI_STATUS > @@ -946,7 +946,7 @@ Ext4StrCmpInsensitive ( > @param[in] Entry Pointer to a EXT4_DIR_ENTRY. > @param[out] Ucs2FileName Pointer to an array of CHAR16's, of s= ize EXT4_NAME_MAX + 1. > > - @retval EFI_SUCCESS The filename was succesfully retriev= ed and converted to UCS2. > + @retval EFI_SUCCESS The filename was successfully retrie= ved and converted to UCS2. > @retval EFI_INVALID_PARAMETER The filename is not valid UTF-8. > @retval !EFI_SUCCESS Failure. > **/ > @@ -1106,7 +1106,7 @@ Ext4CalculateBlockGroupDescChecksum ( > ); > > /** > - Verifies the existance of a particular RO compat feature set. > + Verifies the existence of a particular RO compat feature set. > @param[in] Partition Pointer to the opened EXT4 partit= ion. > @param[in] RoCompatFeatureSet Feature set to test. > > @@ -1116,7 +1116,7 @@ Ext4CalculateBlockGroupDescChecksum ( > ((Partition->FeaturesRoCompat & RoCompatFeatureSet) =3D=3D RoCompatFea= tureSet) > > /** > - Verifies the existance of a particular compat feature set. > + Verifies the existence of a particular compat feature set. > @param[in] Partition Pointer to the opened EXT4 partit= ion. > @param[in] CompatFeatureSet Feature set to test. > > @@ -1126,7 +1126,7 @@ Ext4CalculateBlockGroupDescChecksum ( > ((Partition->FeaturesCompat & CompatFeatureSet) =3D=3D CompatFeatureSe= t) > > /** > - Verifies the existance of a particular compat feature set. > + Verifies the existence of a particular compat feature set. > @param[in] Partition Pointer to the opened EXT4 partit= ion. > @param[in] IncompatFeatureSet Feature set to test. > > @@ -1217,7 +1217,7 @@ Ext4GetExtentLength ( > @param[in] LogicalBlock Block number which the returned extent = must cover. > @param[out] Extent Pointer to the output buffer, where the= extent will be copied to. > > - @retval EFI_SUCCESS Retrieval was succesful. > + @retval EFI_SUCCESS Retrieval was successful. > @retval EFI_NO_MAPPING Block has no mapping. > **/ > EFI_STATUS > diff --git a/Features/Ext4Pkg/Ext4Dxe/Extents.c b/Features/Ext4Pkg/Ext4Dx= e/Extents.c > index f1964426d276..e1001d0a4292 100644 > --- a/Features/Ext4Pkg/Ext4Dxe/Extents.c > +++ b/Features/Ext4Pkg/Ext4Dxe/Extents.c > @@ -219,7 +219,7 @@ Ext4ExtentIdxLeafBlock ( > @param[in] LogicalBlock Block number which the returned extent = must cover. > @param[out] Extent Pointer to the output buffer, where the= extent will be copied to. > > - @retval EFI_SUCCESS Retrieval was succesful. > + @retval EFI_SUCCESS Retrieval was successful. > @retval EFI_NO_MAPPING Block has no mapping. > **/ > EFI_STATUS > @@ -615,7 +615,7 @@ Ext4GetExtentLength ( > IN CONST EXT4_EXTENT *Extent > ) > { > - // If it's an unintialized extent, the true length is ee_len - 2^15 > + // If it's an uninitialized extent, the true length is ee_len - 2^15 > if (EXT4_EXTENT_IS_UNINITIALIZED (Extent)) { > return Extent->ee_len - EXT4_EXTENT_MAX_INITIALIZED; > } > diff --git a/Features/Ext4Pkg/Ext4Dxe/File.c b/Features/Ext4Pkg/Ext4Dxe/F= ile.c > index 04198a53bfc0..8dfe324255f4 100644 > --- a/Features/Ext4Pkg/Ext4Dxe/File.c > +++ b/Features/Ext4Pkg/Ext4Dxe/File.c > @@ -105,7 +105,7 @@ Ext4IsLastPathSegment ( > @param[in out] File Pointer to the file we're opening. > @param[in] OpenMode Mode in which to open the file. > > - @return True if the open was succesful, false if we don't h= ave > + @return True if the open was successful, false if we don't = have > enough permissions. > **/ > STATIC > diff --git a/Features/Ext4Pkg/Ext4Dxe/Inode.c b/Features/Ext4Pkg/Ext4Dxe/= Inode.c > index 5ccb4d2bfc42..e44b5638599f 100644 > --- a/Features/Ext4Pkg/Ext4Dxe/Inode.c > +++ b/Features/Ext4Pkg/Ext4Dxe/Inode.c > @@ -76,7 +76,7 @@ Ext4CalculateInodeChecksum ( > @param[out] Buffer Pointer to the buffer. > @param[in] Offset Offset of the read. > @param[in out] Length Pointer to the length of the buffer, in= bytes. > - After a succesful read, it's updated to= the number of read bytes. > + After a successful read, it's updated t= o the number of read bytes. > > @return Status of the read operation. > **/ > diff --git a/Features/Ext4Pkg/Ext4Dxe/Superblock.c b/Features/Ext4Pkg/Ext= 4Dxe/Superblock.c > index edee051c41e8..5a3c7f478187 100644 > --- a/Features/Ext4Pkg/Ext4Dxe/Superblock.c > +++ b/Features/Ext4Pkg/Ext4Dxe/Superblock.c > @@ -151,7 +151,7 @@ Ext4VerifySuperblockChecksum ( > Opens and parses the superblock. > > @param[out] Partition Partition structure to fill with filesystem= details. > - @retval EFI_SUCCESS Parsing was succesful and the partition is = a > + @retval EFI_SUCCESS Parsing was successful and the partition is= a > valid ext4 partition. > **/ > EFI_STATUS > @@ -203,7 +203,7 @@ Ext4OpenSuperblock ( > > // Now, check for the feature set of the filesystem > // It's essential to check for this to avoid filesystem corruption and= to avoid > - // accidentally opening an ext2/3/4 filesystem we don't understand, wh= ich would be disasterous. > + // accidentally opening an ext2/3/4 filesystem we don't understand, wh= ich would be disastrous. > > if (Partition->FeaturesIncompat & ~gSupportedIncompatFeat) { > DEBUG (( > @@ -312,7 +312,7 @@ Ext4OpenSuperblock ( > return EFI_OUT_OF_RESOURCES; > } > > - // Note that the cast below is completely safe, because EXT4_FILE is a= specialisation of EFI_FILE_PROTOCOL > + // Note that the cast below is completely safe, because EXT4_FILE is a= specialization of EFI_FILE_PROTOCOL > Status =3D Ext4OpenVolume (&Partition->Interface, (EFI_FILE_PROTOCOL *= *)&Partition->Root); > > if (EFI_ERROR (Status)) { > diff --git a/Features/Ext4Pkg/Ext4Dxe/Symlink.c b/Features/Ext4Pkg/Ext4Dx= e/Symlink.c > index 0905417ffb88..19b357ac6ba0 100644 > --- a/Features/Ext4Pkg/Ext4Dxe/Symlink.c > +++ b/Features/Ext4Pkg/Ext4Dxe/Symlink.c > @@ -201,7 +201,7 @@ Ext4ReadSymlink ( > CHAR16 *Needle; > > // > - // Assume that we alread read Inode via Ext4ReadInode > + // Assume that we already read Inode via Ext4ReadInode > // Skip reading, just check encryption flag > // > if ((File->Inode->i_flags & EXT4_ENCRYPT_FL) !=3D 0) { > -- > 2.39.1 > Reviewed-by: Pedro Falcato --=20 Pedro