From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ua1-f46.google.com (mail-ua1-f46.google.com [209.85.222.46]) by mx.groups.io with SMTP id smtpd.web12.577.1654032782286220774 for ; Tue, 31 May 2022 14:33:02 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=f8uuE9iI; spf=pass (domain: gmail.com, ip: 209.85.222.46, mailfrom: pedro.falcato@gmail.com) Received: by mail-ua1-f46.google.com with SMTP id k13so5252835uad.0 for ; Tue, 31 May 2022 14:33:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gZriPJi+l6OoxsZ7fx7AdbmzJpAEPPe3pNUQimtZeIw=; b=f8uuE9iIQdhq1aLWu49Rav2R1YZ0kIfPgRFQGt5fpQgRmH94tr8KjKxKdP+FX5twiN UEFBrMXjyxjJ6bsjH7LWc86BQJB3f4Z1RCht7etFbx/B5PIPjRtndTe+3kMXpnfyGiSU 0mkdlPYWnftnT8/imu8MFMjzRdWdb9dw75ZJln2hueOnOXyfL0PCOe+vqMLvaRkNgExe vIdgmH7vJaLbdbiwfOaspWuhG8hfqPkIjvj+Tbdo1tOPh5q1LuOrihcC6X2HWSu6vSxB VHW/oEjTGdfvI7lLB4uJRkJJfjRHBpQR3+JS/vyrsjsCjNUijxJhGwZ+oX/xNm2PSIPF MkQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gZriPJi+l6OoxsZ7fx7AdbmzJpAEPPe3pNUQimtZeIw=; b=jmXuDSJjrBaQ7wYFZpI1+7NsTw6/3Dh/0HBS5YgtutdQzB2Pm2095QXw0ANs3Wand2 Uew5cf1ibSrEwsTNbc4lmp23SJj26MvX5NeRhopVqCbRmvAil/6LvTcaxEeLa5iS3TWH /4LnxdRzZpprVyYzqRSsV0D+imn/uQtmSjTpfx+yy3ukX9pYHQ0ztxEnZqsq/Miz8pQe rZxgaXrcGAVdBjibdw8hh6CPE1L8YBwHfEODwvN4q66qqJHr2CvkuA9oCILVzbUoHISZ j2oTlh5eNddOIFA78Fz+YwZ2dbcCFAGF58NJ7leaCzbUKZrFr/eV3Tz0v3VONxKlUo3t dSQg== X-Gm-Message-State: AOAM532+cakwqfLs0APi6JpbezMVMIR7w8f+YzuR4fMxQaayc3bKIn0/ N8wtw1KsPb+unOmrqu02x51yoEjuSDpCh+GoFDT1yDuqKJU= X-Google-Smtp-Source: ABdhPJyq69m9kJCDpBorAnP3sdjEYjTFgKC8Sg9Kqs24f/Tbh3XTpWb8Szjl9f2A1akfq1xR9hu5rrqAHbe+Qtpq/HU= X-Received: by 2002:ab0:4a1c:0:b0:368:a05b:ef41 with SMTP id q28-20020ab04a1c000000b00368a05bef41mr22320428uae.40.1654032781172; Tue, 31 May 2022 14:33:01 -0700 (PDT) MIME-Version: 1.0 References: <20220407220146.149580-1-pedro.falcato@gmail.com> <16E9330A7A87074F.18109@groups.io> <16EE1DD8FA9A45F3.9448@groups.io> In-Reply-To: <16EE1DD8FA9A45F3.9448@groups.io> From: "Pedro Falcato" Date: Tue, 31 May 2022 22:32:50 +0100 Message-ID: Subject: Re: [edk2-devel] [PATCH edk2-platforms 0/3] Ext4Pkg: Add ext2/3 support and move crc16/32c to BaseLib To: edk2-devel-groups-io , Pedro Falcato Cc: Leif Lindholm , Michael D Kinney , Liming Gao , Zhiguang Liu Content-Type: multipart/alternative; boundary="0000000000005e645605e0558486" --0000000000005e645605e0558486 Content-Type: text/plain; charset="UTF-8" Ping. Please review now that the stable freeze is over. On Wed, May 11, 2022 at 6:42 PM Pedro Falcato via groups.io wrote: > Ping. Could someone review these patches? > > On Mon, Apr 25, 2022 at 6:14 PM Pedro Falcato via groups.io > wrote: > >> Ping. If someone could take a look, it would be much appreciated. >> >> On Thu, Apr 7, 2022 at 11:01 PM Pedro Falcato >> wrote: >> >>> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3745 >>> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3871 >>> >>> Hi all, >>> >>> This patch-set attempts to address two open feature requests for Ext4Pkg >>> by adding ext2/3 support (id 3745) and moving crc16-ansi/crc32c to >>> BaseLib (id 3871). >>> >>> The previous patch-set regarding 3871 attempted to merge the different >>> crc16 implementations >>> but failed because, contrary to what I thought, there are many, many >>> different CRC16s which >>> are all slightly different. This one (plus the separate edk2 patch) >>> attempts to just merge >>> CRC16-ANSI (confusingly, also known as CRC16) into BaseLib. >>> >>> Since this patch set grew to be considerably different from the >>> original, I didn't mark it >>> as v2 but rather a separate, new patch-set. >>> >>> CC'ing the edk2-platforms stewards (as I cannot review my own code) and >>> the CC's of the MdePkg >>> patch. >>> >>> Cc: Leif Lindholm >>> Cc: Michael D Kinney >>> Cc: Liming Gao >>> Cc: Zhiguang Liu >>> >>> Pedro Falcato (3): >>> Ext4Pkg: Replace the CRC implementations with BaseLib >>> Ext4Pkg: Format using uncrustify >>> Ext4Pkg: Add ext2/3 support >>> >>> Features/Ext4Pkg/Ext4Dxe/BlockGroup.c | 10 +- >>> Features/Ext4Pkg/Ext4Dxe/BlockMap.c | 279 +++++++++++++++++ >>> Features/Ext4Pkg/Ext4Dxe/Collation.c | 4 +- >>> Features/Ext4Pkg/Ext4Dxe/Crc16.c | 75 ----- >>> Features/Ext4Pkg/Ext4Dxe/Crc32c.c | 84 ------ >>> Features/Ext4Pkg/Ext4Dxe/Directory.c | 13 +- >>> Features/Ext4Pkg/Ext4Dxe/DiskUtil.c | 6 +- >>> Features/Ext4Pkg/Ext4Dxe/Ext4Disk.h | 30 +- >>> Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.c | 95 +++--- >>> Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.h | 417 ++++++++++++++------------ >>> Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.inf | 3 +- >>> Features/Ext4Pkg/Ext4Dxe/Extents.c | 27 +- >>> Features/Ext4Pkg/Ext4Dxe/File.c | 19 +- >>> Features/Ext4Pkg/Ext4Dxe/Inode.c | 33 +- >>> Features/Ext4Pkg/Ext4Dxe/Partition.c | 12 +- >>> Features/Ext4Pkg/Ext4Dxe/Superblock.c | 20 +- >>> 16 files changed, 640 insertions(+), 487 deletions(-) >>> create mode 100644 Features/Ext4Pkg/Ext4Dxe/BlockMap.c >>> delete mode 100644 Features/Ext4Pkg/Ext4Dxe/Crc16.c >>> delete mode 100644 Features/Ext4Pkg/Ext4Dxe/Crc32c.c >>> >>> -- >>> 2.35.1 >>> >>> >> >> -- >> Pedro Falcato >> >> > > -- > Pedro Falcato > > > -- Pedro Falcato --0000000000005e645605e0558486 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Ping. Please review now that the stable freeze is over.

On Wed, May 11, 2022 at 6:42 PM Pedro Falcato via groups.io <pedro.falcato=3Dgmail.com@groups.io> wrote:
Ping. Could someone review these pat= ches?

On Mon, Apr 25, 2022 at 6:14 PM Pedro Falcato via groups.io <pedro.falcato=3Dgmail.com@groups.io> = wrote:
Ping. If someone could take a look, it would be much appreciated.<= /div>
O= n Thu, Apr 7, 2022 at 11:01 PM Pedro Falcato <pedro.falcato@gmail.com> wrote:
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3745 BZ: https://bugzilla.tianocore.org/show_bug.c= gi?id=3D3871

Hi all,

This patch-set attempts to address two open feature requests for Ext4Pkg by adding ext2/3 support (id 3745) and moving crc16-ansi/crc32c to BaseLib = (id 3871).

The previous patch-set regarding 3871 attempted to merge the different crc1= 6 implementations
but failed because, contrary to what I thought, there are many, many differ= ent CRC16s which
are all slightly different. This one (plus the separate edk2 patch) attempt= s to just merge
CRC16-ANSI (confusingly, also known as CRC16) into BaseLib.

Since this patch set grew to be considerably different from the original, I= didn't mark it
as v2 but rather a separate, new patch-set.

CC'ing the edk2-platforms stewards (as I cannot review my own code) and= the CC's of the MdePkg
patch.

Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Zhiguang Liu <zhiguang.liu@intel.com>

Pedro Falcato (3):
=C2=A0 Ext4Pkg: Replace the CRC implementations with BaseLib
=C2=A0 Ext4Pkg: Format using uncrustify
=C2=A0 Ext4Pkg: Add ext2/3 support

=C2=A0Features/Ext4Pkg/Ext4Dxe/BlockGroup.c |=C2=A0 10 +-
=C2=A0Features/Ext4Pkg/Ext4Dxe/BlockMap.c=C2=A0 =C2=A0| 279 +++++++++++++++= ++
=C2=A0Features/Ext4Pkg/Ext4Dxe/Collation.c=C2=A0 |=C2=A0 =C2=A04 +-
=C2=A0Features/Ext4Pkg/Ext4Dxe/Crc16.c=C2=A0 =C2=A0 =C2=A0 |=C2=A0 75 -----=
=C2=A0Features/Ext4Pkg/Ext4Dxe/Crc32c.c=C2=A0 =C2=A0 =C2=A0|=C2=A0 84 -----= -
=C2=A0Features/Ext4Pkg/Ext4Dxe/Directory.c=C2=A0 |=C2=A0 13 +-
=C2=A0Features/Ext4Pkg/Ext4Dxe/DiskUtil.c=C2=A0 =C2=A0|=C2=A0 =C2=A06 +- =C2=A0Features/Ext4Pkg/Ext4Dxe/Ext4Disk.h=C2=A0 =C2=A0|=C2=A0 30 +-
=C2=A0Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.c=C2=A0 =C2=A0 |=C2=A0 95 +++---
=C2=A0Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.h=C2=A0 =C2=A0 | 417 ++++++++++++++-= -----------
=C2=A0Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.inf=C2=A0 |=C2=A0 =C2=A03 +-
=C2=A0Features/Ext4Pkg/Ext4Dxe/Extents.c=C2=A0 =C2=A0 |=C2=A0 27 +-
=C2=A0Features/Ext4Pkg/Ext4Dxe/File.c=C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 19 = +-
=C2=A0Features/Ext4Pkg/Ext4Dxe/Inode.c=C2=A0 =C2=A0 =C2=A0 |=C2=A0 33 +- =C2=A0Features/Ext4Pkg/Ext4Dxe/Partition.c=C2=A0 |=C2=A0 12 +-
=C2=A0Features/Ext4Pkg/Ext4Dxe/Superblock.c |=C2=A0 20 +-
=C2=A016 files changed, 640 insertions(+), 487 deletions(-)
=C2=A0create mode 100644 Features/Ext4Pkg/Ext4Dxe/BlockMap.c
=C2=A0delete mode 100644 Features/Ext4Pkg/Ext4Dxe/Crc16.c
=C2=A0delete mode 100644 Features/Ext4Pkg/Ext4Dxe/Crc32c.c

--
2.35.1



--
Pedro Falcato
=20



--
Pedro Falcato
=20



--
Pedro Falcato
--0000000000005e645605e0558486--