From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id C5D47D80141 for ; Thu, 16 Nov 2023 08:29:41 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=1HbdgPK7cNRIiElgUWWtNFS3r4Px/qyx5E0TE5MOU9Y=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20140610; t=1700123380; v=1; b=WGf4iThvc+Ru4pjwcxcr9e9cyyINJIamjRnzSkrc8XfdBm9C4rI4KrS6BAQcQHgfYzHS8vCI xd/bF6qzB2Iigx8TmYZdSlbkzpyHaQjaEg7iGHxgKfrj0NEXkuTKNyjus5+yoLw9el05nKVLUI2 lkGVdslXfeV3o+jldxUX9d7w= X-Received: by 127.0.0.2 with SMTP id K3jvYY7687511xvXvbKvaD0w; Thu, 16 Nov 2023 00:29:40 -0800 X-Received: from mail-ua1-f48.google.com (mail-ua1-f48.google.com [209.85.222.48]) by mx.groups.io with SMTP id smtpd.web11.2791.1700123379434204263 for ; Thu, 16 Nov 2023 00:29:39 -0800 X-Received: by mail-ua1-f48.google.com with SMTP id a1e0cc1a2514c-7b9dc928868so191676241.0 for ; Thu, 16 Nov 2023 00:29:39 -0800 (PST) X-Gm-Message-State: CO5iByhtKdNy4mNyDZe9XK4bx7686176AA= X-Google-Smtp-Source: AGHT+IFESjMBz9yn88hE7nV/VU+5tJIIPFy7dDgEdkQ0b33Ntq2/9U4DjuNH/TpTfrZXR8whWXtRMFQ0mpUsK9ovaKM= X-Received: by 2002:a05:6122:311f:b0:49d:9916:5740 with SMTP id cg31-20020a056122311f00b0049d99165740mr11258963vkb.9.1700123378509; Thu, 16 Nov 2023 00:29:38 -0800 (PST) MIME-Version: 1.0 References: <0107c96b-849a-db48-194b-1a4c1f3b0c78@redhat.com> <23dd696a-52a1-4c26-bfb6-5b5587325c42@linux.microsoft.com> <30e9b11c-ab39-4266-8981-5242542b625d@bsdio.com> In-Reply-To: From: "Pedro Falcato" Date: Thu, 16 Nov 2023 08:29:28 +0000 Message-ID: Subject: Re: [edk2-devel] edk2 uncrustify update (73.0.8)? To: Laszlo Ersek Cc: Rebecca Cran , devel@edk2.groups.io, mikuback@linux.microsoft.com, Michael Kinney , Andrew Fish , Marcin Juszkiewicz , "Leif Lindholm (Quic)" Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pedro.falcato@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=WGf4iThv; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none) On Tue, Nov 14, 2023 at 3:01=E2=80=AFPM Laszlo Ersek wr= ote: > > On 11/13/23 22:33, Pedro Falcato wrote: > > On Mon, Nov 13, 2023 at 8:37=E2=80=AFPM Rebecca Cran wrote: > >> > >> On 11/13/2023 1:08 PM, Michael Kubacki wrote: > >>> Yes. I just did it. It is relatively minor and impacts expected code > >>> areas. > >>> > >>> https://github.com/tianocore/edk2/pull/5043/files > >> > >> > >> Could you update .git-blame-ignore-revs please? > > > > You can't do that until the merge is done, since we use > > rebase-and-merge for tianocore (and rebases do not keep stable commit > > hashes). > > But I would plead that this should not get merged in general :/ > Laszlo! Sorry for the delay. > Seeing the cumulative diff in that PR, do you have specific > counter-arguments? Well, my counter-argument is that formatting is becoming a topic of its own. I used to be very pro-formatter but if this leads to either 1) eyesore or 2) weird churn every now and then, I feel like we should reconsider the current approach. I feel like all formatting (manual or automated) is fine as long as it's: 1) Visually consistent with the codebase's style 2) Not horrendous to look at and switching back and forth because 'magic indentation tool' says so just seems silly to me. > > The diff is trivial, IMO. You mentioned "error prone" and "much churn", > which are very valid concerns, but they don't seem to apply here. We can > review a diff of this size (especially if it's split up on Pkg > boundaries), and the github view indicates the change is only in > whitespace amount. > > The change in > "OvmfPkg/IncompatiblePciDeviceSupportDxe/IncompatiblePciDeviceSupport.c" > is a net win; the current formatting is really distracting. > > Furthermore, this diff actually highlights some inexplicable syntax in > "EmulatorPkg/FvbServicesRuntimeDxe/FvbInfo.c": those backslashes (not > parts of any macro definition) are an eyesore. They should be fixed > regardless of re-uncrustification. > > The version N vs. N+1 concern shouldn't be one; the authoritative > version is what the YAML file in edk2 says. Well, I fear it's not that simple. EDK2's uncrustify has historically been a PITA, I've had to convince people to give it a try, I myself don't even know how I installed it (IIRC, some weird random combination of unzip + the NuGet...). Getting everyone on the same version would already be hard even if the software was easy to install. --=20 Pedro -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111304): https://edk2.groups.io/g/devel/message/111304 Mute This Topic: https://groups.io/mt/102559740/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-