From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 89226D8081E for ; Thu, 2 May 2024 17:51:09 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=cDID0Un22iVKDMWDgPaf4StPJur0iy5DVmrl+MjgqYk=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20240206; t=1714672268; v=1; b=edec+dyub0MOPduhEK65FYT1/xpSZkQw39kOl4x5gqkuw/nxOkNMEf3uQwXXkPXYxOU3grOJ m5bem8qND/QerODOTdiqPo0tpUuEvJo7EopCMRkkTBNhf4aiSUSP5VOxAsTEYwbBsFz9+n74quv v4zwVsSy1D1tPVIyoYy3ncgbu5DBmx5Cq4ow6cVI9BgGMe0A6PJfhpcLVRRbxEn/umeLjIvBh9B gN396XjsFIvB0nkTMCtM2dGwFD9GTOOltdzjBFz3DB+fJ7r6QMp6pDmCSXPPHupi/HweLVwWSQd /PX/PrZ8FgQ6ru5PgMbZi90gZ9lvriuoyvQs7mwhti/GQ== X-Received: by 127.0.0.2 with SMTP id O4HyYY7687511x6jkYIIBfWd; Thu, 02 May 2024 10:51:08 -0700 X-Received: from mail-ua1-f49.google.com (mail-ua1-f49.google.com [209.85.222.49]) by mx.groups.io with SMTP id smtpd.web10.1279.1714672266904018362 for ; Thu, 02 May 2024 10:51:07 -0700 X-Received: by mail-ua1-f49.google.com with SMTP id a1e0cc1a2514c-7ebe09eb289so2122121241.2; Thu, 02 May 2024 10:51:06 -0700 (PDT) X-Gm-Message-State: ZVsL5hI0sU4IDcHtRAI2glmlx7686176AA= X-Google-Smtp-Source: AGHT+IGVAqyUsF3m+tMvviulikNzyCHmhJVgSF6Z+7hSrCcamJ/zRijdE7b3sWcK5g57MxaxEKO7tSznIaavMrJLDlM= X-Received: by 2002:a05:6122:2212:b0:4d4:2fc1:b252 with SMTP id bb18-20020a056122221200b004d42fc1b252mr510163vkb.6.1714672265698; Thu, 02 May 2024 10:51:05 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: "Pedro Falcato" Date: Thu, 2 May 2024 18:50:54 +0100 Message-ID: Subject: Re: [edk2-devel] Proposal to switch TianoCore Code Review from email to GitHub Pull Requests on 5-24-2024 To: devel@edk2.groups.io, michael.d.kinney@intel.com Cc: "rfc@edk2.groups.io" , Leif Lindholm , "Andrew Fish (afish@apple.com)" Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Thu, 02 May 2024 10:51:07 -0700 Resent-From: pedro.falcato@gmail.com Reply-To: devel@edk2.groups.io,pedro.falcato@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=edec+dyu; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none) On Wed, May 1, 2024 at 6:44=E2=80=AFPM Michael D Kinney via groups.io wrote: > > Hello, > > I would like to propose that TianoCore move all code review from email > based code reviews to GitHub Pull Requests based code reviews. > > The proposed date to switch would be immediately after the next stable > tag which is currently scheduled for May 24, 2024. > > Updates to the following Wiki page would be required to describe the > required process when using GitHub Pull Requests for all code review > related activity. > > https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Developm= ent-Process > > A couple examples of the changes that would need to be documented are: > > * All contributors, maintainers, and reviewers must have GitHub IDs. > * The commit message would no longer require Cc:, Reviewed-by:, Acked-by: > or Tested-by: tags. The only required tag would be Signed-off-by. I'd just like to note that losing the CC:, Reviewed-by:, etc is a big loss. Gerrit auto-adds Rb's, github PR's do not (I'd guess there's a way to pull that off with github actions, but I haven't looked). It'll be a mess if I have to go through online GH PR backlogs just to find who to CC/add-to-review. It kills the decentralized bit off of git too :) > * The Pull Request submitter is required to invite the required > maintainers and reviewers to the pull request. This is the same > set of maintainers and reviewers that are required to be listed in > Cc: tags in today's process. > * Maintainers are responsible for verifying that all conversations in > the code review are resolved and that all review approvals from the > required set of maintainers are present before setting the 'push' label= . > > > Please provide feedback > 1) If you are not in favor of this change. It is sad that we're moving to PRs after I finally got a nice and sane(ish!) email workflow (openfw.io + b4). Otherwise, no objections, it's better than edk2.git's half-email half-PR frankenprocess. I'd guess this change only encompasses edk2.git? How about the other repos? Any timeline for those? --=20 Pedro -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118538): https://edk2.groups.io/g/devel/message/118538 Mute This Topic: https://groups.io/mt/105847510/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-