From: "Pedro Falcato" <pedro.falcato@gmail.com>
To: edk2-devel-groups-io <devel@edk2.groups.io>
Cc: Bob Feng <bob.c.feng@intel.com>,
Liming Gao <gaoliming@byosoft.com.cn>,
Yuwei Chen <yuwei.chen@intel.com>
Subject: Re: [PATCH 1/1] BaseTools: Update brotli to the latest upstream commit
Date: Wed, 1 Dec 2021 00:38:49 +0000 [thread overview]
Message-ID: <CAKbZUD3urh-XiD0RBA114cJ9kXC3Cv2Kq9H4YkPKoP_jT0dRgg@mail.gmail.com> (raw)
In-Reply-To: <20211029022211.381-1-pedro.falcato@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 3850 bytes --]
Hi!
It's been over a month and it would be great if you could take a look at
this, at least from a usability POV as more and more distros/operating
systems upgrade their compilers to GCC 11.
Thanks,
Pedro
On Fri, Oct 29, 2021 at 3:22 AM Pedro Falcato <pedro.falcato@gmail.com>
wrote:
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3417
>
> This updates BaseTools's brotli submodule to the latest upstream,
> which fixes GCC 11's issue building BaseTools.
>
> Cc: Bob Feng <bob.c.feng@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Yuwei Chen <yuwei.chen@intel.com>
> Signed-off-by: Pedro Falcato <pedro.falcato@gmail.com>
> ---
> BaseTools/Source/C/BrotliCompress/GNUmakefile | 7 +++++++
> BaseTools/Source/C/BrotliCompress/Makefile | 12 +++++++++++-
> BaseTools/Source/C/BrotliCompress/brotli | 2 +-
> 3 files changed, 19 insertions(+), 2 deletions(-)
>
> diff --git a/BaseTools/Source/C/BrotliCompress/GNUmakefile
> b/BaseTools/Source/C/BrotliCompress/GNUmakefile
> index b150e5dd2bb9..79d7c405069d 100644
> --- a/BaseTools/Source/C/BrotliCompress/GNUmakefile
> +++ b/BaseTools/Source/C/BrotliCompress/GNUmakefile
> @@ -10,7 +10,11 @@ APPNAME = BrotliCompress
>
> OBJECTS = \
> BrotliCompress.o \
> + brotli/c/common/constants.o \
> + brotli/c/common/context.o \
> brotli/c/common/dictionary.o \
> + brotli/c/common/platform.o \
> + brotli/c/common/shared_dictionary.o \
> brotli/c/common/transform.o \
> brotli/c/dec/bit_reader.o \
> brotli/c/dec/decode.o \
> @@ -22,12 +26,15 @@ OBJECTS = \
> brotli/c/enc/block_splitter.o \
> brotli/c/enc/brotli_bit_stream.o \
> brotli/c/enc/cluster.o \
> + brotli/c/enc/command.o \
> + brotli/c/enc/compound_dictionary.o \
> brotli/c/enc/compress_fragment.o \
> brotli/c/enc/compress_fragment_two_pass.o \
> brotli/c/enc/dictionary_hash.o \
> brotli/c/enc/encode.o \
> brotli/c/enc/encoder_dict.o \
> brotli/c/enc/entropy_encode.o \
> + brotli/c/enc/fast_log.o \
> brotli/c/enc/histogram.o \
> brotli/c/enc/literal_cost.o \
> brotli/c/enc/memory.o \
> diff --git a/BaseTools/Source/C/BrotliCompress/Makefile
> b/BaseTools/Source/C/BrotliCompress/Makefile
> index 038d1ec24226..0ed39d4b5a2c 100644
> --- a/BaseTools/Source/C/BrotliCompress/Makefile
> +++ b/BaseTools/Source/C/BrotliCompress/Makefile
> @@ -13,7 +13,14 @@ APPNAME = BrotliCompress
>
> #LIBS = $(LIB_PATH)\Common.lib
>
> -COMMON_OBJ = brotli\c\common\dictionary.obj brotli\c\common\transform.obj
> +COMMON_OBJ = \
> + brotli\c\common\constants.obj \
> + brotli\c\common\context.obj \
> + brotli\c\common\dictionary.obj \
> + brotli\c\common\platform.obj \
> + brotli\c\common\shared_dictionary.obj \
> + brotli\c\common\transform.obj
> +
> DEC_OBJ = \
> brotli\c\dec\bit_reader.obj \
> brotli\c\dec\decode.obj \
> @@ -26,12 +33,15 @@ ENC_OBJ = \
> brotli\c\enc\block_splitter.obj \
> brotli\c\enc\brotli_bit_stream.obj \
> brotli\c\enc\cluster.obj \
> + brotli\c\enc\command.obj \
> + brotli\c\enc\compound_dictionary.obj \
> brotli\c\enc\compress_fragment.obj \
> brotli\c\enc\compress_fragment_two_pass.obj \
> brotli\c\enc\dictionary_hash.obj \
> brotli\c\enc\encode.obj \
> brotli\c\enc\encoder_dict.obj \
> brotli\c\enc\entropy_encode.obj \
> + brotli\c\enc\fast_log.obj \
> brotli\c\enc\histogram.obj \
> brotli\c\enc\literal_cost.obj \
> brotli\c\enc\memory.obj \
> diff --git a/BaseTools/Source/C/BrotliCompress/brotli
> b/BaseTools/Source/C/BrotliCompress/brotli
> index 666c3280cc11..62662f87cdd9 160000
> --- a/BaseTools/Source/C/BrotliCompress/brotli
> +++ b/BaseTools/Source/C/BrotliCompress/brotli
> @@ -1 +1 @@
> -Subproject commit 666c3280cc11dc433c303d79a83d4ffbdd12cc8d
> +Subproject commit 62662f87cdd96deda90ac817de94e3c4af75226a
> --
> 2.33.1.windows.1
>
>
--
Pedro Falcato
[-- Attachment #2: Type: text/html, Size: 5038 bytes --]
next prev parent reply other threads:[~2021-12-01 0:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-29 2:22 [PATCH 1/1] BaseTools: Update brotli to the latest upstream commit Pedro Falcato
2021-12-01 0:38 ` Pedro Falcato [this message]
2021-12-01 1:51 ` 回复: " gaoliming
2021-12-01 3:07 ` [edk2-devel] " Pedro Falcato
2021-12-03 2:10 ` 回复: " gaoliming
2021-12-02 14:41 ` [edk2-devel] " Ross Burton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKbZUD3urh-XiD0RBA114cJ9kXC3Cv2Kq9H4YkPKoP_jT0dRgg@mail.gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox