From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::141; helo=mail-it1-x141.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it1-x141.google.com (mail-it1-x141.google.com [IPv6:2607:f8b0:4864:20::141]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 245DB2194EB78 for ; Fri, 15 Feb 2019 02:49:26 -0800 (PST) Received: by mail-it1-x141.google.com with SMTP id i2so22240547ite.5 for ; Fri, 15 Feb 2019 02:49:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=FCqxb4doEetCJTUTWGME03GjO0+iGCcEor5pVlKAoUw=; b=rbw7Irpdm/dQHllI3DtBcNwJmyU0Kij11i2LnAwSu5yOMVswk/bJb1ob2AFimeTnMX b749472amjZMb5ICvdZjBTFvrgU0dmx7ZfQmyDJEkvTdWG6yWAJAA6pwFuKdm32wjSqR PRxQAD39EknU9k7oA2pM6hhY/3/km3QTOpcBqnly36AeBBA4uS1a6zfRQakcde1DfS2r qQLv7XlP6NTSNkWeM5lESCItZrMJubKq48TnrVPJsmd+aD9VXBKmoVtUahgXcqAx1ron 68HkMpggs6Iue6tQb39PyQu66uPK/Qpv8zgKZhnTfm+9OdSgSQb1o2nWLmtvRL/qaRwZ 4YRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FCqxb4doEetCJTUTWGME03GjO0+iGCcEor5pVlKAoUw=; b=rUtK/57T3Dlf4l2dA5O30BOH3IkeU8G5E4ybMpbq7HKq4btSImrrRuPdRs2d2ikSO9 gGX+7DFvwMoDUeXUwxs2UwC7FDgVYO36TNtUnJik8/qKmK5T7Ip6vhYrBtEwk5FlwnMK SAgnyXdqmNq+0Q6oB37W++KxgJAcJI2Z/zIxN3kywLMmdFqMp5d6Cszj6pw7bqTnTkEI 7087GYf1ZsovQzGJopzLGaymOioa0dBraFRD35Kmpt6gbYFgBnNxMI5ubnmA/zEFQyea Wvp3SKOgI+3ZmiVl+MOqsam0hA2vN1tO4l6uTfs6H9CsUwMm/+/sNQs+fsDNLzM9p7F7 I0/A== X-Gm-Message-State: AHQUAuYQnuDmYywDROUfk1UupqE+5ZmMnZrmK7u2X5kGr9Qo1uTq+cHo 206CL9pIr+LTUQCWkGaEj06CE+dX8LFKvIvY/jTfvA== X-Google-Smtp-Source: AHgI3IYIKwT3EJhX/cA1wPe+CBMVvmRzI7w+HPiTvDNqTAS2Cw+GuvQZMQO7J4HX0Lw/SEqrDYf9u3FCruqodx+U2qI= X-Received: by 2002:a02:5782:: with SMTP id b2mr4778673jad.2.1550227766165; Fri, 15 Feb 2019 02:49:26 -0800 (PST) MIME-Version: 1.0 References: <20190211183322.23133-1-ard.biesheuvel@linaro.org> <20190211190729.6nwdyqzeuom5fgvm@bivouac.eciton.net> In-Reply-To: <20190211190729.6nwdyqzeuom5fgvm@bivouac.eciton.net> From: Ard Biesheuvel Date: Fri, 15 Feb 2019 11:49:15 +0100 Message-ID: To: Leif Lindholm Cc: "edk2-devel@lists.01.org" Subject: Re: [PATCH edk2-platforms] Silicon/SynQuacer/Stage2Tables: fix build for cross compile from x86 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Feb 2019 10:49:27 -0000 Content-Type: text/plain; charset="UTF-8" On Mon, 11 Feb 2019 at 20:07, Leif Lindholm wrote: > > On Mon, Feb 11, 2019 at 07:33:22PM +0100, Ard Biesheuvel wrote: > > AArch64 binutils support AArch32 seamlessly when running natively, > > which allowed us to drop the -I objcopy argument specifying that > > the input format is elf64-little, which is no longer accurate now > > that the module can be built in 32-bit mode as well (which makes no > > difference whatsoever given that the resulting binary image is only > > a set of stage2 page tables) > > > > The same does not apply to binutils hosted on x86, so add back the > > appropriate input format depending on the target type. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Ard Biesheuvel > > Acked-by: Leif Lindholm > Tested-by: Leif Lindholm > Pushed as d7b29975f8f8..06454982de98 Thanks > > --- > > Silicon/Socionext/SynQuacer/Stage2Tables/Stage2Tables.inf | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/Silicon/Socionext/SynQuacer/Stage2Tables/Stage2Tables.inf b/Silicon/Socionext/SynQuacer/Stage2Tables/Stage2Tables.inf > > index f845015b9002..3e7039d586e1 100644 > > --- a/Silicon/Socionext/SynQuacer/Stage2Tables/Stage2Tables.inf > > +++ b/Silicon/Socionext/SynQuacer/Stage2Tables/Stage2Tables.inf > > @@ -26,6 +26,8 @@ [Sources] > > [BuildOptions] > > *_*_*_OBJCOPY_PATH == objcopy > > *_*_*_OBJCOPY_FLAGS == -O binary -j .rodata > > + *_*_AARCH64_OBJCOPY_FLAGS = -I elf64-little > > + *_*_ARM_OBJCOPY_FLAGS = -I elf32-little > > *_*_*_ASM_FLAGS == -nostdlib -Wl,-e,0x81f8000,--section-start=.rodata=0x81f8000 > > *_CLANG35_*_ASM_FLAGS = -no-integrated-as > > *_CLANG38_*_ASM_FLAGS = -no-integrated-as > > -- > > 2.20.1 > >