Re: [PATCH v1 1/2] EmbeddedPkg DSC: Use ReportStatusCodeLib (DXE) in MdeModulePkg

["Ard Biesheuvel" <ard.biesheuvel@linaro.org>]

On Fri, 17 May 2019 at 17:50, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
>
> On Tue, 14 May 2019 at 09:33, Hao A Wu <hao.a.wu@intel.com> wrote:
> >
> > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1720
> >
> > This commit will update the package DSC file to consume the
> > ReportStatusCodeLib (DXE phase instance) in MdeModulePkg, instead of using
> > the one in IntelFrameworkModulePkg.
> >
> > Please note that, the 2 ReportStatusCodeLib are almost identical. Thus,
> > there is no functional impact for this commit.
> >
> > Cc: Ray Ni <ray.ni@intel.com>
> > Cc: Leif Lindholm <leif.lindholm@linaro.org>
> > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > Signed-off-by: Hao A Wu <hao.a.wu@intel.com>
>
> Can we use the NULL status code library here?
>

Never mind - this is already merged, and I noticed PrePiLib actuall
includes a status code router, so it makes sense to use the versions
below.

> > ---
> >  EmbeddedPkg/EmbeddedPkg.dsc | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/EmbeddedPkg/EmbeddedPkg.dsc b/EmbeddedPkg/EmbeddedPkg.dsc
> > index b8b6ac90c0..b487337909 100644
> > --- a/EmbeddedPkg/EmbeddedPkg.dsc
> > +++ b/EmbeddedPkg/EmbeddedPkg.dsc
> > @@ -105,16 +105,16 @@
> >
> >  [LibraryClasses.common.DXE_DRIVER]
> >    PcdLib|MdePkg/Library/DxePcdLib/DxePcdLib.inf
> > -  ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReportStatusCodeLib.inf
> > +  ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf
> >
> >
> >  [LibraryClasses.common.UEFI_APPLICATION]
> >    PcdLib|MdePkg/Library/DxePcdLib/DxePcdLib.inf
> > -  ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReportStatusCodeLib.inf
> > +  ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf
> >
> >  [LibraryClasses.common.UEFI_DRIVER]
> >    PcdLib|MdePkg/Library/DxePcdLib/DxePcdLib.inf
> > -  ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReportStatusCodeLib.inf
> > +  ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf
> >
> >  [LibraryClasses.common.SEC]
> >    ExtractGuidedSectionLib|EmbeddedPkg/Library/PrePiExtractGuidedSectionLib/PrePiExtractGuidedSectionLib.inf
> > --
> > 2.12.0.windows.1
> >