From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linaro.org header.s=google header.b=nz/MhTiO;
 spf=pass (domain: linaro.org, ip: 209.85.166.193, mailfrom: ard.biesheuvel@linaro.org)
Received: from mail-it1-f193.google.com (mail-it1-f193.google.com [209.85.166.193])
 by groups.io with SMTP; Fri, 17 May 2019 08:56:57 -0700
Received: by mail-it1-f193.google.com with SMTP id u186so12811983ith.0
        for <devel@edk2.groups.io>; Fri, 17 May 2019 08:56:57 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=uPbjBP8/+BGDOIFXTCzwNq96MmdfKfHrz173Mkk+U+I=;
        b=nz/MhTiOCSNfRhIHN08zS659bCBQapLghrm3rB3Zrek3pNtgP8PGWVd09/etIjSp7J
         emsAOuGFDC9cPcgpsrBXBOx0HBJsRaII4u2PYXovSHaAeyFUMYjCcVesp/OTdl2c2Qjd
         1zkn1utnZRDcCA9nFhKSU27zobDefRJB7AR0Zb8UbbTRx3LqF5APTwAJeQRqMCvTl48a
         9Q/2QCYbibmxEat9m0cs4sPnmRVKyNSaibWd89Yg9Y+rNxerjrgOWhh+rw9Mw8eWjO+G
         BqpAeBRkq17IylppCZ8EMXjjWXP9tzSGfJglYeq+bXX5tmUCeEc4im69TpYym6JUibZr
         lqJQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=uPbjBP8/+BGDOIFXTCzwNq96MmdfKfHrz173Mkk+U+I=;
        b=NRgJxZxng2Ntg0J9FCtZEDf6YA+lS1z6F6IQD+awQBR8t9SejN9ajSR2Mkz4fAjXM9
         I0vUdHSpT1afVizkD6Y3x/aLPzbEUpVdoKF1oyDbFFmEqqJqc3EUMPWCPowVqHXUxNfI
         bWTYdLFdzAuiGy3JUScK8GHQpXTB2I39iOu8onM6/qyEu0EwH+tkbGqgXFDeZFLN27ET
         y025Uz3/qBOeLa6Q7SbpqOgmxx3lN7NUS0UQugthrcQJ91ZsoENDcNIfhuxu56Bx1c8G
         y9BYYid8EFHacEvfPiXKBiP7juZVfSQvGIMMzWo2qpbwUwvbdesgITvm4ZsLzcOxL7HE
         m5ag==
X-Gm-Message-State: APjAAAW8UrrtBHKxePv/h1zMAX1SSbmJ257nCdPM3zQYAlhZWup0FX4s
	aI2UWdxhSFayT7p/PqSmgVHxp0sppcwo0hLoVJ8i4Q==
X-Google-Smtp-Source: APXvYqxJbXLMlkxG1YGCrmUpZR7bzmcOM2oqExDm9BrHj6HlSzns5XUBi4541IAmQGSwDKe04Q0tEUmJ+cexhktvsOo=
X-Received: by 2002:a05:6638:310:: with SMTP id w16mr30348138jap.130.1558108616729;
 Fri, 17 May 2019 08:56:56 -0700 (PDT)
MIME-Version: 1.0
References: <20190514073343.11872-1-hao.a.wu@intel.com> <20190514073343.11872-2-hao.a.wu@intel.com>
 <CAKv+Gu_ZwZSFuNRJTB6NUKygrofBSZ5JwnwO1LmHU99VSCc7kA@mail.gmail.com>
In-Reply-To: <CAKv+Gu_ZwZSFuNRJTB6NUKygrofBSZ5JwnwO1LmHU99VSCc7kA@mail.gmail.com>
From: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
Date: Fri, 17 May 2019 17:56:45 +0200
Message-ID: <CAKv+Gu-+a8p9FtoZD2YOUaA7zZ90kKMOgoBOtm=bJbtQzQQbWA@mail.gmail.com>
Subject: Re: [PATCH v1 1/2] EmbeddedPkg DSC: Use ReportStatusCodeLib (DXE) in MdeModulePkg
To: Hao A Wu <hao.a.wu@intel.com>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>, Ray Ni <ray.ni@intel.com>, 
	Leif Lindholm <leif.lindholm@linaro.org>
Content-Type: text/plain; charset="UTF-8"

On Fri, 17 May 2019 at 17:50, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
>
> On Tue, 14 May 2019 at 09:33, Hao A Wu <hao.a.wu@intel.com> wrote:
> >
> > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1720
> >
> > This commit will update the package DSC file to consume the
> > ReportStatusCodeLib (DXE phase instance) in MdeModulePkg, instead of using
> > the one in IntelFrameworkModulePkg.
> >
> > Please note that, the 2 ReportStatusCodeLib are almost identical. Thus,
> > there is no functional impact for this commit.
> >
> > Cc: Ray Ni <ray.ni@intel.com>
> > Cc: Leif Lindholm <leif.lindholm@linaro.org>
> > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > Signed-off-by: Hao A Wu <hao.a.wu@intel.com>
>
> Can we use the NULL status code library here?
>

Never mind - this is already merged, and I noticed PrePiLib actuall
includes a status code router, so it makes sense to use the versions
below.

> > ---
> >  EmbeddedPkg/EmbeddedPkg.dsc | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/EmbeddedPkg/EmbeddedPkg.dsc b/EmbeddedPkg/EmbeddedPkg.dsc
> > index b8b6ac90c0..b487337909 100644
> > --- a/EmbeddedPkg/EmbeddedPkg.dsc
> > +++ b/EmbeddedPkg/EmbeddedPkg.dsc
> > @@ -105,16 +105,16 @@
> >
> >  [LibraryClasses.common.DXE_DRIVER]
> >    PcdLib|MdePkg/Library/DxePcdLib/DxePcdLib.inf
> > -  ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReportStatusCodeLib.inf
> > +  ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf
> >
> >
> >  [LibraryClasses.common.UEFI_APPLICATION]
> >    PcdLib|MdePkg/Library/DxePcdLib/DxePcdLib.inf
> > -  ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReportStatusCodeLib.inf
> > +  ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf
> >
> >  [LibraryClasses.common.UEFI_DRIVER]
> >    PcdLib|MdePkg/Library/DxePcdLib/DxePcdLib.inf
> > -  ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReportStatusCodeLib.inf
> > +  ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf
> >
> >  [LibraryClasses.common.SEC]
> >    ExtractGuidedSectionLib|EmbeddedPkg/Library/PrePiExtractGuidedSectionLib/PrePiExtractGuidedSectionLib.inf
> > --
> > 2.12.0.windows.1
> >