From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66])
 by mx.groups.io with SMTP id smtpd.web09.1544.1575295714039444771
 for <devel@edk2.groups.io>;
 Mon, 02 Dec 2019 06:08:34 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linaro.org header.s=google header.b=CJZcPakI;
 spf=pass (domain: linaro.org, ip: 209.85.128.66, mailfrom: ard.biesheuvel@linaro.org)
Received: by mail-wm1-f66.google.com with SMTP id p17so17606547wma.1
        for <devel@edk2.groups.io>; Mon, 02 Dec 2019 06:08:33 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=EBhCNe2/Ooo7NWF9jhjtCzcal5kVwWYFTvgTp6rWbT0=;
        b=CJZcPakIc7iv15MlmKKDk//V/dN0e8v5gwxvazPAcLqVvlmDlm2BAF2ZmBd8mkCtoq
         JznocmAXWMgzIaSBgDZHhICnXtIMhd9UiT4t4UrMO51HZgFgSd9wqYYIS0VThd/4OXma
         tsh2i+cm74JJr4GaiCnNOQq8j/J+VplpzYuhIcBRacCyEIw9aQeLfcQIz/4ZESVMsVtZ
         hX8FNYpTqhXR9w2gbpMKjR4SL4W4trYRO9C9c4bXm6jy0NLR1enEgDgIllpScaHODhjL
         PqD4cFPiufNNrtx9IDUwYm4xDJvDHqZxaIE5WWi8GmJNFqPyOt6ya9yVMST33hnulPF2
         CgZQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=EBhCNe2/Ooo7NWF9jhjtCzcal5kVwWYFTvgTp6rWbT0=;
        b=ktiFP2erOMWVoQ0a1z4mQk6pYk7vWsMj25kLNzpcbeIbEFz9sR8vReOkDHPXmW4tSX
         oyF+DqsTcv1NkUwxqNQjjj8lj+FJQcGDvr4uqajfyGV0eWe68QYgbN0TU9zmM9368DFo
         NdqiLj/ImuflVlIgoFpz46aIIHNMV9UdpGyx/bmf41bS2bw4FAzwsBGP/x3WfK3qMyVI
         xUStHtSopZ56KeoxImzg9zuHCcbENv8XyJK0+kSnfnxeXNvxKiZ8SR2X4gRxRBd4MDWg
         14/ULvWcc+Z+sqHeKZ3P3nnwrnnj83Dl6BUFMmNchhh6gHLmpDcEFwFjxns1gsLYo2Vx
         GqLg==
X-Gm-Message-State: APjAAAVPrCqA0K3VQRZ861Xk1C+p/dGhwrsp/5MXaulGoZhazrH6EXQo
	VmgeIkvUX9B4OQarGqC3LRGgKfqvzmov5s/ijsBPng==
X-Google-Smtp-Source: APXvYqwer6l0BasQuydWaQCtg2rbdLjcbBCIaTrpu8rsxqkZX2D3fZVVdmKx5+l0wSFf5N7FSn0bsNpT1fU1Jef8n2U=
X-Received: by 2002:a7b:c778:: with SMTP id x24mr14052030wmk.119.1575295712570;
 Mon, 02 Dec 2019 06:08:32 -0800 (PST)
MIME-Version: 1.0
References: <20191129104716.819-1-ard.biesheuvel@linaro.org>
 <20191129112926.GA7359@bivouac.eciton.net> <CAKv+Gu-YcSQ0erMu51AH-G1PWO6aEk4C_0nJM43NmV408PzVTA@mail.gmail.com>
 <CAKv+Gu-2AE1hqegkt0d1unKQYFoSa+odFy0DtXftaa56Yxr+5Q@mail.gmail.com> <20191202120239.GB7359@bivouac.eciton.net>
In-Reply-To: <20191202120239.GB7359@bivouac.eciton.net>
From: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
Date: Mon, 2 Dec 2019 15:08:26 +0100
Message-ID: <CAKv+Gu-+phCw077XoJTGM2RiGP170tkoJ1etXrYk=jLgAK3Ymg@mail.gmail.com>
Subject: Re: [PATCH edk2-platforms 0/2] SynQuacer: expose OP-TEE in ACPI mode
To: Leif Lindholm <leif.lindholm@linaro.org>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>
Content-Type: text/plain; charset="UTF-8"

On Mon, 2 Dec 2019 at 13:02, Leif Lindholm <leif.lindholm@linaro.org> wrote:
>
> On Mon, Dec 02, 2019 at 10:58:45 +0100, Ard Biesheuvel wrote:
> > On Fri, 29 Nov 2019 at 13:13, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
> > >
> > > On Fri, 29 Nov 2019 at 12:29, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> > > >
> > > > On Fri, Nov 29, 2019 at 11:47:14 +0100, Ard Biesheuvel wrote:
> > > > > Refactor the platform DXE a bit in patch #1 so we can seamlessly drop in
> > > > > the code in patch #2 to expose a SSDT with a device node describing
> > > > > OP-TEE when booting in ACPI mode and OP-TEE is present.
> > > >
> > > > If we need any more SSDTs for this platform in future, I'll probably
> > > > start grumbling about refactoring away the per-table global variables,
> > > > but I guess it would be a bit overkill at this point...
> > > >
> > >
> > > Yeah, the thought crossed my mind as well, but let's defer that to the
> > > next time.
> > >
> > > > For the series:
> > > > Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
> > > >
> > >
> >
> > Actually, I need to apply this on top
> >
> > --- a/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.c
> > +++ b/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.c
> > @@ -282,13 +282,16 @@ InstallAcpiTables (
> >      return;
> >    }
> >
> > +  if (mEmmcSsdtSize > 0) {
> >      Status = AcpiTable->InstallAcpiTable (AcpiTable, mEmmcSsdt, mEmmcSsdtSize,
> >                            &TableKey);
>
> Indentation presumably added for clarity?
>

Yep

> >      if (EFI_ERROR (Status)) {
> >        DEBUG ((DEBUG_WARN, "%a: failed to install SSDT table for eMMC - %r\n",
> >          __FUNCTION__, Status));
> >      }
> > +  }
> >
> > +  if (mTos0SsdtSize > 0) {
> >      Status = AcpiTable->InstallAcpiTable (AcpiTable, mTos0Ssdt, mTos0SsdtSize,
> >                            &TableKey);
> >      if (EFI_ERROR (Status)) {
> > @@ -296,6 +299,7 @@ InstallAcpiTables (
> >          __FUNCTION__, Status));
> >      }
> >    }
> > +}
>
> LGTM.
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
>

Thanks,

> >  EFI_STATUS
> >  EFIAPI
> >
> > or we will call InstallAcpiTable() with a zero size if we're only
> > installing one of the tables.