From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::d41; helo=mail-io1-xd41.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io1-xd41.google.com (mail-io1-xd41.google.com [IPv6:2607:f8b0:4864:20::d41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B0B9521157FE4 for ; Tue, 9 Oct 2018 00:12:38 -0700 (PDT) Received: by mail-io1-xd41.google.com with SMTP id n18-v6so379752ioa.9 for ; Tue, 09 Oct 2018 00:12:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=H90gp6+yvWOrLPRQwfdi7Khh+RreDqKMF9v6d0Lp1W0=; b=c6vbv9nJJq9AmydMtdQ6BNAbQ50BARY0ztqvCHYL+AHXJFCdYeURYKVo9mYTwnIuEb GCb6ZiNtlilUgEk4O7+jnMqWBuTjbqIiW9tqP9Us0mnfCmK3xPH3tN13vq1e+izgP9H5 xnfe/xSobiy+vv4ftrXrMnMrJ8G/wc5cmpYlw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=H90gp6+yvWOrLPRQwfdi7Khh+RreDqKMF9v6d0Lp1W0=; b=Z1rP+WmAbo6DWJQbHnzJQCk9ht47yU8334DZpv7watQSsY+/d0UC9dlC2GF0MIZnQD 78A5Bq/eZpb++zKQF/y1pwoUtJuT6BzNTx0uHaUkvoHYnCJFyDMn6pVtTPTm1N0qJJAX y6QHIez3JCET9bhJzEN7x9vFpxYOKVWa9BiDDKwFAQINjojSCXGF54yJjeM24LTXsMJE kqs25l2nIesZxzEoXdjiXhl/+ZXzEH970i7LEQV/jmDMncgJTrGXQpB1nDpH9hBRoZty xWjmPuaSPDnNYJacXaYv/3A/Wx64w4rHa+/6/achgwGSfLTJmhlmIIjCG4ocUfReI2wc RVFQ== X-Gm-Message-State: ABuFfoj3bYQi8f0HgzMphxtevj+Qg/2bKsvKIT00vhlXJ/R/sj7ptUG6 KhHUukg7Ft6MlS/Zd3GIeXWIdgOho+7zF12MWJvaZQ== X-Google-Smtp-Source: ACcGV61n3Ql35C1jzHIzgMR6G2DWfYrJ7s/kY1vAigfKFKtRF4e0EOFTjXIi9LVShnJVkqSjq1hQWFDASub09JK2u00= X-Received: by 2002:a6b:3787:: with SMTP id e129-v6mr18788780ioa.60.1539069157675; Tue, 09 Oct 2018 00:12:37 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a6b:5910:0:0:0:0:0 with HTTP; Tue, 9 Oct 2018 00:12:37 -0700 (PDT) In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E335C1D@SHSMSX104.ccr.corp.intel.com> References: <20181009070614.20052-1-liming.gao@intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E335C1D@SHSMSX104.ccr.corp.intel.com> From: Ard Biesheuvel Date: Tue, 9 Oct 2018 09:12:37 +0200 Message-ID: To: "Gao, Liming" Cc: "edk2-devel@lists.01.org" Subject: Re: [Patch] BaseTools LzmaCompress: Fix GCC warning misleading-indentation X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Oct 2018 07:12:38 -0000 Content-Type: text/plain; charset="UTF-8" On 9 October 2018 at 09:11, Gao, Liming wrote: > This issue in LzmaEnc.c is for encode. The copy SDK in MdeModulePkg and IntelFrameworkModulepkg is for decode. So, other copy SDK has no this issue. > I understand. Thanks for the fix Acked-by: Ard Biesheuvel >> -----Original Message----- >> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ard Biesheuvel >> Sent: Tuesday, October 9, 2018 3:08 PM >> To: Gao, Liming >> Cc: edk2-devel@lists.01.org >> Subject: Re: [edk2] [Patch] BaseTools LzmaCompress: Fix GCC warning misleading-indentation >> >> On 9 October 2018 at 09:06, Liming Gao wrote: >> > GCC 6 or above reports the warning misleading-indentation. >> > This patch fixes it. >> > >> > Contributed-under: TianoCore Contribution Agreement 1.1 >> > Signed-off-by: Liming Gao >> > Cc: Ard Biesheuvel >> > --- >> > BaseTools/Source/C/LzmaCompress/Sdk/C/LzmaEnc.c | 4 +++- >> > 1 file changed, 3 insertions(+), 1 deletion(-) >> > >> > diff --git a/BaseTools/Source/C/LzmaCompress/Sdk/C/LzmaEnc.c b/BaseTools/Source/C/LzmaCompress/Sdk/C/LzmaEnc.c >> > index bebe664..e281716 100644 >> > --- a/BaseTools/Source/C/LzmaCompress/Sdk/C/LzmaEnc.c >> > +++ b/BaseTools/Source/C/LzmaCompress/Sdk/C/LzmaEnc.c >> > @@ -1464,7 +1464,9 @@ static unsigned GetOptimum(CLzmaEnc *p, UInt32 position) >> > unsigned limit = p->numFastBytes + 1; >> > if (limit > numAvailFull) >> > limit = numAvailFull; >> > - for (len = 3; len < limit && data[len] == data2[len]; len++); >> > + for (len = 3; len < limit && data[len] == data2[len]; len++) >> > + { >> > + } >> > >> > { >> > unsigned state2 = kLiteralNextStates[state]; >> >> Thanks Liming. >> >> Don't we need this change in all copies of the LZMA SDK? >> _______________________________________________ >> edk2-devel mailing list >> edk2-devel@lists.01.org >> https://lists.01.org/mailman/listinfo/edk2-devel