From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=SveABXP6; spf=pass (domain: linaro.org, ip: 209.85.166.67, mailfrom: ard.biesheuvel@linaro.org) Received: from mail-io1-f67.google.com (mail-io1-f67.google.com [209.85.166.67]) by groups.io with SMTP; Fri, 17 May 2019 09:06:05 -0700 Received: by mail-io1-f67.google.com with SMTP id b3so5862655iob.12 for ; Fri, 17 May 2019 09:06:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=isfFum2Io+TKszByXuQMvuRL7fSZwEhsRMerfpOaG0Q=; b=SveABXP6SgKQZ+t3v54TTNo45wgOnblZMFg1TJh/OKBz9J3yfXDARCjSyLxYh+NLHv qHRbO3CZN8XLx1LhdioD6e0D3mzmzV4qabdnr41QJTPj4DRg+h9dOXDPammiPrjRpnLd gkMRFd8FLrUAbTJjmpWAqW+ns7QoH6b+tHppRD+bKK0KLcaixyZ/WC3a00MxIIHFL5s0 C00WRX06Pzc3svkh/xDEOQGUUgwOQpu+YbSeOgjkrJC9pyf31ZgEoyzeHbZjJCIhvTqF I5NtS/ICNG1YLPB0dTvVqRtdx1Tp34aqA8berSmaIdHW9yBWrmG+h6pRfh7vP+BgN2N/ /DAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=isfFum2Io+TKszByXuQMvuRL7fSZwEhsRMerfpOaG0Q=; b=ODTK4kgQd66r76hU96k/3hBx4Hw5Vy22uPEpAtaZzJmMJWBnVdWssKoqT+3v5fIMoi JiuRGOwir9qSLF8wQZ83kj7sBWnPojV2rrEZJi8LpRvMXEL/g6vE6/j5ji2Wv7UbI90M cnAWkr0u54PaJ9++kuHc9a3x7w8G5OhEOW4VHKaTFTZCi9YUPGOsSpkF9hjgosE8jsjn ta2gZnuQ0Q9sfqKsiLpX+yQ8EEVkcDgRJCpi+aaROZxoIsuPEui2qSVdFfRoKx96kNDY 3qHzI84/QwiYX7UsdoioMpNStP/oLDWG1HdeuiUcqZRmY3ZQoVNJA4otCP+YvZy6aiDi 8IlQ== X-Gm-Message-State: APjAAAXNHt8AgEMISZoMtmJKwX9sH9DfWya+bAw27njSUbVSbDwgt22R 70D00ARSAZHlXOVpfSlBR1abculC4Rny0wcQR4CMBw== X-Google-Smtp-Source: APXvYqwIMH8K2cCqKAsJNiuGuLrRXQT4FjmVxQB54v2j+Z/S3ddGGZukfTNcHhP5pwCM6/S7WvVZoXPUJYZTzkSzjDw= X-Received: by 2002:a05:6602:2109:: with SMTP id x9mr10186247iox.128.1558109164611; Fri, 17 May 2019 09:06:04 -0700 (PDT) MIME-Version: 1.0 References: <20190514020831.7728-1-hao.a.wu@intel.com> <20190514020831.7728-5-hao.a.wu@intel.com> <20190517160257.7d4g2nj2gradcel7@bivouac.eciton.net> In-Reply-To: <20190517160257.7d4g2nj2gradcel7@bivouac.eciton.net> From: "Ard Biesheuvel" Date: Fri, 17 May 2019 18:05:50 +0200 Message-ID: Subject: Re: [edk2-devel] [edk2-platforms][PATCH v1 02/16] Platform/BeagleBoard: Use ReportStatusCodeLib in MdeModulePkg To: Leif Lindholm Cc: edk2-devel-groups-io , "Wu, Hao A" , Michael D Kinney Content-Type: text/plain; charset="UTF-8" On Fri, 17 May 2019 at 18:03, Leif Lindholm wrote: > > On Fri, May 17, 2019 at 05:24:36PM +0200, Ard Biesheuvel wrote: > > On Tue, 14 May 2019 at 04:08, Wu, Hao A wrote: > > > > > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1800 > > > > > > This commit will update the DSC file to consume the ReportStatusCodeLib > > > (DXE phase and Runtime instances) in MdeModulePkg, instead of using the > > > one in IntelFrameworkModulePkg. > > > > > > Please note that, the DXE and Runtime ReportStatusCodeLib instances are > > > almost identical between IntelFrameworkModulePkg and MdeModulePkg. Thus, > > > there is no functional impact for this commit. > > > > > > Cc: Ard Biesheuvel > > > Cc: Leif Lindholm > > > Cc: Michael D Kinney > > > Signed-off-by: Hao A Wu > > > > This platform does not have a status code router, so should we not > > simply switch to BaseReportStatusCodeLibNull.inf here? > > Err, yeah, good point. Slight case of tunnel vision. > Actually, I only just figured out that PrePiLib *does* have a status code router. This is slightly dodgy (as is PrePi in general) since it uses a HOB to expose function pointers into the SEC module, but from the protocol client pov, it is just a status code router as any other. Note that my comment still applies to other platforms that don't use PrePi (the Styx ones)