From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::242; helo=mail-it0-x242.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x242.google.com (mail-it0-x242.google.com [IPv6:2607:f8b0:4001:c0b::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1EFF4220EE10F for ; Wed, 13 Dec 2017 04:37:59 -0800 (PST) Received: by mail-it0-x242.google.com with SMTP id t1so3535896ite.5 for ; Wed, 13 Dec 2017 04:42:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=pgqvsvwChv5c7pKWN0qJ7+F0o7i5KXTeyuFRX4ifPI4=; b=eeK9/cMauvuUjorLrrId4Gf6t9R5E/BGLqQd0fyBNpyuVyR5PdQemsQbfplx3NzNdW B3XSraaxR1Yud/TaAz+t5tw56zNsPPHWDte91UdFuPRJHb4RD/xOMNYhCOZnVgv44YFR pCsdWC5TswYRyLYD0xnDpsVLtPcWrkdZOb/DU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=pgqvsvwChv5c7pKWN0qJ7+F0o7i5KXTeyuFRX4ifPI4=; b=NEYdBdpikP6+KrfBXnb+u9COKxgws88cELsSEDmHda7Qs+Km/aU7vfwyq/c66heSQ5 uiV/c/ofDfcjwKpqj4Q6Rqw38r41zGW8MTpkCMad4j5UuXZWVQD1ILpYD7lLD8PaFVRp cMiQBCC1vgxZI/gV3+8TqhgAvovvfJkJzNMJlBrpESQRCqbtMDe86ObRn3OGx8+Wwz1D myay2bXPSWPGQPoOriD2AFBBu9wqxQe0oyl5M5X8iyTJ1Anjvf2dGFi5exPUOdzox0lK 2A+tPWJB1aPe/lOWJ7WA5V3cc/XczjlAM9Q+gYOZXRNKx1p14iSMCMdGfeCtNCYhsn4I DO9Q== X-Gm-Message-State: AKGB3mIJ07PGd9x0bUsQMc8Bp3NMBEp8AFUMQV+2B1idngs8qjWG8Sjf GVLiJ8IKt2280BDvgfYFKDsPQwAIxnotpo7wRm/iUw== X-Google-Smtp-Source: ACJfBoudcrKTDL/26Ufn3cCKzVytMzSizxk76DYAQehh8aOKHprvIRxzDDtNA8xD0GS9yU2dUxAL98ixiH7QDSDTDgI= X-Received: by 10.36.71.83 with SMTP id t80mr2599555itb.48.1513168959113; Wed, 13 Dec 2017 04:42:39 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.104.16 with HTTP; Wed, 13 Dec 2017 04:42:38 -0800 (PST) In-Reply-To: <20171213122630.17023-1-leif.lindholm@linaro.org> References: <20171213122630.17023-1-leif.lindholm@linaro.org> From: Ard Biesheuvel Date: Wed, 13 Dec 2017 12:42:38 +0000 Message-ID: To: Leif Lindholm Cc: "edk2-devel@lists.01.org" , Michael D Kinney , Liming Gao , Star Zeng , Eric Dong Subject: Re: [PATCH 0/3] Use central definitions for EFI_VARIABLE_* X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Dec 2017 12:38:00 -0000 Content-Type: text/plain; charset="UTF-8" On 13 December 2017 at 12:26, Leif Lindholm wrote: > The set of variable attribute definitions in is > used by C code, but VfrCompile has no way of dealing with structs or > typedefs, and the VFRPP rules generate (and depend on) preprocessing with > C rules. > > There may be neater ways of dealing with this, but a simple solution is > to break the #defines into a separate header and include this both in > UefiMultiPhase.h and directly in .vfr source. > > Leif Lindholm (3): > MdePkg: break #defines out of Uefi/UefiMultiPhase.h > MdeModulePkg: use central variable definitions in DriverSampleDxe > EmbeddedPkg: use central variable definitions in .vfr files > For the series Reviewed-by: Ard Biesheuvel > EmbeddedPkg/Drivers/ConsolePrefDxe/ConsolePrefHii.vfr | 9 +---- > EmbeddedPkg/Drivers/DtPlatformDxe/DtPlatformHii.vfr | 9 +---- > MdeModulePkg/Universal/DriverSampleDxe/Vfr.vfr | 9 +---- > MdePkg/Include/Uefi/UefiMultiPhase.h | 23 +----------- > MdePkg/Include/Uefi/UefiMultiPhaseDefinitions.h | 39 ++++++++++++++++++++ > 5 files changed, 44 insertions(+), 45 deletions(-) > create mode 100644 MdePkg/Include/Uefi/UefiMultiPhaseDefinitions.h > > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Ard Biesheuvel > Cc: Star Zeng > Cc: Eric Dong > > -- > 2.11.0 >