Re: [PATCH 1/4] MdeModulePkg: introduce PE/COFF image emulator protocol

[Ard Biesheuvel <ard.biesheuvel@linaro.org>]

On 13 September 2018 at 12:05, Zeng, Star <star.zeng@intel.com> wrote:
> On 2018/9/12 21:21, Ard Biesheuvel wrote:
>>
>> Introduce a protocol that can be invoked by the image loading services
>> to execute foreign architecture PE/COFF images via an emulator.
>>
>> Contributed-under: TianoCore Contribution Agreement 1.0
>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>> ---
>>   MdeModulePkg/Include/Protocol/PeCoffImageEmulator.h | 51
>> ++++++++++++++++++++
>>   MdeModulePkg/MdeModulePkg.dec                       |  4 ++
>>   2 files changed, 55 insertions(+)
>>
>> diff --git a/MdeModulePkg/Include/Protocol/PeCoffImageEmulator.h
>> b/MdeModulePkg/Include/Protocol/PeCoffImageEmulator.h
>> new file mode 100644
>> index 000000000000..3391e68557b9
>> --- /dev/null
>> +++ b/MdeModulePkg/Include/Protocol/PeCoffImageEmulator.h
>> @@ -0,0 +1,51 @@
>> +/** @file
>> +  Copyright (c) 2018, Linaro, Ltd. All rights reserved.<BR>
>> +
>> +  This program and the accompanying materials
>> +  are licensed and made available under the terms and conditions of the
>> BSD License
>> +  which accompanies this distribution.  The full text of the license may
>> be found at
>> +  http://opensource.org/licenses/bsd-license.php
>> +
>> +  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
>> +  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR
>> IMPLIED.
>> +
>> +**/
>> +
>> +#ifndef __PECOFF_IMAGE_EMULATOR_PROTOCOL_GUID_H__
>> +#define __PECOFF_IMAGE_EMULATOR_PROTOCOL_GUID_H__
>> +
>> +#define EDKII_PECOFF_IMAGE_EMULATOR_PROTOCOL_GUID \
>> +  { 0x96F46153, 0x97A7, 0x4793, { 0xAC, 0xC1, 0xFA, 0x19, 0xBF, 0x78,
>> 0xEA, 0x97 } }
>> +
>> +typedef struct _EDKII_PECOFF_IMAGE_EMULATOR_PROTOCOL
>> EDKII_PECOFF_IMAGE_EMULATOR_PROTOCOL;
>> +
>> +typedef
>> +BOOLEAN
>> +(EFIAPI *IS_PECOFF_IMAGE_SUPPORTED) (
>> +  IN  EDKII_PECOFF_IMAGE_EMULATOR_PROTOCOL    *This,
>> +  IN  UINT16                                  MachineType,
>> +  IN  UINT16                                  ImageType
>> +  );
>> +
>> +typedef
>> +EFI_STATUS
>> +(EFIAPI *REGISTER_PECOFF_IMAGE) (
>> +  IN  EDKII_PECOFF_IMAGE_EMULATOR_PROTOCOL    *This,
>> +  IN  EFI_PHYSICAL_ADDRESS                    ImageBase,
>> +  IN  UINT64                                  ImageSize
>> +  );
>> +
>> +typedef
>> +EFI_STATUS
>> +(EFIAPI *UNREGISTER_PECOFF_IMAGE) (
>> +  IN  EDKII_PECOFF_IMAGE_EMULATOR_PROTOCOL    *This,
>> +  IN  EFI_PHYSICAL_ADDRESS                    ImageBase
>> +  );
>> +
>> +typedef struct _EDKII_PECOFF_IMAGE_EMULATOR_PROTOCOL {
>> +  IS_PECOFF_IMAGE_SUPPORTED                   IsImageSupported;
>> +  REGISTER_PECOFF_IMAGE                       RegisterImage;
>> +  UNREGISTER_PECOFF_IMAGE                     UnregisterImage;
>> +} EDKII_PECOFF_IMAGE_EMULATOR_PROTOCOL;
>
>
> Hi Ard,
>
> There is no any comment for these protocol typedefs?
>
> How about using
> EDKII_PECOFF_IMAGE_EMULATOR_IS_IMAGE_SUPPORTED/EDKII_PECOFF_IMAGE_EMULATOR_REGISTER_IMAGE/EDKII_PECOFF_IMAGE_EMULATOR_UNREGISTER_IMAGE
> as the function typedef names?
>
> Add below line to align with other protocol header files?
> extern EFI_GUID gEdkiiPeCoffImageEmulatorProtocolGuid;
>

Yes, I can do that.

Thanks,
Ard.