From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::d44; helo=mail-io1-xd44.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io1-xd44.google.com (mail-io1-xd44.google.com [IPv6:2607:f8b0:4864:20::d44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B3BE52112E02A for ; Thu, 13 Sep 2018 03:36:59 -0700 (PDT) Received: by mail-io1-xd44.google.com with SMTP id w11-v6so2742712iob.2 for ; Thu, 13 Sep 2018 03:36:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Mq/Iaq7PggrKStnsGdEl4FSlGDYVeRno9G1R6M8meZQ=; b=WNpz48qiN5KXeSDQKKqYIK+UNuiFr4dk7wuyiOkkw88j2ofh/TWEIMUdpg0csp0pC1 0iKR+66XW7v/FabjCK8FRyRhepEpDkG7EKqdjlPM37YRN72/gc+POoHtERWx018dDXoF K/C5xX7J4z8WM1VSQfSyWWA43nwHrMqyCd3Ro= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Mq/Iaq7PggrKStnsGdEl4FSlGDYVeRno9G1R6M8meZQ=; b=Ewwq6LtTb2S9cQ+RacDVu4ihyB0xbpGB+uoyd0JMWHrjMuJonCsfQv+5oHu5C6XAm9 +QmAuzlHNW6Og3xtSBC5GuKNQyv9/lbt06GMWDgJOqm6QKu2fwJbAqDIzHStEqhj3TXD hu8jWnUkZvYanqJBa8Pfhs+78eRzEQ2RIH+cV0a1p6B7SgYQqke/2pd6l6QGBkVmclur /PnTH5KYEWJWIJdRNxfNceh/E/GrxvVg/Wz+NUWBfobuDXvpB3tomcscZYdBqehrZLku LxyFmJYKatuw2yMDZr4Sa7kT0t44qnnOKCo0Y7iN37Xc7FXpeUIZrvtHjWXqzRULyOmA RSuA== X-Gm-Message-State: APzg51ALKHhu8mLMTJuAow7qVmw288d5WDnczA0YFFL43+UHwKPiQmzX Vb2CY/CK8TyoaoD5qZekdbt2CHiy8ZsLYfOgrXjliw== X-Google-Smtp-Source: ANB0Vda/FH1rcKm1qXPv2ZuoP094Lh2kbBf4b1iT8ImWdIvk5MJsyWT6cDyxGrN8lKJB/Qoc20PZNofX0zm6ZTD9HMM= X-Received: by 2002:a6b:ba86:: with SMTP id k128-v6mr5300615iof.170.1536835018886; Thu, 13 Sep 2018 03:36:58 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a6b:2848:0:0:0:0:0 with HTTP; Thu, 13 Sep 2018 03:36:58 -0700 (PDT) In-Reply-To: <7542e155-451e-52c0-c71d-743d30c4d930@intel.com> References: <20180912132151.4258-1-ard.biesheuvel@linaro.org> <20180912132151.4258-2-ard.biesheuvel@linaro.org> <7542e155-451e-52c0-c71d-743d30c4d930@intel.com> From: Ard Biesheuvel Date: Thu, 13 Sep 2018 12:36:58 +0200 Message-ID: To: "Zeng, Star" Cc: "edk2-devel@lists.01.org" , Ruiyu Ni , Zimmer Vincent , Eric Dong , Andrew Fish , Alexander Graf , Brian Richardson , Michael D Kinney , Laszlo Ersek Subject: Re: [PATCH 1/4] MdeModulePkg: introduce PE/COFF image emulator protocol X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Sep 2018 10:36:59 -0000 Content-Type: text/plain; charset="UTF-8" On 13 September 2018 at 12:05, Zeng, Star wrote: > On 2018/9/12 21:21, Ard Biesheuvel wrote: >> >> Introduce a protocol that can be invoked by the image loading services >> to execute foreign architecture PE/COFF images via an emulator. >> >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Signed-off-by: Ard Biesheuvel >> --- >> MdeModulePkg/Include/Protocol/PeCoffImageEmulator.h | 51 >> ++++++++++++++++++++ >> MdeModulePkg/MdeModulePkg.dec | 4 ++ >> 2 files changed, 55 insertions(+) >> >> diff --git a/MdeModulePkg/Include/Protocol/PeCoffImageEmulator.h >> b/MdeModulePkg/Include/Protocol/PeCoffImageEmulator.h >> new file mode 100644 >> index 000000000000..3391e68557b9 >> --- /dev/null >> +++ b/MdeModulePkg/Include/Protocol/PeCoffImageEmulator.h >> @@ -0,0 +1,51 @@ >> +/** @file >> + Copyright (c) 2018, Linaro, Ltd. All rights reserved.
>> + >> + This program and the accompanying materials >> + are licensed and made available under the terms and conditions of the >> BSD License >> + which accompanies this distribution. The full text of the license may >> be found at >> + http://opensource.org/licenses/bsd-license.php >> + >> + THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, >> + WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR >> IMPLIED. >> + >> +**/ >> + >> +#ifndef __PECOFF_IMAGE_EMULATOR_PROTOCOL_GUID_H__ >> +#define __PECOFF_IMAGE_EMULATOR_PROTOCOL_GUID_H__ >> + >> +#define EDKII_PECOFF_IMAGE_EMULATOR_PROTOCOL_GUID \ >> + { 0x96F46153, 0x97A7, 0x4793, { 0xAC, 0xC1, 0xFA, 0x19, 0xBF, 0x78, >> 0xEA, 0x97 } } >> + >> +typedef struct _EDKII_PECOFF_IMAGE_EMULATOR_PROTOCOL >> EDKII_PECOFF_IMAGE_EMULATOR_PROTOCOL; >> + >> +typedef >> +BOOLEAN >> +(EFIAPI *IS_PECOFF_IMAGE_SUPPORTED) ( >> + IN EDKII_PECOFF_IMAGE_EMULATOR_PROTOCOL *This, >> + IN UINT16 MachineType, >> + IN UINT16 ImageType >> + ); >> + >> +typedef >> +EFI_STATUS >> +(EFIAPI *REGISTER_PECOFF_IMAGE) ( >> + IN EDKII_PECOFF_IMAGE_EMULATOR_PROTOCOL *This, >> + IN EFI_PHYSICAL_ADDRESS ImageBase, >> + IN UINT64 ImageSize >> + ); >> + >> +typedef >> +EFI_STATUS >> +(EFIAPI *UNREGISTER_PECOFF_IMAGE) ( >> + IN EDKII_PECOFF_IMAGE_EMULATOR_PROTOCOL *This, >> + IN EFI_PHYSICAL_ADDRESS ImageBase >> + ); >> + >> +typedef struct _EDKII_PECOFF_IMAGE_EMULATOR_PROTOCOL { >> + IS_PECOFF_IMAGE_SUPPORTED IsImageSupported; >> + REGISTER_PECOFF_IMAGE RegisterImage; >> + UNREGISTER_PECOFF_IMAGE UnregisterImage; >> +} EDKII_PECOFF_IMAGE_EMULATOR_PROTOCOL; > > > Hi Ard, > > There is no any comment for these protocol typedefs? > > How about using > EDKII_PECOFF_IMAGE_EMULATOR_IS_IMAGE_SUPPORTED/EDKII_PECOFF_IMAGE_EMULATOR_REGISTER_IMAGE/EDKII_PECOFF_IMAGE_EMULATOR_UNREGISTER_IMAGE > as the function typedef names? > > Add below line to align with other protocol header files? > extern EFI_GUID gEdkiiPeCoffImageEmulatorProtocolGuid; > Yes, I can do that. Thanks, Ard.