From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::241; helo=mail-it0-x241.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x241.google.com (mail-it0-x241.google.com [IPv6:2607:f8b0:4001:c0b::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5FC5B208F7A5D for ; Fri, 22 Dec 2017 07:23:01 -0800 (PST) Received: by mail-it0-x241.google.com with SMTP id f143so15023039itb.0 for ; Fri, 22 Dec 2017 07:27:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=4rI7DQ/Dk0jf4EgO/kKzuNGTZ4V2JvE6aYgiHHWbQsE=; b=DJcPbl+ZODKLO89Dk9yuf34m192cb8KjNGM9npRza7Dss4KMQAFdWJDlmytVoacJog Wq4Eqp5F3RR65hKLRmXW9oQAdMxyE9Q6jUMpOEH1N3QPzx3qz96j8VtuxPtYkCXoVXKA m6K67BMnS5jtT+GMfRQRG1YCW+hmtM4dLaKjw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=4rI7DQ/Dk0jf4EgO/kKzuNGTZ4V2JvE6aYgiHHWbQsE=; b=uBafh5SLAqOuJWR8ZyQS36OF+E9dOkDrem/t4ULWC7pRCJR29ZHoknuXetsiFzXKp/ LJfGubTTkCzyjRLGQUrHIxk5vm3K/BmH0I8PMCdvygCkq2z2yVQV4JWdQ8eepC/XTuhf gXi8XHfg6uk5MSrUy39A5g2R4LxYYJg71OAxzTq67uOltGGzwfh+xjvkzqAU3QKwvZtW FjlFOdqnWXHvYEUfxGJnQPzH8ARTEBZkvOna2gkJFROPoNB2R5xk04jOlsRBAkQN0jhZ B7bE7MokE1NW/Qjv0PHpOVApcmEXFz/b9JHAwcFkFtFxOGXo7L22cQkxr8Mjnab93UKE Jkdw== X-Gm-Message-State: AKGB3mKFwvSsnPe1gYgRwekmlwdssEoWbPWolrJCOZCC79JrnuZeHbaj rQegMkLbuIBzskUgrYldMF/DJdTzfniT2A2mp0kVGQ== X-Google-Smtp-Source: ACJfBouDynsTV1hKSTBiegicPNBE334xn8b6fjNGZR7OBxWwXBBefycHSrnHEW6XWdS2Y6oOuRLarjWJPwUcutBzzs0= X-Received: by 10.36.71.83 with SMTP id t80mr17442310itb.48.1513956470884; Fri, 22 Dec 2017 07:27:50 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.52.14 with HTTP; Fri, 22 Dec 2017 07:27:50 -0800 (PST) In-Reply-To: <20171222072336.23504-4-sigmaepsilon92@gmail.com> References: <20171222072336.23504-1-sigmaepsilon92@gmail.com> <20171222072336.23504-4-sigmaepsilon92@gmail.com> From: Ard Biesheuvel Date: Fri, 22 Dec 2017 15:27:50 +0000 Message-ID: To: M1cha Cc: "edk2-devel@lists.01.org" , Michael D Kinney , Liming Gao Subject: Re: [PATCH 3/3] MdePkg: add NORETURN attribute to LongJump and InternalLongJump X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Dec 2017 15:23:01 -0000 Content-Type: text/plain; charset="UTF-8" On 22 December 2017 at 07:23, M1cha wrote: > This fixes compiler warnings when using them in functions which > should return a value but rely on LongJump to never return instead. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Michael Zimmermann Reviewed-by: Ard Biesheuvel > --- > MdePkg/Include/Library/BaseLib.h | 1 + > MdePkg/Library/BaseLib/BaseLibInternals.h | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/MdePkg/Include/Library/BaseLib.h b/MdePkg/Include/Library/BaseLib.h > index 10976032adaa..e2eb46da4584 100644 > --- a/MdePkg/Include/Library/BaseLib.h > +++ b/MdePkg/Include/Library/BaseLib.h > @@ -4929,6 +4929,7 @@ SetJump ( > **/ > VOID > EFIAPI > +NORETURN > LongJump ( > IN BASE_LIBRARY_JUMP_BUFFER *JumpBuffer, > IN UINTN Value > diff --git a/MdePkg/Library/BaseLib/BaseLibInternals.h b/MdePkg/Library/BaseLib/BaseLibInternals.h > index 9dca97a0dcc9..3cd5fe34fc1b 100644 > --- a/MdePkg/Library/BaseLib/BaseLibInternals.h > +++ b/MdePkg/Library/BaseLib/BaseLibInternals.h > @@ -442,6 +442,7 @@ InternalAssertJumpBuffer ( > > **/ > VOID > +NORETURN > EFIAPI > InternalLongJump ( > IN BASE_LIBRARY_JUMP_BUFFER *JumpBuffer, > -- > 2.15.1 >