From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-x22d.google.com (mail-it0-x22d.google.com [IPv6:2607:f8b0:4001:c0b::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E745D1A1DFA for ; Tue, 9 Aug 2016 01:13:56 -0700 (PDT) Received: by mail-it0-x22d.google.com with SMTP id f6so7625891ith.0 for ; Tue, 09 Aug 2016 01:13:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=PHRQMAhul/S+Hjhlo2kLy6OobjsRfGz4T6eC7x8WWvw=; b=LQ5TZHvbDkUGuqwKOzvSoMHDdoIuZ34xjALsEnLFKEsA5TbaYa+sGzYyArUZptFH9G yNPqlxQ3hNqgcp6y/ildz1p3bRODTm7Huvi6krZQ+hvRmdHW2dAZpvH9U67gf2oxNZDu jnSfQmGftm2zyfGU2CjG85NaMZ3OYuw1XzzNU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=PHRQMAhul/S+Hjhlo2kLy6OobjsRfGz4T6eC7x8WWvw=; b=jMgQ03rwiwY87awcWSltdTbFBXSiLwJNLORW/E5aUVMZ44D5ollEbicmRc2j7+SDF3 nRgcOHIaAXNEb3p5DlxBqeR9ZbneheCsbvVpqx6gGGYGzHzFTPl28/iNu9laDNM8IsnK t1EbFuzp5izANJp+1h4QO6QhJqEgSVbO2nOU4sxRO8RtGKpI8Zw8PPC1SZ3LGhU5zt4m EzumaYpG7srGadfLGYHBY6QghLqzN5kWI6/S7WnMJwva0/AcGW7IunXWLlkGTVq5rB6S KPR1uAUJzWoNOMytWn/Xda1OBdecMizwiVXcYQkOM0N+cGsFd52oCgIe7qScdq9BjYrM vWFQ== X-Gm-Message-State: AEkoouv4D2G3ODx4h34q57bPUBjRPWp7eEl+qFLimlI5Bd5NISHP1Z19csbS83VtQZ/YZmh+0+mHdwiRCoN4cXcA X-Received: by 10.36.214.193 with SMTP id o184mr19875598itg.5.1470730436058; Tue, 09 Aug 2016 01:13:56 -0700 (PDT) MIME-Version: 1.0 Received: by 10.36.204.195 with HTTP; Tue, 9 Aug 2016 01:13:55 -0700 (PDT) In-Reply-To: References: <1470654741-24203-1-git-send-email-ard.biesheuvel@linaro.org> From: Ard Biesheuvel Date: Tue, 9 Aug 2016 10:13:55 +0200 Message-ID: To: "Carsey, Jaben" Cc: Michael Zimmermann , "edk2-devel@lists.01.org" , Leif Lindholm , Daryl McDaniel Subject: Re: [PATCH 1/2] StdLib/LibC: avoid LTO code for compiler intrinsics X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Aug 2016 08:13:57 -0000 Content-Type: text/plain; charset=UTF-8 On 8 August 2016 at 16:56, Carsey, Jaben wrote: > Reviewed-by: Jaben Carsey > Pushed as 78d706e23512 StdLib/LibC: avoid LTO code for compiler intrinsics 1fbd0ca16a99 StdLib/LibC ARM AARCH64: do not redefine compiler intrinsics Thanks all >> -----Original Message----- >> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of >> Michael Zimmermann >> Sent: Monday, August 08, 2016 4:24 AM >> To: Ard Biesheuvel >> Cc: Carsey, Jaben ; edk2-devel@lists.01.org; Leif >> Lindholm ; Daryl McDaniel > lists@mc2research.org> >> Subject: Re: [edk2] [PATCH 1/2] StdLib/LibC: avoid LTO code for compiler >> intrinsics >> Importance: High >> >> Reviewed-by: Michael Zimmermann >> >> On Mon, Aug 8, 2016 at 1:12 PM, Ard Biesheuvel >> >> wrote: >> >> > The softfloat routines and some other routines supplied by LibC >> > will satisfy references to compiler intrinsics that are emitted >> > by the compiler backend, which under LTO means that the link-time >> > code generation may emit references to symbols that have been >> > optimized away already. >> > >> > Work around this by building the ARM and AARCH64 versions of LibC >> > and the softfloat library without LTO. >> > >> > Contributed-under: TianoCore Contribution Agreement 1.0 >> > Signed-off-by: Ard Biesheuvel >> > --- >> > StdLib/LibC/LibC.inf | 1 + >> > StdLib/LibC/Softfloat/Softfloat.inf | 2 +- >> > 2 files changed, 2 insertions(+), 1 deletion(-) >> > >> > diff --git a/StdLib/LibC/LibC.inf b/StdLib/LibC/LibC.inf >> > index f13630648555..6039bb81c7dd 100644 >> > --- a/StdLib/LibC/LibC.inf >> > +++ b/StdLib/LibC/LibC.inf >> > @@ -120,3 +120,4 @@ [LibraryClasses] >> > # >> > [BuildOptions] >> > MSFT:*_*_IA32_CC_FLAGS = /GL- >> > + GCC:*_*_ARM_CC_FLAGS = -fno-lto >> > diff --git a/StdLib/LibC/Softfloat/Softfloat.inf b/StdLib/LibC/Softfloat/ >> > Softfloat.inf >> > index 99763bcb57ba..460406c38fa4 100644 >> > --- a/StdLib/LibC/Softfloat/Softfloat.inf >> > +++ b/StdLib/LibC/Softfloat/Softfloat.inf >> > @@ -71,4 +71,4 @@ [Packages] >> > # Nasty things could happen if you do. >> > >> > [BuildOptions] >> > - GCC:*_*_*_CC_FLAGS = -DSOFTFLOAT_FOR_GCC -Wno-enum-compare >> > -fno-tree-vrp >> > + GCC:*_*_*_CC_FLAGS = -DSOFTFLOAT_FOR_GCC -Wno-enum- >> compare >> > -fno-tree-vrp -fno-lto >> > -- >> > 2.7.4 >> > >> > >> _______________________________________________ >> edk2-devel mailing list >> edk2-devel@lists.01.org >> https://lists.01.org/mailman/listinfo/edk2-devel