From: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
To: Leif Lindholm <leif.lindholm@linaro.org>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>,
Andrew Fish <afish@apple.com>,
Anthony Perard <anthony.perard@citrix.com>,
Bob Feng <bob.c.feng@intel.com>, Dandan Bi <dandan.bi@intel.com>,
David Woodhouse <dwmw2@infradead.org>,
Eric Dong <eric.dong@intel.com>, Hao A Wu <hao.a.wu@intel.com>,
Jian J Wang <jian.j.wang@intel.com>,
Jordan Justen <jordan.l.justen@intel.com>,
Julien Grall <julien.grall@arm.com>,
Laszlo Ersek <lersek@redhat.com>,
Liming Gao <liming.gao@intel.com>, Ray Ni <ray.ni@intel.com>,
Zhichao Gao <zhichao.gao@intel.com>
Subject: Re: [PATCH 0/7] Strip trailing whitespace
Date: Thu, 19 Sep 2019 22:20:48 +0300 [thread overview]
Message-ID: <CAKv+Gu-1FPqdUJ0VXVZAMtpQ7VUfgRLBcq3s=rtNha+w63B0gg@mail.gmail.com> (raw)
In-Reply-To: <20190919180625.29150-1-leif.lindholm@linaro.org>
On Thu, 19 Sep 2019 at 21:06, Leif Lindholm <leif.lindholm@linaro.org> wrote:
>
> *cough* 5-6/7 do take a bit of a shotgun approach with the Cc:s, but I
> would prefer not breaking the set up any more than it already is.
> The changes are however trivial, so hopefully not much of an issue.
>
> Before we start looking into migrating the repository to native
> line endings, let's start by killing off a bunch of trailing
> whitespace.
>
> This is basically the output of:
> for filetype in '*.c' '*.h' '*.s' '*.S' '*.asm' '*.py' '*.inf' '*.inc' '*.dsc' '*.fdf' '*.dec' '*.uni' '*.txt' '*.md' '*.nasm' '*.vfr' '*.asl' '*.aslc' '*.asm16' '*makefile' '*.common' '*.cpp'; do find * -type f -iname "$filetype" -exec sed --in-place 's/[[:blank:]]\+\(\r*\)$/\1/' {} \;; done
> executed in the top-level directory.
>
> This does mess about with some imported projects, but I figure if
> we keep them in the tree, we might as well clean it up.
>
> Since we have some weird and wonderful file types in the tree, I think we can
> only realy ever run automated fixups on a "whitelist" of file types. Please
> let me know if I have left any important ones out from this operation.
>
> (Why yes, that .S _is_ totally redundant given the use of -iname, but at least I'm being honest.)
>
> These patches, as well as the preceding line ending and character
> encoding cleanup can also be accessed at:
> https://git.linaro.org/people/leif.lindholm/edk2.git/log/?h=pre-CRLF2LF-cleanup
>
> Leif Lindholm (7):
> ArmPkg: strip trailing whitespace
> ArmPlatformPkg: strip trailing whitespace
> OvmfPkg: strip trailing whitespace
For the above,
Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> BaseTools: strip trailing whitespace
> EmulatorPkg: strip trailing whitespace
> MdeModulePkg: strip trailing whitespace
> UefiCpuPkg: strip trailing whitespace
>
> ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf | 4 +-
> ArmPlatformPkg/Scripts/Ds5/profile.py | 2 +-
> ArmPlatformPkg/Scripts/Makefile | 2 +-
> BaseTools/Source/C/BrotliCompress/tools/brotli.c | 2 +-
> BaseTools/Source/C/GNUmakefile | 2 +-
> BaseTools/Source/C/LzmaCompress/Sdk/C/7zFile.c | 20 ++---
> BaseTools/Source/C/LzmaCompress/Sdk/C/7zTypes.h | 4 +-
> BaseTools/Source/C/LzmaCompress/Sdk/C/Alloc.c | 22 ++---
> BaseTools/Source/C/LzmaCompress/Sdk/C/Bra.h | 8 +-
> BaseTools/Source/C/LzmaCompress/Sdk/C/LzFind.c | 70 ++++++++--------
> BaseTools/Source/C/LzmaCompress/Sdk/C/LzFind.h | 4 +-
> BaseTools/Source/C/LzmaCompress/Sdk/C/LzFindMt.c | 40 ++++-----
> BaseTools/Source/C/LzmaCompress/Sdk/C/LzFindMt.h | 4 +-
> BaseTools/Source/C/LzmaCompress/Sdk/C/LzmaDec.c | 30 +++----
> BaseTools/Source/C/LzmaCompress/Sdk/C/LzmaDec.h | 4 +-
> BaseTools/Source/C/LzmaCompress/Sdk/C/LzmaEnc.c | 194 ++++++++++++++++++++++----------------------
> BaseTools/Source/C/LzmaCompress/Sdk/C/Threads.c | 6 +-
> BaseTools/Source/C/LzmaCompress/Sdk/DOC/lzma-history.txt | 92 ++++++++++-----------
> BaseTools/Source/C/LzmaCompress/Sdk/DOC/lzma-sdk.txt | 102 +++++++++++------------
> BaseTools/Source/C/Makefiles/app.makefile | 4 +-
> BaseTools/Source/C/Makefiles/footer.makefile | 4 +-
> BaseTools/Source/C/Makefiles/header.makefile | 8 +-
> BaseTools/Source/C/Makefiles/lib.makefile | 2 +-
> BaseTools/Source/C/Makefiles/ms.common | 4 +-
> BaseTools/Source/C/VfrCompile/GNUmakefile | 6 +-
> BaseTools/Source/C/VfrCompile/Pccts/CHANGES_FROM_131.txt | 2 +-
> BaseTools/Source/C/VfrCompile/Pccts/CHANGES_FROM_133.txt | 286 ++++++++++++++++++++++++++++++++---------------------------------
> BaseTools/Source/C/VfrCompile/Pccts/CHANGES_FROM_133_BEFORE_MR13.txt | 2 +-
> BaseTools/Source/C/VfrCompile/Pccts/CHANGES_SUMMARY.txt | 6 +-
> BaseTools/Source/C/VfrCompile/Pccts/KNOWN_PROBLEMS.txt | 20 ++---
> BaseTools/Source/C/VfrCompile/Pccts/antlr/antlr.c | 194 ++++++++++++++++++++++----------------------
> BaseTools/Source/C/VfrCompile/Pccts/antlr/bits.c | 10 +--
> BaseTools/Source/C/VfrCompile/Pccts/antlr/build.c | 18 ++---
> BaseTools/Source/C/VfrCompile/Pccts/antlr/dumpcycles.c | 8 +-
> BaseTools/Source/C/VfrCompile/Pccts/antlr/egman.c | 12 +--
> BaseTools/Source/C/VfrCompile/Pccts/antlr/fcache.c | 8 +-
> BaseTools/Source/C/VfrCompile/Pccts/antlr/fset.c | 16 ++--
> BaseTools/Source/C/VfrCompile/Pccts/antlr/fset2.c | 16 ++--
> BaseTools/Source/C/VfrCompile/Pccts/antlr/gen.c | 78 +++++++++---------
> BaseTools/Source/C/VfrCompile/Pccts/antlr/generic.h | 2 +-
> BaseTools/Source/C/VfrCompile/Pccts/antlr/hash.c | 10 +--
> BaseTools/Source/C/VfrCompile/Pccts/antlr/lex.c | 6 +-
> BaseTools/Source/C/VfrCompile/Pccts/antlr/main.c | 40 ++++-----
> BaseTools/Source/C/VfrCompile/Pccts/antlr/makefile | 4 +-
> BaseTools/Source/C/VfrCompile/Pccts/antlr/misc.c | 42 +++++-----
> BaseTools/Source/C/VfrCompile/Pccts/antlr/mrhoist.c | 4 +-
> BaseTools/Source/C/VfrCompile/Pccts/antlr/pred.c | 4 +-
> BaseTools/Source/C/VfrCompile/Pccts/antlr/scan.c | 4072 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
> BaseTools/Source/C/VfrCompile/Pccts/dlg/automata.c | 10 +--
> BaseTools/Source/C/VfrCompile/Pccts/dlg/dlg.h | 2 +-
> BaseTools/Source/C/VfrCompile/Pccts/dlg/dlg_a.c | 950 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-----------------------------------------------------------------------------------------------------------
> BaseTools/Source/C/VfrCompile/Pccts/dlg/dlg_p.c | 30 +++----
> BaseTools/Source/C/VfrCompile/Pccts/dlg/main.c | 10 +--
> BaseTools/Source/C/VfrCompile/Pccts/dlg/makefile | 2 +-
> BaseTools/Source/C/VfrCompile/Pccts/dlg/output.c | 4 +-
> BaseTools/Source/C/VfrCompile/Pccts/dlg/relabel.c | 4 +-
> BaseTools/Source/C/VfrCompile/Pccts/dlg/support.c | 2 +-
> BaseTools/Source/C/VfrCompile/Pccts/h/AParser.cpp | 8 +-
> BaseTools/Source/C/VfrCompile/Pccts/h/AParser.h | 4 +-
> BaseTools/Source/C/VfrCompile/Pccts/h/ASTBase.cpp | 8 +-
> BaseTools/Source/C/VfrCompile/Pccts/h/ATokenBuffer.cpp | 6 +-
> BaseTools/Source/C/VfrCompile/Pccts/h/DLG_stream_input.h | 22 ++---
> BaseTools/Source/C/VfrCompile/Pccts/h/DLexerBase.cpp | 2 +-
> BaseTools/Source/C/VfrCompile/Pccts/h/PBlackBox.h | 8 +-
> BaseTools/Source/C/VfrCompile/Pccts/h/PCCTSAST.cpp | 8 +-
> BaseTools/Source/C/VfrCompile/Pccts/h/antlr.h | 10 +--
> BaseTools/Source/C/VfrCompile/Pccts/h/ast.c | 4 +-
> BaseTools/Source/C/VfrCompile/Pccts/h/err.h | 70 ++++++++--------
> BaseTools/Source/C/VfrCompile/Pccts/history.txt | 6 +-
> BaseTools/Source/C/VfrCompile/Pccts/support/genmk/genmk.c | 14 ++--
> BaseTools/Source/C/VfrCompile/Pccts/support/genmk/genmk_old.c | 4 +-
> BaseTools/Source/C/VfrCompile/Pccts/support/rexpr/rexpr.c | 46 +++++------
> BaseTools/Source/C/VfrCompile/Pccts/support/set/set.c | 46 +++++------
> BaseTools/Source/C/VfrCompile/Pccts/support/set/set.h | 4 +-
> BaseTools/Source/C/VfrCompile/Pccts/support/sym/sym.c | 26 +++---
> BaseTools/Source/Python/Ecc/Check.py | 2 +-
> BaseTools/Source/Python/GenFds/GenFdsGlobalVariable.py | 2 +-
> BaseTools/Source/Python/Makefile | 2 +-
> EmulatorPkg/Readme.md | 4 +-
> MdeModulePkg/Application/UiApp/FrontPageVfr.Vfr | 8 +-
> MdeModulePkg/Library/DeviceManagerUiLib/DeviceManagerVfr.Vfr | 2 +-
> MdeModulePkg/Library/LzmaCustomDecompressLib/Sdk/C/7zTypes.h | 4 +-
> MdeModulePkg/Library/LzmaCustomDecompressLib/Sdk/C/Bra.h | 8 +-
> MdeModulePkg/Library/LzmaCustomDecompressLib/Sdk/C/LzFind.c | 70 ++++++++--------
> MdeModulePkg/Library/LzmaCustomDecompressLib/Sdk/C/LzFind.h | 4 +-
> MdeModulePkg/Library/LzmaCustomDecompressLib/Sdk/C/LzmaDec.c | 30 +++----
> MdeModulePkg/Library/LzmaCustomDecompressLib/Sdk/C/LzmaDec.h | 4 +-
> MdeModulePkg/Library/LzmaCustomDecompressLib/Sdk/DOC/lzma-history.txt | 92 ++++++++++-----------
> MdeModulePkg/Library/LzmaCustomDecompressLib/Sdk/DOC/lzma-sdk.txt | 102 +++++++++++------------
> MdeModulePkg/Universal/DriverHealthManagerDxe/DriverHealthConfigureVfr.Vfr | 6 +-
> MdeModulePkg/Universal/DriverHealthManagerDxe/DriverHealthManagerVfr.Vfr | 4 +-
> MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/OnigurumaUefiPort.c | 2 +-
> MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/OnigurumaUefiPort.h | 2 +-
> MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/regexec.c | 2 +-
> OvmfPkg/AcpiPlatformDxe/AcpiPlatform.c | 4 +-
> OvmfPkg/AcpiPlatformDxe/Xen.c | 8 +-
> OvmfPkg/AcpiTables/Facs.aslc | 6 +-
> OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiVfr.Vfr | 18 ++---
> OvmfPkg/Include/IndustryStandard/Xen/arch-x86/xen-x86_32.h | 4 +-
> OvmfPkg/Include/IndustryStandard/Xen/arch-x86/xen-x86_64.h | 4 +-
> OvmfPkg/Include/IndustryStandard/Xen/arch-x86/xen.h | 4 +-
> OvmfPkg/Include/IndustryStandard/Xen/hvm/params.h | 2 +-
> OvmfPkg/Include/IndustryStandard/Xen/io/protocols.h | 2 +-
> OvmfPkg/Include/IndustryStandard/Xen/io/ring.h | 34 ++++----
> OvmfPkg/Include/IndustryStandard/Xen/memory.h | 4 +-
> OvmfPkg/Include/IndustryStandard/Xen/xen-compat.h | 4 +-
> OvmfPkg/Include/IndustryStandard/Xen/xen.h | 10 +--
> OvmfPkg/Include/Register/QemuSmramSaveStateMap.h | 2 +-
> OvmfPkg/Library/DxePciLibI440FxQ35/PciLib.c | 12 +--
> OvmfPkg/Library/LockBoxLib/LockBoxDxe.c | 2 +-
> OvmfPkg/Library/LockBoxLib/LockBoxLib.c | 2 +-
> OvmfPkg/Library/LockBoxLib/LockBoxLib.h | 2 +-
> OvmfPkg/Library/PlatformSecureLib/PlatformSecureLib.c | 4 +-
> OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLib.c | 2 +-
> OvmfPkg/Library/XenIoMmioLib/XenIoMmioLib.c | 2 +-
> OvmfPkg/PlatformPei/Xen.c | 2 +-
> OvmfPkg/SataControllerDxe/ComponentName.c | 6 +-
> OvmfPkg/SataControllerDxe/SataController.c | 214 ++++++++++++++++++++++++-------------------------
> OvmfPkg/SataControllerDxe/SataController.h | 208 +++++++++++++++++++++++------------------------
> OvmfPkg/SataControllerDxe/SataControllerDxe.inf | 6 +-
> OvmfPkg/Sec/SecMain.c | 34 ++++----
> UefiCpuPkg/Application/Cpuid/Cpuid.c | 2 +-
> 122 files changed, 3882 insertions(+), 3882 deletions(-)
>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Anthony Perard <anthony.perard@citrix.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Bob Feng <bob.c.feng@intel.com>
> Cc: Dandan Bi <dandan.bi@intel.com>
> Cc: David Woodhouse <dwmw2@infradead.org>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Julien Grall <julien.grall@arm.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Zhichao Gao <zhichao.gao@intel.com>
> --
> 2.20.1
>
prev parent reply other threads:[~2019-09-19 19:21 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-19 18:06 [PATCH 0/7] Strip trailing whitespace Leif Lindholm
2019-09-19 18:06 ` [PATCH 1/7] ArmPkg: strip " Leif Lindholm
2019-09-23 9:46 ` [edk2-devel] " Philippe Mathieu-Daudé
2019-09-19 18:06 ` [PATCH 2/7] ArmPlatformPkg: " Leif Lindholm
2019-09-23 9:46 ` [edk2-devel] " Philippe Mathieu-Daudé
2019-09-19 18:06 ` [PATCH 3/7] BaseTools: " Leif Lindholm
2019-09-20 6:06 ` Liming Gao
2019-09-20 10:37 ` Leif Lindholm
2019-09-23 5:28 ` Liming Gao
2019-09-19 18:06 ` [PATCH 4/7] EmulatorPkg: " Leif Lindholm
2019-09-19 18:28 ` [edk2-devel] " Ni, Ray
2019-09-23 9:46 ` Philippe Mathieu-Daudé
2019-09-19 18:06 ` [PATCH 5/7] MdeModulePkg: " Leif Lindholm
2019-09-20 1:03 ` [edk2-devel] " Wu, Hao A
2019-09-19 18:06 ` [PATCH 6/7] OvmfPkg: " Leif Lindholm
2019-09-20 6:13 ` [edk2-devel] " Laszlo Ersek
2019-09-20 10:24 ` Leif Lindholm
2019-09-23 9:49 ` Philippe Mathieu-Daudé
2019-09-24 16:05 ` Laszlo Ersek
2019-09-19 18:06 ` [PATCH 7/7] UefiCpuPkg: " Leif Lindholm
2019-09-19 18:28 ` [edk2-devel] " Ni, Ray
2019-09-23 9:49 ` Philippe Mathieu-Daudé
2019-09-19 19:20 ` Ard Biesheuvel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKv+Gu-1FPqdUJ0VXVZAMtpQ7VUfgRLBcq3s=rtNha+w63B0gg@mail.gmail.com' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox