From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=R2luER6l; spf=pass (domain: linaro.org, ip: 209.85.128.68, mailfrom: ard.biesheuvel@linaro.org) Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by groups.io with SMTP; Thu, 19 Sep 2019 12:21:19 -0700 Received: by mail-wm1-f68.google.com with SMTP id 5so6001324wmg.0 for ; Thu, 19 Sep 2019 12:21:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Jxh+HKBME6Nlq8cFa6DN/3cvCT/3Q5yz5BBz5Nq38pE=; b=R2luER6lrvjNLH1JOZcAqmPWkaqK9jUzEnciyaP0l7GqrHzs9mM2Z3WdW5uN8Pq0B2 bmsTg413MMkHHm/KBiLjnWhpkQo+uSeHaBWoCZT5nzLjCedLJNddz6aiiZ3Nj4BtGYyd vwoqObqtXbTbmEhTuQAwh8dNvDyo4U9ZX7t5EKFBJdesQ6eyIYdL4ytG0GQQazdex4F+ EzVIn7w4Z1Nmt634Uu/Ypt6CfsUJtNus6LctVcvb1bR4hfoFd9t5fdKc9/MhKQsghhMM KukWBLEZpDviMP5Dfv4caFDflumSBaO0sddtnCMtwU5mzpKovvgx4OLYqeYYgtgscp4j tt3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Jxh+HKBME6Nlq8cFa6DN/3cvCT/3Q5yz5BBz5Nq38pE=; b=mRzu1zZev7zJQqR392WA1lu1o1U3DGE48OhT/CmMzYLYZVGiDtNCjAqxbMhkEOCBNN 0O7NyvtHR7NrdV229I6GHH3B42YPpsSIg8C0dEE8/WWBwp1EW+EIBybEmezIIAqG261o KdK8KXNKokFNYPASjDF3bXl0ePg9aVVxHehZ0/RnYne5MyqNWw2re8H2RJwFYYXDlX9W 6bgvUgDBcbKPJ/Tds43gKOhexB7SBvZF6v04dFYWeKoCkmlVFXS9VUgMgZUE5heW36DV V32O/crt5/cmkkqduVhaYlp32E3AvckbBOjPWMkSxTnab1wm7fG8wKZ4IgLL/kJh8HuZ lnaw== X-Gm-Message-State: APjAAAWVPmwM4JDdPx3RyESB3rYkrGYU+rvoZIOYHuNKzIVNs69o6QAv evGNi1hTm+5hV9DCgUvi3mfgOzLHgCu+h4Wy4gmmQA== X-Google-Smtp-Source: APXvYqySEZDArhO+f0mfUa621PnXQ9m0VDMXKd1xnG4dwMCeSZPdNWCBPM+OO1ZH+0nQPm0aBt7E7CIukfojAM36Ow4= X-Received: by 2002:a7b:c451:: with SMTP id l17mr3712420wmi.61.1568920877170; Thu, 19 Sep 2019 12:21:17 -0700 (PDT) MIME-Version: 1.0 References: <20190919180625.29150-1-leif.lindholm@linaro.org> In-Reply-To: <20190919180625.29150-1-leif.lindholm@linaro.org> From: "Ard Biesheuvel" Date: Thu, 19 Sep 2019 22:20:48 +0300 Message-ID: Subject: Re: [PATCH 0/7] Strip trailing whitespace To: Leif Lindholm Cc: edk2-devel-groups-io , Andrew Fish , Anthony Perard , Bob Feng , Dandan Bi , David Woodhouse , Eric Dong , Hao A Wu , Jian J Wang , Jordan Justen , Julien Grall , Laszlo Ersek , Liming Gao , Ray Ni , Zhichao Gao Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 19 Sep 2019 at 21:06, Leif Lindholm wrot= e: > > *cough* 5-6/7 do take a bit of a shotgun approach with the Cc:s, but I > would prefer not breaking the set up any more than it already is. > The changes are however trivial, so hopefully not much of an issue. > > Before we start looking into migrating the repository to native > line endings, let's start by killing off a bunch of trailing > whitespace. > > This is basically the output of: > for filetype in '*.c' '*.h' '*.s' '*.S' '*.asm' '*.py' '*.inf' '*.inc' '*= .dsc' '*.fdf' '*.dec' '*.uni' '*.txt' '*.md' '*.nasm' '*.vfr' '*.asl' '*.as= lc' '*.asm16' '*makefile' '*.common' '*.cpp'; do find * -type f -iname "$fi= letype" -exec sed --in-place 's/[[:blank:]]\+\(\r*\)$/\1/' {} \;; done > executed in the top-level directory. > > This does mess about with some imported projects, but I figure if > we keep them in the tree, we might as well clean it up. > > Since we have some weird and wonderful file types in the tree, I think we= can > only realy ever run automated fixups on a "whitelist" of file types. Plea= se > let me know if I have left any important ones out from this operation. > > (Why yes, that .S _is_ totally redundant given the use of -iname, but at = least I'm being honest.) > > These patches, as well as the preceding line ending and character > encoding cleanup can also be accessed at: > https://git.linaro.org/people/leif.lindholm/edk2.git/log/?h=3Dpre-CRLF2LF= -cleanup > > Leif Lindholm (7): > ArmPkg: strip trailing whitespace > ArmPlatformPkg: strip trailing whitespace > OvmfPkg: strip trailing whitespace For the above, Acked-by: Ard Biesheuvel > BaseTools: strip trailing whitespace > EmulatorPkg: strip trailing whitespace > MdeModulePkg: strip trailing whitespace > UefiCpuPkg: strip trailing whitespace > > ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf = | 4 +- > ArmPlatformPkg/Scripts/Ds5/profile.py = | 2 +- > ArmPlatformPkg/Scripts/Makefile = | 2 +- > BaseTools/Source/C/BrotliCompress/tools/brotli.c = | 2 +- > BaseTools/Source/C/GNUmakefile = | 2 +- > BaseTools/Source/C/LzmaCompress/Sdk/C/7zFile.c = | 20 ++--- > BaseTools/Source/C/LzmaCompress/Sdk/C/7zTypes.h = | 4 +- > BaseTools/Source/C/LzmaCompress/Sdk/C/Alloc.c = | 22 ++--- > BaseTools/Source/C/LzmaCompress/Sdk/C/Bra.h = | 8 +- > BaseTools/Source/C/LzmaCompress/Sdk/C/LzFind.c = | 70 ++++++++-------- > BaseTools/Source/C/LzmaCompress/Sdk/C/LzFind.h = | 4 +- > BaseTools/Source/C/LzmaCompress/Sdk/C/LzFindMt.c = | 40 ++++----- > BaseTools/Source/C/LzmaCompress/Sdk/C/LzFindMt.h = | 4 +- > BaseTools/Source/C/LzmaCompress/Sdk/C/LzmaDec.c = | 30 +++---- > BaseTools/Source/C/LzmaCompress/Sdk/C/LzmaDec.h = | 4 +- > BaseTools/Source/C/LzmaCompress/Sdk/C/LzmaEnc.c = | 194 ++++++++++++++++++++++---------------------- > BaseTools/Source/C/LzmaCompress/Sdk/C/Threads.c = | 6 +- > BaseTools/Source/C/LzmaCompress/Sdk/DOC/lzma-history.txt = | 92 ++++++++++----------- > BaseTools/Source/C/LzmaCompress/Sdk/DOC/lzma-sdk.txt = | 102 +++++++++++------------ > BaseTools/Source/C/Makefiles/app.makefile = | 4 +- > BaseTools/Source/C/Makefiles/footer.makefile = | 4 +- > BaseTools/Source/C/Makefiles/header.makefile = | 8 +- > BaseTools/Source/C/Makefiles/lib.makefile = | 2 +- > BaseTools/Source/C/Makefiles/ms.common = | 4 +- > BaseTools/Source/C/VfrCompile/GNUmakefile = | 6 +- > BaseTools/Source/C/VfrCompile/Pccts/CHANGES_FROM_131.txt = | 2 +- > BaseTools/Source/C/VfrCompile/Pccts/CHANGES_FROM_133.txt = | 286 ++++++++++++++++++++++++++++++++--------------------------------- > BaseTools/Source/C/VfrCompile/Pccts/CHANGES_FROM_133_BEFORE_MR13.txt = | 2 +- > BaseTools/Source/C/VfrCompile/Pccts/CHANGES_SUMMARY.txt = | 6 +- > BaseTools/Source/C/VfrCompile/Pccts/KNOWN_PROBLEMS.txt = | 20 ++--- > BaseTools/Source/C/VfrCompile/Pccts/antlr/antlr.c = | 194 ++++++++++++++++++++++---------------------- > BaseTools/Source/C/VfrCompile/Pccts/antlr/bits.c = | 10 +-- > BaseTools/Source/C/VfrCompile/Pccts/antlr/build.c = | 18 ++--- > BaseTools/Source/C/VfrCompile/Pccts/antlr/dumpcycles.c = | 8 +- > BaseTools/Source/C/VfrCompile/Pccts/antlr/egman.c = | 12 +-- > BaseTools/Source/C/VfrCompile/Pccts/antlr/fcache.c = | 8 +- > BaseTools/Source/C/VfrCompile/Pccts/antlr/fset.c = | 16 ++-- > BaseTools/Source/C/VfrCompile/Pccts/antlr/fset2.c = | 16 ++-- > BaseTools/Source/C/VfrCompile/Pccts/antlr/gen.c = | 78 +++++++++--------- > BaseTools/Source/C/VfrCompile/Pccts/antlr/generic.h = | 2 +- > BaseTools/Source/C/VfrCompile/Pccts/antlr/hash.c = | 10 +-- > BaseTools/Source/C/VfrCompile/Pccts/antlr/lex.c = | 6 +- > BaseTools/Source/C/VfrCompile/Pccts/antlr/main.c = | 40 ++++----- > BaseTools/Source/C/VfrCompile/Pccts/antlr/makefile = | 4 +- > BaseTools/Source/C/VfrCompile/Pccts/antlr/misc.c = | 42 +++++----- > BaseTools/Source/C/VfrCompile/Pccts/antlr/mrhoist.c = | 4 +- > BaseTools/Source/C/VfrCompile/Pccts/antlr/pred.c = | 4 +- > BaseTools/Source/C/VfrCompile/Pccts/antlr/scan.c = | 4072 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++= +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++= +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++= +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++= +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++= +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++= ++++++++++++++++++---------------------------------------------------------= ---------------------------------------------------------------------------= ---------------------------------------------------------------------------= ---------------------------------------------------------------------------= ---------------------------------------------------------------------------= ---------------------------------------------------------------------------= -------------------------- > BaseTools/Source/C/VfrCompile/Pccts/dlg/automata.c = | 10 +-- > BaseTools/Source/C/VfrCompile/Pccts/dlg/dlg.h = | 2 +- > BaseTools/Source/C/VfrCompile/Pccts/dlg/dlg_a.c = | 950 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++= ++++++++++++++++++++++++++++++++++++++++++---------------------------------= -------------------------------------------------------------------------- > BaseTools/Source/C/VfrCompile/Pccts/dlg/dlg_p.c = | 30 +++---- > BaseTools/Source/C/VfrCompile/Pccts/dlg/main.c = | 10 +-- > BaseTools/Source/C/VfrCompile/Pccts/dlg/makefile = | 2 +- > BaseTools/Source/C/VfrCompile/Pccts/dlg/output.c = | 4 +- > BaseTools/Source/C/VfrCompile/Pccts/dlg/relabel.c = | 4 +- > BaseTools/Source/C/VfrCompile/Pccts/dlg/support.c = | 2 +- > BaseTools/Source/C/VfrCompile/Pccts/h/AParser.cpp = | 8 +- > BaseTools/Source/C/VfrCompile/Pccts/h/AParser.h = | 4 +- > BaseTools/Source/C/VfrCompile/Pccts/h/ASTBase.cpp = | 8 +- > BaseTools/Source/C/VfrCompile/Pccts/h/ATokenBuffer.cpp = | 6 +- > BaseTools/Source/C/VfrCompile/Pccts/h/DLG_stream_input.h = | 22 ++--- > BaseTools/Source/C/VfrCompile/Pccts/h/DLexerBase.cpp = | 2 +- > BaseTools/Source/C/VfrCompile/Pccts/h/PBlackBox.h = | 8 +- > BaseTools/Source/C/VfrCompile/Pccts/h/PCCTSAST.cpp = | 8 +- > BaseTools/Source/C/VfrCompile/Pccts/h/antlr.h = | 10 +-- > BaseTools/Source/C/VfrCompile/Pccts/h/ast.c = | 4 +- > BaseTools/Source/C/VfrCompile/Pccts/h/err.h = | 70 ++++++++-------- > BaseTools/Source/C/VfrCompile/Pccts/history.txt = | 6 +- > BaseTools/Source/C/VfrCompile/Pccts/support/genmk/genmk.c = | 14 ++-- > BaseTools/Source/C/VfrCompile/Pccts/support/genmk/genmk_old.c = | 4 +- > BaseTools/Source/C/VfrCompile/Pccts/support/rexpr/rexpr.c = | 46 +++++------ > BaseTools/Source/C/VfrCompile/Pccts/support/set/set.c = | 46 +++++------ > BaseTools/Source/C/VfrCompile/Pccts/support/set/set.h = | 4 +- > BaseTools/Source/C/VfrCompile/Pccts/support/sym/sym.c = | 26 +++--- > BaseTools/Source/Python/Ecc/Check.py = | 2 +- > BaseTools/Source/Python/GenFds/GenFdsGlobalVariable.py = | 2 +- > BaseTools/Source/Python/Makefile = | 2 +- > EmulatorPkg/Readme.md = | 4 +- > MdeModulePkg/Application/UiApp/FrontPageVfr.Vfr = | 8 +- > MdeModulePkg/Library/DeviceManagerUiLib/DeviceManagerVfr.Vfr = | 2 +- > MdeModulePkg/Library/LzmaCustomDecompressLib/Sdk/C/7zTypes.h = | 4 +- > MdeModulePkg/Library/LzmaCustomDecompressLib/Sdk/C/Bra.h = | 8 +- > MdeModulePkg/Library/LzmaCustomDecompressLib/Sdk/C/LzFind.c = | 70 ++++++++-------- > MdeModulePkg/Library/LzmaCustomDecompressLib/Sdk/C/LzFind.h = | 4 +- > MdeModulePkg/Library/LzmaCustomDecompressLib/Sdk/C/LzmaDec.c = | 30 +++---- > MdeModulePkg/Library/LzmaCustomDecompressLib/Sdk/C/LzmaDec.h = | 4 +- > MdeModulePkg/Library/LzmaCustomDecompressLib/Sdk/DOC/lzma-history.txt = | 92 ++++++++++----------- > MdeModulePkg/Library/LzmaCustomDecompressLib/Sdk/DOC/lzma-sdk.txt = | 102 +++++++++++------------ > MdeModulePkg/Universal/DriverHealthManagerDxe/DriverHealthConfigureVfr.V= fr | 6 +- > MdeModulePkg/Universal/DriverHealthManagerDxe/DriverHealthManagerVfr.Vfr= | 4 +- > MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/OnigurumaUefiPort.= c | 2 +- > MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/OnigurumaUefiPort.= h | 2 +- > MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/regexec.c = | 2 +- > OvmfPkg/AcpiPlatformDxe/AcpiPlatform.c = | 4 +- > OvmfPkg/AcpiPlatformDxe/Xen.c = | 8 +- > OvmfPkg/AcpiTables/Facs.aslc = | 6 +- > OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiVfr.Vfr = | 18 ++--- > OvmfPkg/Include/IndustryStandard/Xen/arch-x86/xen-x86_32.h = | 4 +- > OvmfPkg/Include/IndustryStandard/Xen/arch-x86/xen-x86_64.h = | 4 +- > OvmfPkg/Include/IndustryStandard/Xen/arch-x86/xen.h = | 4 +- > OvmfPkg/Include/IndustryStandard/Xen/hvm/params.h = | 2 +- > OvmfPkg/Include/IndustryStandard/Xen/io/protocols.h = | 2 +- > OvmfPkg/Include/IndustryStandard/Xen/io/ring.h = | 34 ++++---- > OvmfPkg/Include/IndustryStandard/Xen/memory.h = | 4 +- > OvmfPkg/Include/IndustryStandard/Xen/xen-compat.h = | 4 +- > OvmfPkg/Include/IndustryStandard/Xen/xen.h = | 10 +-- > OvmfPkg/Include/Register/QemuSmramSaveStateMap.h = | 2 +- > OvmfPkg/Library/DxePciLibI440FxQ35/PciLib.c = | 12 +-- > OvmfPkg/Library/LockBoxLib/LockBoxDxe.c = | 2 +- > OvmfPkg/Library/LockBoxLib/LockBoxLib.c = | 2 +- > OvmfPkg/Library/LockBoxLib/LockBoxLib.h = | 2 +- > OvmfPkg/Library/PlatformSecureLib/PlatformSecureLib.c = | 4 +- > OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLib.c = | 2 +- > OvmfPkg/Library/XenIoMmioLib/XenIoMmioLib.c = | 2 +- > OvmfPkg/PlatformPei/Xen.c = | 2 +- > OvmfPkg/SataControllerDxe/ComponentName.c = | 6 +- > OvmfPkg/SataControllerDxe/SataController.c = | 214 ++++++++++++++++++++++++------------------------- > OvmfPkg/SataControllerDxe/SataController.h = | 208 +++++++++++++++++++++++------------------------ > OvmfPkg/SataControllerDxe/SataControllerDxe.inf = | 6 +- > OvmfPkg/Sec/SecMain.c = | 34 ++++---- > UefiCpuPkg/Application/Cpuid/Cpuid.c = | 2 +- > 122 files changed, 3882 insertions(+), 3882 deletions(-) > > Cc: Andrew Fish > Cc: Anthony Perard > Cc: Ard Biesheuvel > Cc: Bob Feng > Cc: Dandan Bi > Cc: David Woodhouse > Cc: Eric Dong > Cc: Hao A Wu > Cc: Jian J Wang > Cc: Jordan Justen > Cc: Julien Grall > Cc: Laszlo Ersek > Cc: Liming Gao > Cc: Ray Ni > Cc: Zhichao Gao > -- > 2.20.1 >