From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Liming Gao <liming.gao@intel.com>
Cc: edk2-devel-01 <edk2-devel@lists.01.org>
Subject: Re: [Patch] MdePkg BaseMemoryLibOptDxe: Add function comment for InternalMemCompareGuid
Date: Thu, 20 Oct 2016 10:14:03 +0100 [thread overview]
Message-ID: <CAKv+Gu-1cVoxUG-qRdHRFrKDkENPoEBSj=MRVf1=5Q1cfSOf9g@mail.gmail.com> (raw)
In-Reply-To: <1476943142-12672-1-git-send-email-liming.gao@intel.com>
On 20 October 2016 at 06:59, Liming Gao <liming.gao@intel.com> wrote:
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Liming Gao <liming.gao@intel.com>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
> MdePkg/Library/BaseMemoryLibOptDxe/Arm/MemLibGuid.c | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/MdePkg/Library/BaseMemoryLibOptDxe/Arm/MemLibGuid.c b/MdePkg/Library/BaseMemoryLibOptDxe/Arm/MemLibGuid.c
> index 8f1e50b..47386e9 100644
> --- a/MdePkg/Library/BaseMemoryLibOptDxe/Arm/MemLibGuid.c
> +++ b/MdePkg/Library/BaseMemoryLibOptDxe/Arm/MemLibGuid.c
> @@ -15,6 +15,19 @@
>
> #include "MemLibInternals.h"
>
> +/**
> + Internal function to compare two GUIDs.
> +
> + This function compares Guid1 to Guid2. If the GUIDs are identical then TRUE is returned.
> + If there are any bit differences in the two GUIDs, then FALSE is returned.
> +
> + @param Guid1 A pointer to a 128 bit GUID.
> + @param Guid2 A pointer to a 128 bit GUID.
> +
> + @retval TRUE Guid1 and Guid2 are identical.
> + @retval FALSE Guid1 and Guid2 are not identical.
> +
> +**/
> BOOLEAN
> EFIAPI
> InternalMemCompareGuid (
> --
> 2.8.0.windows.1
>
prev parent reply other threads:[~2016-10-20 9:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-20 5:59 [Patch] MdePkg BaseMemoryLibOptDxe: Add function comment for InternalMemCompareGuid Liming Gao
2016-10-20 9:14 ` Ard Biesheuvel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKv+Gu-1cVoxUG-qRdHRFrKDkENPoEBSj=MRVf1=5Q1cfSOf9g@mail.gmail.com' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox